aaron.ballman added a comment.

Attribute bits look good to me, but I'd appreciate if @dblaikie could weigh in 
on whether he thinks the CodeGen changes are fine. My concern there is around 
whether the changes to function signatures to accept a `TypeLoc` are reasonable 
or not.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:2031
+all targets. It only has effect when ``-g`` is specified on the command line 
and
+may only be specified on a pointer type.
+
----------------
This makes it a bit more clear what the current behavior is and that we might 
change that behavior in the future,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111199/new/

https://reviews.llvm.org/D111199

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to