[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. If this is something we think we wouldn't want in clang-format, what about the idea of building a new binary which did allow the modification of the tokens, This comes up from time to time and I kind of feel its a weak argument for those that don't want to use it

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. This change I suspect is causing a build failure on a build bot. https://lab.llvm.org/buildbot/#/builders/110/builds/4827 FAILED: /usr/bin/c++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna created this revision. sriharikrishna added reviewers: jdoerfert, ABataev, RaviNarayanaswamy. Herald added a subscriber: hiraditya. sriharikrishna requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Im

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 358193. kito-cheng added a comment. Changes: - Handle arch attribute emition in RISCVTargetStreamer.cpp, thanks @khchen for reminding me that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ http

[PATCH] D105629: [TSan] Add SystemZ support

uweigand added a comment. See inline comments ... otherwise the SystemZ platform-specific parts look good to me. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123 +#if defined(__s390x__) + ProtectRange(HiAppMemEnd(), 0xf000ull); +#endif

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

steffenlarsen accepted this revision. steffenlarsen added a comment. This revision is now accepted and ready to land. Thank you for addressing my concerns. I am happy with the changes. Great work! Comment at: clang/test/CodeGen/builtins-nvptx-mma.py:35-38 +def make_mma_ops(geom

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

frasercrmck added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vfredusum-rv32.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+d,+experimental-zfh -verify-machineinstrs \

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 358204. RedDocMD added a comment. Removed stupid mistakes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

HsiangKai updated this revision to Diff 358205. HsiangKai added a comment. Add the TA argument to most of the intrinsics with mask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 Files: clang/include/c

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

vsavchenko accepted this revision. vsavchenko added a comment. In D105421#2873458 , @RedDocMD wrote: > Removed stupid mistakes No need for self deprecation here! Thanks for addressing these! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D105629: [TSan] Add SystemZ support

iii added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123 +#if defined(__s390x__) + ProtectRange(HiAppMemEnd(), 0xf000ull); +#endif uweigand wrote: > Did you test this on older kernels without 5-level page table supp

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

luismarques added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vfredusum-rv32.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+d,+experimental-zfh -verify-machineinstrs \

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski created this revision. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For boolean options, e.g. `-fxor-operator/-fno-xor-operator`, we ought to be using TableGen multiclasses. This way

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:246 +class EmptyKPM : KeyPathAndMacro<"", "", ""> {} class DiagnosticOpts @jansvoboda11 , is this the right approach here? I'd like use `BoolFOption` in Flang, but we don't ne

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

nemanjai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9754 "this builtin is only valid on POWER7 or later CPUs">; +def err_ppc_builtin_only_on_pwr9 : Error< + "this builtin is only valid on POWER9 or later CPUs">; No lon

[clang] 78463eb - [OpenCL] Add support of __opencl_c_generic_address_space feature macro

Author: Anton Zabaznov Date: 2021-07-13T13:14:10+03:00 New Revision: 78463ebde2f8a1b8ce984c1ae7c6da0c2d323005 URL: https://github.com/llvm/llvm-project/commit/78463ebde2f8a1b8ce984c1ae7c6da0c2d323005 DIFF: https://github.com/llvm/llvm-project/commit/78463ebde2f8a1b8ce984c1ae7c6da0c2d323005.diff

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG78463ebde2f8: [OpenCL] Add support of __opencl_c_generic_address_space feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D105629: [TSan] Add SystemZ support

uweigand added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123 +#if defined(__s390x__) + ProtectRange(HiAppMemEnd(), 0xf000ull); +#endif iii wrote: > uweigand wrote: > > Did you test this on older kernels without 5-l

[PATCH] D105629: [TSan] Add SystemZ support

iii added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123 +#if defined(__s390x__) + ProtectRange(HiAppMemEnd(), 0xf000ull); +#endif uweigand wrote: > iii wrote: > > uweigand wrote: > > > Did you test this on older ke

[PATCH] D105629: [TSan] Add SystemZ support

uweigand added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp:123 +#if defined(__s390x__) + ProtectRange(HiAppMemEnd(), 0xf000ull); +#endif iii wrote: > uweigand wrote: > > iii wrote: > > > uweigand wrote: > > > > Did y

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

mizvekov updated this revision to Diff 358224. mizvekov edited the summary of this revision. mizvekov added a comment. - Fix minor nits. - Please Dijkstra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105756/new/ https://reviews.llvm.org/D105756

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

mizvekov added inline comments. Comment at: clang/test/SemaObjCXX/block-capture.mm:40 }; -TEST(CopyNoMove); // cxx11_2b-error {{call to deleted constructor}} +TEST(CopyNoMove); // cxx98_2b-error {{call to deleted constructor}} Quuxplusone wrote: > `cxx98_2b` i

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! PS this patch is straightforward and doesn't seem to affect functionality for older standards provided that we set `__opencl_c_generic_address_space` correctly which is no

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18 entry: - %0 = bitcast i64* %a to i8* - %1 = tail call i64 @llvm.ppc.ldarx(i8* %0) - ret i64 %1 + %0 = call i64 asm sideeffect "ldarx $0, $1", "=

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

nemanjai added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18 entry: - %0 = bitcast i64* %a to i8* - %1 = tail call i64 @llvm.ppc.ldarx(i8* %0) - ret i64 %1 + %0 = call i64 asm sideeffect "ldarx $0, $1", "

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18 entry: - %0 = bitcast i64* %a to i8* - %1 = tail call i64 @llvm.ppc.ldarx(i8* %0) - ret i64 %1 + %0 = call i64 asm sideeffect "ldarx $0, $1", "=

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 358028. Conanap added a comment. Updated a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/bui

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 358032. Conanap added a comment. Updated lwarx test case with modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clan

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

phosek added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or similar shipping vehicules. If you +are a user merely tr

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Ericson2314 updated this revision to Diff 358057. Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Fixes from comments, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105765/new/ https://reviews.llvm.org/D105765 Fi

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Ericson2314 added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or similar shipping vehicules. If you +are a user mere

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 __

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105765/new/ https://reviews.llvm.org/D105765 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2873225 , @MyDeveloperDay wrote: > If this is something we think we wouldn't want in clang-format, what about > the idea of building a new binary which did allow the modification of the > tokens, This comes up fr

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:246 +class EmptyKPM : KeyPathAndMacro<"", "", ""> {} class DiagnosticOpts awarzynski wrote: > @jansvoboda11 , is this the right approach here? I'd like use `BoolFOption` > i

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 358236. azabaznov added a comment. Update test after generic AS was merged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCL

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

hokein added a comment. In D105478#2867120 , @adamcz wrote: > OK, I think we've got it now :-) > > I kept the original crash test in the change, but I'm not sure if it's > appropriate anymore. Let me know if you think I should remove it. Thanks, that so

[PATCH] D105014: added some example code for llvm::Expected

sammccall added a comment. In D105014#2872674 , @dblaikie wrote: > +@lhames for context as the author/owner of `llvm::Error` and associated > things. > > Perhaps it'd be handy to have some descriptions of the problems you > encountered, @kuhnel, and how

[clang] ab76101 - [OpenCL] Add support of __opencl_c_read_write_images feature macro

Author: Anton Zabaznov Date: 2021-07-13T15:38:23+03:00 New Revision: ab76101f40f80bbec82073fc5bfddd7203e63a52 URL: https://github.com/llvm/llvm-project/commit/ab76101f40f80bbec82073fc5bfddd7203e63a52 DIFF: https://github.com/llvm/llvm-project/commit/ab76101f40f80bbec82073fc5bfddd7203e63a52.diff

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGab76101f40f8: [OpenCL] Add support of __opencl_c_read_write_images feature macro (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10491

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

sammccall marked 5 inline comments as done. sammccall added a comment. In D105679#2873109 , @nridge wrote: > Will building with this option just prevent linking the clang-tidy checks > into clangd, or will it also prevent building them in the first place

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

sammccall updated this revision to Diff 358241. sammccall marked 3 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105679/new/ https://reviews.llvm.org/D105679 Files: clan

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1203 +if (!Opts.ShouldSupportSymbolicIntegerCasts) + return VisitSymExpr(Sym); + vsavchenko wrote: > Why do you use `VisitSymExpr` here? You want t

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:246 +class EmptyKPM : KeyPathAndMacro<"", "", ""> {} class DiagnosticOpts jansvoboda11 wrote: > awarzynski wrote: > > @jansvoboda11 , is this the right approach here? I'd like

[PATCH] D105890: Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

bgraur created this revision. Herald added a reviewer: aaron.ballman. bgraur requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105890 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D105365: [Lexer] Fix bug in `makeFileCharRange` called on split tokens.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about this. I stared at this a few times and it *seems* right to me, and fixes the bug... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

glaubitz added a comment. In D105457#2873294 , @dyung wrote: > This change I suspect is causing a build failure on a build bot. > > https://lab.llvm.org/buildbot/#/builders/110/builds/4827 > > FAILED: /usr/bin/c++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1

sammccall added a comment. In D98710#2873141 , @chh wrote: > Sam, the revision summary is updated. Could you review it again? Just to clarify - the code hasn't changed since last review pass right? I think the comments there still apply. Happy to review

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; vsavchenko wrote: > Do you think

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

thakis added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7412 +!S.getOpenCLOptions().isSupported("__opencl_c_read_write_images", + S.getLangOpts( || DeclTy->isPipeType()) { A

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield updated this revision to Diff 358248. JonChesterfield added a comment. - reduce patch to only dropping cuda define Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D105221 Files: clang/lib/Header

[PATCH] D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. I can commit the patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105890/new/ https://reviews.llvm.org/D105890

[clang] 45ffe63 - [clang/objc] Optimize getters for non-atomic, copied properties

Author: Dave MacLachlan Date: 2021-07-13T09:22:13-04:00 New Revision: 45ffe6341d9642487785b0d0028166e6fbdbe5d7 URL: https://github.com/llvm/llvm-project/commit/45ffe6341d9642487785b0d0028166e6fbdbe5d7 DIFF: https://github.com/llvm/llvm-project/commit/45ffe6341d9642487785b0d0028166e6fbdbe5d7.dif

[PATCH] D105311: Optimize getters for non-atomic, copied properties

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ffe6341d96: [clang/objc] Optimize getters for non-atomic, copied properties (authored by dmaclach, committed by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield updated this revision to Diff 358250. JonChesterfield added a comment. - reduce patch to only dropping cuda define v2, now with missing save Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D105221

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield added a comment. Cut down to only dropping the cuda define, which is sufficient to resolve D104904 . Haven't build/tested this diff yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ ht

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. I'll allocate some time to get into your summary, but for now here are my concerns about `SymbolRangeInferrer` and `VisitSymbolCast`. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1203 +if (!Opts.ShouldSupportSymbolicInteg

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

azabaznov created this revision. azabaznov added reviewers: Anastasia, thakis. Herald added a reviewer: aaron.ballman. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9533b849207: [NFC] Add paranthesis around logical expression to silence -Wlogical-op… (authored by bgraur, committed by alexfh). Repository: rG L

[clang] e9533b8 - [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

Author: Bogdan Graur Date: 2021-07-13T15:54:31+02:00 New Revision: e9533b84920798cf9b35d26586a61bad0a1f9825 URL: https://github.com/llvm/llvm-project/commit/e9533b84920798cf9b35d26586a61bad0a1f9825 DIFF: https://github.com/llvm/llvm-project/commit/e9533b84920798cf9b35d26586a61bad0a1f9825.diff

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7412 +!S.getOpenCLOptions().isSupported("__opencl_c_read_write_images", + S.getLangOpts( || DeclTy->isPipeType()) { ---

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; ASDenysPetrov wrote: > vsavchenko wr

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

PeteSteinfeld requested changes to this revision. PeteSteinfeld added a comment. This revision now requires changes to proceed. This built OK, but when I run `check-flang`, I see errors for `.../Driver/driver-help.f90` and `.../Driver/driver-help-hidden.f90`. I'm building on a Linux system usin

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

thakis added a comment. This is not NFC, is it? Before, this got evaluated as `(!S.getLangOpts().OpenCLCPlusPlus && S.getLangOpts().OpenCLVersion < 200) || (S.getLangOpts().OpenCLVersion == 300 && !S.getOpenCLOptions().isSupported("__opencl_c_read_write_images", S.getLangOpts()))`. Now, it's e

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:259 +class T{$explicit[[]]$constructor[[T]](int a);}; + sammccall

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

aaron.ballman added a reviewer: alexfh. aaron.ballman added a comment. Note: https://reviews.llvm.org/D105890 that was just landed to touch the same area. FWIW, I agree that this should probably be using some local variables to make the conditions a bit more clear. Repository: rG LLVM Githu

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

nemanjai added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-fp.c:5 +// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown \ +// RUN: -emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN: %clang_cc1 -triple powerpc64-unknown-aix \

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Requesting changes to keep the queue accurate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/

[PATCH] D105890: [NFC] Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

thakis added a comment. I think this is incorrect. See D105892 and https://reviews.llvm.org/D104915#2873851 . Don't blindly land changes to suppress warnings – the warnings exist to tell us something :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Requesting changes to remove it from the queue until comments are addressed or answered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358261. ZarkoCA added a comment. - Add a warning group for this warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files: clang/include/clang/Basic/DiagnosticG

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Also if we are going to be emitting this complex sequence, in the description of the patch, point out the test case that shows the back end handles this and emits a single instru

[PATCH] D105873: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Thanks for the fix. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105873/new/ https://reviews.llvm.org/D105873 _

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; vsavchenko wrote: > ASDenysPetrov

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

amyk accepted this revision. amyk added a comment. Minor indentation comments but LGTM. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:3 // RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ -// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

azabaznov updated this revision to Diff 358265. azabaznov added a comment. Add comment for C++ for OpenCL, add variable to check support for OpenCL C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105892/new/ https://reviews.llvm.org/D105892 Files:

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Sema/Sema.h:12559 bool SemaBuiltinOSLogFormat(CallExpr *TheCall); + bool CheckPPCisRunOfOnes(CallExpr *TheCall, unsigned

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 358267. RedDocMD added a comment. Fixing up tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVal

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1203 +if (!Opts.ShouldSupportSymbolicIntegerCasts) + return VisitSymExpr(Sym); + ASDenysPetrov wrote: > vsavchenko wrote: > > ASDenysPetrov wrote: > >

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. Is the syntax of specifying expected notes and warnings documented somewhere? I could not find the note-specific syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105892/new/ https://reviews.llvm.org/D105892

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

Anastasia added a comment. In D105892#2873951 , @aaron.ballman wrote: > Note: https://reviews.llvm.org/D105890 that was just landed to touch the same > area. Yeah, I think it fixed the actual warning but we can still simplify the condition. Reposito

[clang] 1e03c37 - Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Author: John Ericson Date: 2021-07-13T15:21:41Z New Revision: 1e03c37b97b6176a60404d84665c40321f4e33a4 URL: https://github.com/llvm/llvm-project/commit/1e03c37b97b6176a60404d84665c40321f4e33a4 DIFF: https://github.com/llvm/llvm-project/commit/1e03c37b97b6176a60404d84665c40321f4e33a4.diff LOG:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#2867693 , @ABataev wrote: > In D102107#2867670 , @josemonsalve2 > wrote: > >> In D102107#2867417 , @ABataev >> wrote: >> >>> In D10

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:246 +class EmptyKPM : KeyPathAndMacro<"", "", ""> {} class DiagnosticOpts awarzynski wrote: > jansvoboda11 wrote: > > awarzynski wrote: > > > @jansvoboda11 , is this the righ

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: ormris, okura, kuter, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, cfe-commits, bbn, sstefan1. Herald a

[clang] 03d8fed - [OpenCL] Add verbosity when checking support of read_write images

Author: Anton Zabaznov Date: 2021-07-13T18:47:29+03:00 New Revision: 03d8fed34951bc6e92b36615ec3afe6f36d10de6 URL: https://github.com/llvm/llvm-project/commit/03d8fed34951bc6e92b36615ec3afe6f36d10de6 DIFF: https://github.com/llvm/llvm-project/commit/03d8fed34951bc6e92b36615ec3afe6f36d10de6.diff

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03d8fed34951: [OpenCL] Add verbosity when checking support of read_write images (authored by azabaznov). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. typo in commit message. Some minor suggestions. LG Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1211 auto Remark = [&](OptimizationRemark OR) { -re

[clang] 10e0cdf - [PowerPC][NFC] Power ISA features for Semachecking

Author: Victor Huang Date: 2021-07-13T10:51:25-05:00 New Revision: 10e0cdfc6526578c8892d895c0448e77cb9ba876 URL: https://github.com/llvm/llvm-project/commit/10e0cdfc6526578c8892d895c0448e77cb9ba876 DIFF: https://github.com/llvm/llvm-project/commit/10e0cdfc6526578c8892d895c0448e77cb9ba876.diff

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10e0cdfc6526: [PowerPC][NFC] Power ISA features for Semachecking (authored by NeHuang). Changed prior to commit: https://reviews.llvm.org/D105501?

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2260-2261 + InterestingSymbols.erase(sym); + if (const auto *meta = dyn_cast(sym)) +markNotInteresting(meta->getRegion()); +} NoQ wrote: > You're saying, e.g., "If str

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

jhuber6 updated this revision to Diff 358287. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105898/new/ https://reviews.llvm.org/D105898 Files: clang/test/OpenMP/remarks_parallel_in_multiple_target_s

[clang] f1aca5a - [PowerPC] Fix L[D|W]ARX Implementation

Author: Albion Fung Date: 2021-07-13T11:02:07-05:00 New Revision: f1aca5ac96ebd0beadfa68a474c5947d3bc8c109 URL: https://github.com/llvm/llvm-project/commit/f1aca5ac96ebd0beadfa68a474c5947d3bc8c109 DIFF: https://github.com/llvm/llvm-project/commit/f1aca5ac96ebd0beadfa68a474c5947d3bc8c109.diff L

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

Anastasia added a subscriber: azabaznov. Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:329 #endif // defined(__opencl_c_atomic_scope_all_devices) -#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) +#if defined(cl_intel_subgroups) || de

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

jhuber6 updated this revision to Diff 358292. jhuber6 added a comment. Forgot to update two tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105898/new/ https://reviews.llvm.org/D105898 Files: clang/test/OpenMP/remarks_parallel_in_multiple_t

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

azabaznov added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:329 #endif // defined(__opencl_c_atomic_scope_all_devices) -#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) +#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) || defined(__ope

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

vsapsai added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1063 +<< ModuleName; +return ImportingInstance.getFrontendOpts().AllowPCMWithCompilerErrors; + } Can we get in infinite loop with `AllowPCMWithCompilerErrors = true`?

[PATCH] D105254: [RISCV] Support machine constraint "S"

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:27 + +; Function Attrs: nofree nosync nounwind readnone +define dso_local i8* @constraint_S_label() { Not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, kbarton, mgorny, nemanjai. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Xcode uses `#pragma mark

  1   2   3   >