hokein added a comment.
In D105478#2867120 <https://reviews.llvm.org/D105478#2867120>, @adamcz wrote:
> OK, I think we've got it now :-)
>
> I kept the original crash test in the change, but I'm not sure if it's
> appropriate anymore. Let me know if you think I should remove it.
Thanks, that sounds good to me, the original crash test is valuable, worth to
keep it.
================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2987
+ if (ThisDecl)
+ ThisDecl->setInvalidDecl();
SkipUntil(tok::comma, StopAtSemi | StopBeforeMatch);
----------------
it seems to me calling `Sema::ActOnInitializerError(ThisDecl)` is a better fit,
rather than invalidating the decl once the initializer is failed to parse, for
example `static const int Member = ;` we want to keep the decl valid.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105478/new/
https://reviews.llvm.org/D105478
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
