[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 357148. khchen added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. address jrtc27's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ ht

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng added inline comments. Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s MaskRay wrote: > MaskRay

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng updated this revision to Diff 357152. kito-cheng added a comment. Update testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 Files: clang/lib/Driver/ToolChains/RISCVToolchain.cpp clan

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

MyDeveloperDay added a comment. In D105479#2862819 , @aaron.ballman wrote: > Thank you for working on this! So I looked into do what you suggested originally, but it became a little more involved, partially because you have to look inside the Attrbuted

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

krasimir added a comment. In D103615#2858433 , @bmahjour wrote: > In D103615#2852430 , @krasimir > wrote: > >> I'm unfamiliar with the altivec API. What's a reasonable source code update >> that preserves the cu

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

vsavchenko added a comment. Good job, great to see how you are going through the whole list of methods! As for the patch, some tests and COMMENTS will be nice. Also, I think that for a checker that models quite a lot of functions and methods, we need to follow the pattern: if (isMethodA(...

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. FYI, I'm not actually asking for this to be merged, its just I'm happy to keep rebasing it from time to time for others to use, but to do that I have to keep pushing new reviews, but if the general opinion was to put it in then I'd go for that. I knew it was go

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

theraven added a comment. In D105142#2850247 , @anirudhp wrote: > In D105142#2849835 , @theraven > wrote: > >> The code looks fine but it would be good to see some docs along with it. >> We're currently missing

[PATCH] D105552: [analyzer][NFC] NoStoreFuncVisitor: Compact parameters for region pretty printing into a class

Szelethus added a comment. Actually, one thing might be worth considering. The grand idea is to split up `NoStoreFuncVisitor` so that its clients only need to define these 3 (quoting from D105553 ): > - What constitutes as a change to an entity > - What the dia

[PATCH] D33029: [clang-format] add option for dangling parenthesis

seesemichaelj added inline comments. Comment at: include/clang/Format/Format.h:793 + /// \endcode + bool DanglingParenthesis; + catskul wrote: > stringham wrote: > > djasper wrote: > > > stringham wrote: > > > > djasper wrote: > > > > > I don't think this is a

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 357183. pmatos added a comment. Herald added a subscriber: dexonsmith. Remove some extraneous code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/B

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. In D104797#2864102 , @pmatos wrote: > Remove some extraneous code Argh, sorry. This was meant for another revision and I added code that's not meant for this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 357189. pmatos added a comment. Revert code incorrectly submitted as part of diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/WebA

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

aaron.ballman added a comment. In D105479#2863819 , @MyDeveloperDay wrote: > In D105479#2862819 , @aaron.ballman > wrote: > >> Thank you for working on this! > > So I looked into do what you suggested originally

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2863312 , @steveire wrote: > In D69764#2863266 , @aaron.ballman > wrote: > >> In D69764#2863213 , @steveire wrote: >> >>> @MyDevelop

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

steakhal added a comment. AFAICT this patch does not introduce significant overhead to the exploded graph DOT dumps. Before the patch, an exploded graph took 12G and about 55 secs for a single top-level function. After the patch, it increased to 13G, and the runtime remained the same as expecte

[PATCH] D105490: Remove unused parameter from parseMSInlineAsm.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. This change is not part of my original D97204 patch (in D97204 , I replaced `void *AsmLoc` with `uint64_t AsmLoc`), so I thin

[PATCH] D105626: [RISCV][Clang] Add macro __riscv_zvlsseg for RVV Zvlsseg builtins

jacquesguan created this revision. jacquesguan added a reviewer: craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva02

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield added a comment. I think the openmp_wrappers are only used when compiling device code, which would explain why setting a macro in one of them is a proxy for detecting compilation for the device. Attempting to verify that, it looks like: trunk-nvptx includes openmp_wrappers on de

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

Szelethus updated this revision to Diff 357202. Szelethus edited the summary of this revision. Szelethus added a comment. - Don't depend on D105552 . - Merge with a followup patch; it was a poor splitting point, and the diffs didn't really convey what actually ch

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 357210. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cl

[clang] 727e1c9 - Support: add llvm::thread class that supports specifying stack size.

Author: Tim Northover Date: 2021-07-08T14:51:53+01:00 New Revision: 727e1c9be3a5b20c6b502f056d74a681689049d7 URL: https://github.com/llvm/llvm-project/commit/727e1c9be3a5b20c6b502f056d74a681689049d7 DIFF: https://github.com/llvm/llvm-project/commit/727e1c9be3a5b20c6b502f056d74a681689049d7.diff

[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size

t.p.northover closed this revision. t.p.northover added a comment. Thanks Duncan, committed as 727e1c9be3a5 Comment at: llvm/include/llvm/Support/thread.h:107 + + bool joinable() const noexcept { +retur

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

luismarques added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:1 +//===-- RISCVArchStringParser.h - RISCV Arch String Parser --*- C++ -*-===// +// Incorrect header name. Comment at: llvm/lib/Support/RISCVISAInfo.cp

[clang] 2bf5e8d - Revert "Support: add llvm::thread class that supports specifying stack size."

Author: Tim Northover Date: 2021-07-08T14:59:47+01:00 New Revision: 2bf5e8d953ededbc208bd4c116c9d6331d73f0f0 URL: https://github.com/llvm/llvm-project/commit/2bf5e8d953ededbc208bd4c116c9d6331d73f0f0 DIFF: https://github.com/llvm/llvm-project/commit/2bf5e8d953ededbc208bd4c116c9d6331d73f0f0.diff

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:41 +; CHECK: # %bb.0: +; CHECK-NEXT:td 5, 3, 4 +; CHECK-NEXT:blr NeHuang wrote: > seems the InstAlias defined for `td` and `tw` not workin

[PATCH] D105629: [TSan] Add SystemZ support

iii created this revision. iii added reviewers: kcc, dvyukov, uweigand. Herald added subscribers: jfb, hiraditya, mgorny. iii requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This patch series implem

[clang] 4e5d9c8 - [Internalize] Preserve variables externally initialized.

Author: Michael Liao Date: 2021-07-08T10:48:19-04:00 New Revision: 4e5d9c88033f1fc5d5206a02d8303bc6de43cf2b URL: https://github.com/llvm/llvm-project/commit/4e5d9c88033f1fc5d5206a02d8303bc6de43cf2b DIFF: https://github.com/llvm/llvm-project/commit/4e5d9c88033f1fc5d5206a02d8303bc6de43cf2b.diff

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e5d9c88033f: [Internalize] Preserve variables externally initialized. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105135/new/ https:

[PATCH] D105626: [RISCV][Clang] Add macro __riscv_zvlsseg for RVV Zvlsseg builtins

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105626/new/ https://reviews.llvm.org/D105626

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:195 if (MArch.startswith_insensitive("rv32")) { // FIXME: parse `March` to find `D` extension properly if (MArch.substr(4).contains_insensitive("d") || I think maybe

[PATCH] D103228: [PoC][RISCV] Using pragma to register vector intrinsic

kito-cheng planned changes to this revision. kito-cheng added a comment. Update: Send RFC[1] to cfe-dev list, and got useful feedback from OpenCL: - OpenCL's way is the fastest way to declare builtin, since it defer until symbol look-up, however that require re-implement vector intrinsic with t

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

sfertile created this revision. sfertile added reviewers: stevewan, Jake-Egan, daltenty. sfertile added a project: PowerPC. Herald added subscribers: shchenz, nemanjai. sfertile requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX when th

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

arphaman added a comment. Looks like this patch causes a number of issues for us, I will work with @jansvoboda11 to see if there's some way to resolve them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

MyDeveloperDay updated this revision to Diff 357229. MyDeveloperDay added a comment. Address the situation where we don't have braces after the `[[likely]]` on an if CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105479/new/ https://reviews.llvm.org/D105479 Files: clang-tools-extra/cl

[clang] 48c68a6 - Recommit: Support: add llvm::thread class that supports specifying stack size.

Author: Tim Northover Date: 2021-07-08T16:22:26+01:00 New Revision: 48c68a630e0101c16aa371f9202a4a53438b URL: https://github.com/llvm/llvm-project/commit/48c68a630e0101c16aa371f9202a4a53438b DIFF: https://github.com/llvm/llvm-project/commit/48c68a630e0101c16aa371f9202a4a53438b.diff

[clang-tools-extra] 48c68a6 - Recommit: Support: add llvm::thread class that supports specifying stack size.

Author: Tim Northover Date: 2021-07-08T16:22:26+01:00 New Revision: 48c68a630e0101c16aa371f9202a4a53438b URL: https://github.com/llvm/llvm-project/commit/48c68a630e0101c16aa371f9202a4a53438b DIFF: https://github.com/llvm/llvm-project/commit/48c68a630e0101c16aa371f9202a4a53438b.diff

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:195 if (MArch.startswith_insensitive("rv32")) { // FIXME: parse `March` to find `D` extension properly if (MArch.substr(4).contains_insensitive("d") || khchen wr

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of this revisio

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov updated this revision to Diff 357240. ASDenysPetrov added a comment. Added `SymExpr::ignoreCasts` method. Added descriptive comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 Files: clang/include/clang/StaticAnalyzer/Che

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske added a comment. Could not make a simple test for the change. This file F17831281: BugReportInterestingnessTest.cpp is what I could do, but it prints the needed text to the console. Is it possible to get the note texts in the program? Repository:

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

balazske added a comment. This change is accepted already. Is it good to commit? I would need the change for symbol "uninterestingness" in D104925 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https:

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske added reviewers: martong, NoQ. balazske added a comment. Herald added a subscriber: rnkovacs. The original change D104300 contained these modifications but is currently not committed. The "uninterestingness" is really a separate patch that belongs to a

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

jhuber6 added a comment. This revision causes a bug with generic regions. Firstprivate constants now aren't mapped properly into an internal parallel region and will just be zero. For example if I run this code I will see different values for the constants inside and outside the parallel region

[PATCH] D105446: DRAFT: [clang] fix constexpr code generation for user conversions.

mizvekov updated this revision to Diff 357260. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105446/new/ https://reviews.llvm.org/D105446 Files: clang/lib/AST/Expr.cpp clang/lib/Sema/SemaExprCXX.cpp clang/test/Cod

[clang] 769e782 - Fix MSVC "truncation from 'int' to 'bool'" warning. NFCI.

Author: Simon Pilgrim Date: 2021-07-08T18:08:24+01:00 New Revision: 769e782793391a1ee0d257c8b0c6f43a02321e22 URL: https://github.com/llvm/llvm-project/commit/769e782793391a1ee0d257c8b0c6f43a02321e22 DIFF: https://github.com/llvm/llvm-project/commit/769e782793391a1ee0d257c8b0c6f43a02321e22.diff

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

mizvekov added a comment. In D104500#2863368 , @jyknight wrote: > This commit seems to have broken libc++ in C++98 mode, as it appears to have > depended upon the implicit-move extension. > > The root cause appears to be that libc++ emulates unique_ptr i

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked 2 inline comments as done. Closed by commit rGa11aea68a4b3: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan… (authored by leo

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 357270. Conanap added a comment. Removed some incorrect patterns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1733 +// as XL produces a tweq , . +def : Pat<(int_ppc_tdw g8rc:$A, g8rc:$B, 31), + (TD 4, $A,

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp added a comment. In D105142#2862592 , @jyknight wrote: > This code doesn't handle multiple alternatives in a constraint. > > E.g. `"={eax}{ebx}"` or `"={eax}{ebx},m"`. > > See the GCC docs for the C-level syntax > https://gcc.gnu.org/onlinedocs/g

[PATCH] D105647: [OPENMP]Do no privatize const firstprivates in target regions.

ABataev created this revision. ABataev added reviewers: jdoerfert, jhuber6. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. No need to emit private copyfor firstprivate constants in target re

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

ABataev added a comment. In D105375#2864733 , @jhuber6 wrote: > This revision causes a bug with generic regions. Firstprivate constants now > aren't mapped properly into an internal parallel region and will just be > zero. For example if I run this code

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman created this revision. aaron.ballman added reviewers: ABataev, jdoerfert, erichkeane, bader, rsmith. Herald added subscribers: dexonsmith, zzheng, guansong, yaxunl. aaron.ballman requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Op

[clang] 5a1c504 - [clang] fix constexpr code generation for user conversions.

Author: Matheus Izvekov Date: 2021-07-08T20:23:19+02:00 New Revision: 5a1c50410ccc1973a1a0a4acca0c01677c28e9b6 URL: https://github.com/llvm/llvm-project/commit/5a1c50410ccc1973a1a0a4acca0c01677c28e9b6 DIFF: https://github.com/llvm/llvm-project/commit/5a1c50410ccc1973a1a0a4acca0c01677c28e9b6.dif

[PATCH] D105446: [clang] fix constexpr code generation for user conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1c50410ccc: [clang] fix constexpr code generation for user conversions. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105446/new/

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 357297. quinnp added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Work in progress addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/n

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2803-2808 + bool MaybeParseCXX11Attributes(ParsedAttributesWithRange &Attrs, + SourceLocation *EndLoc = nullptr, bool OuterMightBeMessa

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:869 PRAGMA_ANNOTATION(pragma_openmp) +PRAGMA_ANNOTATION(pragma_openmp_from_attr) PRAGMA_ANNOTATION(pragma_openmp_end) `pragma_openmp_from_attr`? Funny since it isn't a pragm

[PATCH] D105647: [OPENMP]Do no privatize const firstprivates in target regions.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM Fixed the problem, Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105647/new/ https://reviews.llvm.org/D105647 _

[clang] 693251f - [CodeGen] Avoid CreateGEP with nullptr type (NFC)

Author: Nikita Popov Date: 2021-07-08T20:38:54+02:00 New Revision: 693251fb2f001ac06591ae7d1254be265d36c9c7 URL: https://github.com/llvm/llvm-project/commit/693251fb2f001ac06591ae7d1254be265d36c9c7 DIFF: https://github.com/llvm/llvm-project/commit/693251fb2f001ac06591ae7d1254be265d36c9c7.diff

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357307. RedDocMD added a comment. Little refactors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp I

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD added a comment. I will be figuring out some tests tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 ___ cfe-commits mailing list cfe-c

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:869 PRAGMA_ANNOTATION(pragma_openmp) +PRAGMA_ANNOTATION(pragma_openmp_from_attr) PRAGMA_ANNOTATION(pragma_openmp_end) erich

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap marked an inline comment as done. Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1733 +// as XL produces a tweq , . +def : Pat<(int_ppc_tdw g8rc:$A, g8rc:$B, 31), + (TD 4, $A, $B)>; nemanjai wrote: > This is s

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:869 PRAGMA_ANNOTATION(pragma_openmp) +PRAGMA_ANNOTATION(pragma_openmp_from_attr) PRAGMA_ANNOTATION(pragma_openmp_end) aaron.ballman wrote: > erichkeane wrote: > > `pragma_ope

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

hokein updated this revision to Diff 357313. hokein marked an inline comment as done. hokein added a comment. refine the fix based on the discussion: https://bugs.llvm.org/show_bug.cgi?id=50797#c13 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1055

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Another place to make the same comment :D I wonder

[clang] f57d396 - [OPENMP]Do no privatize const firstprivates in target regions.

Author: Alexey Bataev Date: 2021-07-08T11:55:37-07:00 New Revision: f57d396dcab2a280faa72aff68623a8ccfdc5421 URL: https://github.com/llvm/llvm-project/commit/f57d396dcab2a280faa72aff68623a8ccfdc5421 DIFF: https://github.com/llvm/llvm-project/commit/f57d396dcab2a280faa72aff68623a8ccfdc5421.diff

[PATCH] D105647: [OPENMP]Do no privatize const firstprivates in target regions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf57d396dcab2: [OPENMP]Do no privatize const firstprivates in target regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES S

[clang] a0ea367 - [CodeGen] Avoid nullptr arg to CreateStructGEP (NFC)

Author: Nikita Popov Date: 2021-07-08T21:21:43+02:00 New Revision: a0ea3675629a1aecc60326e5439d811956b0f92a URL: https://github.com/llvm/llvm-project/commit/a0ea3675629a1aecc60326e5439d811956b0f92a DIFF: https://github.com/llvm/llvm-project/commit/a0ea3675629a1aecc60326e5439d811956b0f92a.diff

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } ABataev wrote: > erichkeane wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > Another place to make the

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357327. aaron.ballman marked 8 inline comments as done. aaron.ballman added a comment. Addressing review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 Files: clang/docs/OpenMPSupport.rst

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4473-4486 +void Parser::ParseCXX11Attributes(ParsedAttributesWithRange &Attrs, + SourceLocation *EndLoc) { assert(standardAttributesAllowed()); SourceLocatio

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } erichkeane wrote: > ABataev wrote: > > erichkeane wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > >

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

efriedma added a comment. I'm confused what your goal here is, exactly. The point of allowing 512-bit inline asm operands is presumably to allow writing efficient code involving inline asm... but you're intentionally destroying any potential efficiency by forcing it to be passed/returned in me

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added a comment. Looks good, in general, just pre-commit formatting changes. Comment at: clang/lib/Basic/Attributes.cpp:27 + if (LangOpts.OpenMP >= 51 && ScopeName == "omp") +return Name == "directive" || Name == "sequence"; + Better to return int

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 357334. Conanap added a comment. Removed TWNE pattern as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def cla

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } aaron.ballman wrote: > erichkeane wrote: > > ABataev wrote: > > > erichkeane wrote: > > > > aaron.ballman wrote: >

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. LGTM. @NeHuang please have a look to see if your comments are adequately addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357338. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Address review feedback, add a link to this review to the OpenMP status page for the feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ htt

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

NeHuang accepted this revision. NeHuang added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668

[clang] 1def257 - PR51018: Remove explicit conversions from SmallString to StringRef to future-proof against C++23

Author: David Blaikie Date: 2021-07-08T13:37:57-07:00 New Revision: 1def2579e10dd84405465f403e8c31acebff0c97 URL: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97 DIFF: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97.diff

[clang-tools-extra] 1def257 - PR51018: Remove explicit conversions from SmallString to StringRef to future-proof against C++23

Author: David Blaikie Date: 2021-07-08T13:37:57-07:00 New Revision: 1def2579e10dd84405465f403e8c31acebff0c97 URL: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97 DIFF: https://github.com/llvm/llvm-project/commit/1def2579e10dd84405465f403e8c31acebff0c97.diff

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA created this revision. ZarkoCA added reviewers: sfertile, cebowleratibm. ZarkoCA added a project: PowerPC. Herald added subscribers: shchenz, nemanjai. Herald added a reviewer: aaron.ballman. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } aaron.ballman wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > ABataev wrote: > > > > erichkeane wrote: > > >

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an *at

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an *a

[PATCH] D105611: [RISCV] Support overloading for RVV miscellaneous functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105611/new/ https://reviews.llvm.org/D105611 ___

[PATCH] D105666: [PowerPC] [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces that compare vector bool types with vector signed types

bmahjour created this revision. bmahjour added reviewers: nemanjai, cebowleratibm, PowerPC, rzurob. bmahjour added projects: PowerPC, LLVM. Herald added subscribers: shchenz, kbarton. bmahjour requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman accepted this revision. dgoldman added a comment. Thanks! Just to confirm, the non-simplified example is also fixed, right? struct a { int xxx; }; int g_107; int g_108; int g_109; struct a g_999; void b() { (g_910.xxx = g_910.xxx1); } Repository: rG LLVM Gi

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

Quuxplusone added a comment. In D104500#2864909 , @mizvekov wrote: > In D104500#2863368 , @jyknight > wrote: > >> This commit seems to have broken libc++ in C++98 mode, as it appears to have >> depended upon the

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an *

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:42 + // keep entries in canonical order of extension. + typedef std::map + OrderedExtensionMap; Could this be a sorted vector? Would require a good spot to sort it aft

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

mizvekov added a comment. In D104500#2865849 , @Quuxplusone wrote: > @mizvekov, I don't understand what you mean by "yet another" mechanism. This > is just asking to restore Clang's C++98/03 extension (that supports move > constructors even in C++03).

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

amyk added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3356 + case PPC::BI__builtin_ppc_maddld: +return SemaFeatureCheck(*this, TheCall, "power9-vector", +diag::err_ppc_builtin_only_on_pwr9); This is just a questi

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 357385. kda marked an inline comment as done. kda added a comment. - removed redundant mention of the flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files: clang

  1   2   >