ABataev added inline comments.
================
Comment at: clang/include/clang/Parse/Parser.h:2803-2808
+ bool MaybeParseCXX11Attributes(ParsedAttributesWithRange &Attrs,
+ SourceLocation *EndLoc = nullptr,
bool OuterMightBeMessageSend = false) {
if (standardAttributesAllowed() &&
isCXX11AttributeSpecifier(false, OuterMightBeMessageSend)) {
+ ParseCXX11Attributes(Attrs, EndLoc);
----------------
I think better to commit this as NFC in a separate patch.
================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4173-4174
+ T.consumeClose();
+ } else if (AttrName->isStr("sequence")) {
+ // If the attribute is named 'sequence', its argument is a list of one or
+ // more OpenMP attributes (either 'omp::directive' or 'omp::sequence',
----------------
```
else {
assert(AttrName->isStr("sequence"));
```
? Or we can expect something else here?
================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4177-4181
+ BalancedDelimiterTracker T(*this, tok::l_paren);
+ if (T.consumeOpen()) {
+ Diag(Tok, diag::err_expected) << tok::l_paren;
+ return;
+ }
----------------
Common code between then and else.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105648/new/
https://reviews.llvm.org/D105648
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
