jdoerfert added inline comments.
================ Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an *attribute* rather than a pragma. Handle it now. + if (Tok.is(tok::annot_pragma_openmp_from_attr)) + return ParseOpenMPDeclarativeDirectiveWithExtDecl(AS, attrs); + ---------------- cor3ntin wrote: > The comment raises 2 questions: should it be called `annot_openmp_attr` > instead? Does the comment describe what this does? > I imagine long terms attributes might be the ""normal"" scenario? > I imagine long terms attributes might be the ""normal"" scenario? We can't assume that (C) and for C++ only time will tell. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
