kito-cheng added inline comments.
================ Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s ---------------- MaskRay wrote: > MaskRay wrote: > > Just place all linker options on one run line. > > > > It decreases the number of RUN lines and additionally checks the order > > (though usually unimportant). > The test hasn't been updated? Oh, I only update the testcase I added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
