[PATCH] D95128: [clang-format] [NFC] Remove unused arguments

HazardyKnusperkeks added a comment. I did add the commit here, but I can give you the hash explicitly: 9aa38a0615119a7a9f3bee33a2b8915c45f1cab9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. Great work! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246

[clang] 4ad41f1 - Revert "[clang-format] Add option to control the spaces in a line comment"

Author: Björn Schäpers Date: 2021-01-29T09:30:52+01:00 New Revision: 4ad41f1daf0fa98a2c23fdf57390df0948164a2f URL: https://github.com/llvm/llvm-project/commit/4ad41f1daf0fa98a2c23fdf57390df0948164a2f DIFF: https://github.com/llvm/llvm-project/commit/4ad41f1daf0fa98a2c23fdf57390df0948164a2f.diff

[PATCH] D95128: [clang-format] [NFC] Remove unused arguments

curdeius added a comment. Thanks. I haven't seen you had added it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95128/new/ https://reviews.llvm.org/D95128 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm (with test nit) Comment at: clang/test/Driver/cl-sysroot.cpp:10 + +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/include" +// CHECK: "-internal-isystem"

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

jansvoboda11 added a comment. Left a question in-line. Comment at: clang/test/Modules/implicit-modules-use-lock.m:21 + +// CHECK-NO-LOCKS-NOT: remark: +// CHECK-LOCKS: remark: locking '{{.*}}.pcm' to build module 'X' [-Rmodule-lock] Where is the empty remark c

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko updated this revision to Diff 320068. vsavchenko added a comment. Herald added a subscriber: jdoerfert. Fix failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/ https://reviews.llvm.org/D93110 Files: clang/include/cl

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Closing this in favor of D95629 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95514/new/ https://reviews.llvm.org/D95514 ___

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

mgorny added a comment. In D95653#2529776 , @njames93 wrote: > I think I introduced this failure due to my abysmal knowledge of CMake and > LLVM's library structure, So I'm definitely not qualified to say if this is a > good fix, but seeing as it fixes t

[PATCH] D95629: [clang][analyzer] Own string keys in AnalyzerOptions::ConfigTable

jansvoboda11 added a comment. In D95629#2528931 , @dexonsmith wrote: > I think this patch can be skipped. `StringMap` owns its own strings. > `StringMapEntry` uses tail allocation to include a null-terminated string > inline. For details, have a look at

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2396 + let Args = [VariadicStringArgument<"DiagnosticIdentifiers">]; + let Subjects = SubjectList<[Var]>; + let Documentation = [AnalyzerSuppressDocs]; NoQ wrote: > [evil mode] > W

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:3141-3147 "# commen3\n" "# commen4\n" "a: 1 # commen5\n" " # commen6\n" " # commen7", format(

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer added a comment. Sorry one last question: how about `-mno-outline-atomics` in combination with this? Think we need to add a test for that too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 _

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugSuppression.h:30-31 +public: + /// Return true if the given bug report was explicitly suppressed by the user. + bool isSuppressed(const BugReport &); + /// Return true if the bug re

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

sammccall added a comment. Since the 12 branch has been cut, I've added a blocking bug to get this fixed in some form: https://bugs.llvm.org/show_bug.cgi?id=48935 @rsmith I've assigned it to you to make a call about whether to cherrypick this patch, this patch+followup, or revert the original c

[clang-tools-extra] d47ee52 - [clang-tooling] Prevent llvm::fatal_error on invalid CLI option

Author: serge-sans-paille Date: 2021-01-29T10:15:06+01:00 New Revision: d47ee525f9e9289815db0864b03e866fc8e5ba01 URL: https://github.com/llvm/llvm-project/commit/d47ee525f9e9289815db0864b03e866fc8e5ba01 DIFF: https://github.com/llvm/llvm-project/commit/d47ee525f9e9289815db0864b03e866fc8e5ba01.d

[PATCH] D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd47ee525f9e9: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

lebedev.ri added a comment. Can you please add an explanation to the patch's description as to why we don't want to instead convert non-relative/relative LUT's elsewhere, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94355/new/ https://revi

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugSuppression.cpp:70 + +class CacheInitializer : public RecursiveASTVisitor { +public: NoQ wrote: > vsavchenko wrote: > > NoQ wrote: > > > A recursive visitor would cause you to visit ne

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:5512-5525 + // If not in x86 or aarch64 mode, do not generate a relative lookup table. + Triple TargetTriple(M.getTargetTriple()); + if (!(TargetTriple.getArch() == Triple::x86_64 || +

[PATCH] D95658: Make the profile-filter.c test compatible with 32-bit systems

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I can confirm that the tests pass for me with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95658/new/ https://reviews.llvm.org/D956

[PATCH] D94396: Fix macos target assumption in test

thopre added reviewers: hans, jyknight, steven_wu. thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94396/new/ https://reviews.llvm.org/D94396 ___ cfe-commits mailing list cfe-

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

t.p.northover added a comment. I think this looks good now, modulo Sjoerd's last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 ___ cfe-commits mailing

[PATCH] D95673: [dllimport] Honor always_inline when deciding whether a dllimport function should be available for inlining (PR48925)

hans created this revision. hans added a reviewer: rnk. hans requested review of this revision. Herald added a project: clang. Normally, Clang will not make dllimport functions available for inlining if they reference non-imported symbols, as this can lead to confusing link errors. But if the fu

[clang] 305ac81 - Fix macos target assumption in test

Author: Thomas Preud'homme Date: 2021-01-29T10:22:04Z New Revision: 305ac81e1d4bbd037587190175e4d0b5631300e1 URL: https://github.com/llvm/llvm-project/commit/305ac81e1d4bbd037587190175e4d0b5631300e1 DIFF: https://github.com/llvm/llvm-project/commit/305ac81e1d4bbd037587190175e4d0b5631300e1.diff

[PATCH] D94396: Fix macos target assumption in test

This revision was automatically updated to reflect the committed changes. Closed by commit rG305ac81e1d4b: Fix macos target assumption in test (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94396/new/ https://reviews.llvm.org/D9

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko updated this revision to Diff 320092. vsavchenko added a comment. Add check for extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/ https://reviews.llvm.org/D93630 Files: clang/include/clang/Basic/Features.def clang/l

[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks, LGTM with a couple of nits. Comment at: clang-tools-extra/clangd/XRefs.h:23 #include "clang/AST/Type.h" +#include "clang/Basic/BitmaskEnum.h" #include "clang/Fo

[clang] 42a2177 - [test] Use host platform specific error message substitution in lit tests

Author: Abhina Sreeskantharajan Date: 2021-01-29T07:16:30-05:00 New Revision: 42a21778f61cdc8462ce2cfb6ad7bc1992b2063c URL: https://github.com/llvm/llvm-project/commit/42a21778f61cdc8462ce2cfb6ad7bc1992b2063c DIFF: https://github.com/llvm/llvm-project/commit/42a21778f61cdc8462ce2cfb6ad7bc1992b2

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42a21778f61c: [test] Use host platform specific error message substitution in lit tests (authored by abhina.sreeskantharajan). Repository: rG LLVM

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); rsmit

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski added a comment. @FarisRehman, thank you for addressing my comments! I've just realised that `gfortran` doesn't actually support `-fno-fixed-form` or `-fno-free-form`: $ gfortran -ffixed-form -fno-fixed-form test.f gfortran: error: unrecognized command line option ‘-fno-fixed-form

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95653/new/ https://reviews.llvm.org/D95653 ___ cfe-commits mailing list c

[PATCH] D95526: [Syntax] Add syntax-tree-dump in clang-check.

hokein updated this revision to Diff 320112. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95526/new/ https://reviews.llvm.org/D95526 Files: clang/test/Tooling/cla

[clang] e90e455 - [Syntax] Add syntax-tree-dump in clang-check.

Author: Haojian Wu Date: 2021-01-29T14:10:27+01:00 New Revision: e90e455d2a0cc6e04b930a43355c3551e2c6f0e0 URL: https://github.com/llvm/llvm-project/commit/e90e455d2a0cc6e04b930a43355c3551e2c6f0e0 DIFF: https://github.com/llvm/llvm-project/commit/e90e455d2a0cc6e04b930a43355c3551e2c6f0e0.diff LO

[PATCH] D95526: [Syntax] Add syntax-tree-dump in clang-check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe90e455d2a0c: [Syntax] Add syntax-tree-dump in clang-check. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95655: Adding Neon Sm3 & Sm4 Intrinsics

labrinea added inline comments. Comment at: llvm/test/CodeGen/AArch64/neon-sm4-sm3.ll:24 + +define <4 x i32> @test_vsm3ss1(<4 x i32> %a, <4 x i32> %b, <4 x i32> %c, <4 x i32> %d) { +; CHECK-LABEL: test_vsm3ss1: The forth argument (<4 x i32> %d) is redundant. =

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 320115. jansvoboda11 added a comment. Improve error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

curdeius added a comment. I don't think it can go into 12.x. But if you have a good reason and a related bug report you might add this bug ticket as a release blocker of https://llvm.org/PR48902. BTW, would you mind updating clang/docs/ReleaseNotes.rst? Repository: rG LLVM Github Monorepo

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:584-589 +static bool Equal(const ArgStringList &A, const ArgStringList &B) { + auto StrEq = [](const char *AElem, const char *BElem) { +return StringRef(AElem) == StringRef(BElem); + }

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

jansvoboda11 updated this revision to Diff 320118. jansvoboda11 added a comment. Rebase, inline lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95369/new/ https://reviews.llvm.org/D95369 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822 + static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args, DiagnosticsEngine &Diags) { dexonsmith wrote: > Can you rename this

[clang-tools-extra] d0817b5 - [clangd] Extract symbol-scope logic out of Quality, add tests. NFC

Author: Sam McCall Date: 2021-01-29T14:44:28+01:00 New Revision: d0817b5f18c7bb435012d214f293d4a7839e492e URL: https://github.com/llvm/llvm-project/commit/d0817b5f18c7bb435012d214f293d4a7839e492e DIFF: https://github.com/llvm/llvm-project/commit/d0817b5f18c7bb435012d214f293d4a7839e492e.diff LO

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3093 + +static bool ParsePreprocessorArgs(PreprocessorOptions &Opts, ArgList &Args, DiagnosticsEngine &Diags, dexonsmith wrote: > Can we n

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

jansvoboda11 updated this revision to Diff 320119. jansvoboda11 edited the summary of this revision. jansvoboda11 added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95366/new/ https://reviews.llvm.org/D95366 Files: cl

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

njames93 added a comment. In D95653#2530163 , @mgorny wrote: > In D95653#2529776 , @njames93 wrote: > >> I think I introduced this failure due to my abysmal In D95653#2530163

[clang-tools-extra] 7d1b499 - Revert "[clangd] Extract symbol-scope logic out of Quality, add tests. NFC"

Author: Sam McCall Date: 2021-01-29T14:59:16+01:00 New Revision: 7d1b499caef6ebde09a2697a97b43b89f7fa35c8 URL: https://github.com/llvm/llvm-project/commit/7d1b499caef6ebde09a2697a97b43b89f7fa35c8 DIFF: https://github.com/llvm/llvm-project/commit/7d1b499caef6ebde09a2697a97b43b89f7fa35c8.diff LO

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 320123. ilinpv added a comment. Tests for "-m[no]outline-atomics" options added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/Tool

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, evandro. Herald added subscribers: vkmr, NickHung, jdoerfert, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edwar

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. \o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95680/new/ https://reviews.llvm.org/D95680 ___ cf

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM too. One nit inlined that can be addressed before committing. Comment at: clang/test/Driver/aarch64-features.c:47 +// CHECK-OUTLINE-ATOMICS-ON: "-ta

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added inline comments. Comment at: clang/test/Driver/cl-sysroot.cpp:10 + +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/include" +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/atlmfc/include" hans wrote: > could the

[clang] 8284743 - clang-cl: Invent a /winsysroot concept

Author: Nico Weber Date: 2021-01-29T09:47:00-05:00 New Revision: 82847436e9258a12503dcfadb5dc373cb42fea43 URL: https://github.com/llvm/llvm-project/commit/82847436e9258a12503dcfadb5dc373cb42fea43 DIFF: https://github.com/llvm/llvm-project/commit/82847436e9258a12503dcfadb5dc373cb42fea43.diff LO

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

This revision was automatically updated to reflect the committed changes. Closed by commit rG82847436e925: clang-cl: Invent a /winsysroot concept (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95534?vs=319949&id=320126#toc Repository:

[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

erichkeane added a comment. Can you show any tests where this builtin would be a part of the aux-triple, and not in active code? So an nvptx triple, x86_64 aux-triple, and in non-device code? (such as in a CUDA app)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] d087d80 - clang-cl: Accept /std:c11, /std:c17 flags

Author: Nico Weber Date: 2021-01-29T09:59:00-05:00 New Revision: d087d805acb664e885e9c31a916f6cfa5dbc2186 URL: https://github.com/llvm/llvm-project/commit/d087d805acb664e885e9c31a916f6cfa5dbc2186 DIFF: https://github.com/llvm/llvm-project/commit/d087d805acb664e885e9c31a916f6cfa5dbc2186.diff LO

[PATCH] D95575: clang-cl: Accept /std:c11, /std:c17 flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGd087d805acb6: clang-cl: Accept /std:c11, /std:c17 flags (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

yaxunl added a comment. LGTM for amdgpu changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:684-685 + if (!GeneratedStringsEqual) +llvm::report_fatal_error("Mismatch between arguments generated during " + "round-trip"); + jansvoboda11

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

dexonsmith added inline comments. Comment at: clang/test/Modules/implicit-modules-use-lock.m:21 + +// CHECK-NO-LOCKS-NOT: remark: +// CHECK-LOCKS: remark: locking '{{.*}}.pcm' to build module 'X' [-Rmodule-lock] jansvoboda11 wrote: > Where is the empty remark co

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. This breaks us too: https://bugs.chromium.org/p/chromium/issues/detail?id=1172291 Given that this breaks at least 3 distinct build configs, let's revert this for now until we've figured out a path forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

asb accepted this revision. asb added a comment. LGTM modulo one additional request: please update the comment at the top of RISCVInstrInfoV.td to say "0.10" rather than "0.9". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95680/new/ https://revie

[PATCH] D95680: [RISCV] Update the version number to v0.10 for vector.

frasercrmck accepted this revision. frasercrmck added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95680/new/ https://reviews.llvm.org/D95680 ___ cfe-commits mailing list cfe-commits@lis

[clang] 1608ba0 - Revert "Disable rosegment for old Android versions."

Author: Nico Weber Date: 2021-01-29T11:20:48-05:00 New Revision: 1608ba09462d877111230e9461b895f696f8fcb1 URL: https://github.com/llvm/llvm-project/commit/1608ba09462d877111230e9461b895f696f8fcb1 DIFF: https://github.com/llvm/llvm-project/commit/1608ba09462d877111230e9461b895f696f8fcb1.diff LO

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 320142. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChai

[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

yaxunl added a comment. I tried this patch with our CI and it breaks HIP and OpenMP. I suspect it may also break CUDA. It seems in device compilation, when a host function calls a builtin with long double argument, the builtin is not found. My guess is that the target for checking builtin needs

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 . Someone should file a PR to make sure that gets merged to the 12.0 branch. We can then reland on trunk once there are clear instructions for f

[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

erichkeane added a comment. For target-specific builtins I ended up implementing this: https://github.com/llvm/llvm-project/commit/81a73fde5cea304d31294fd26c2f051f1685e97c at one point to make sure that 'host' builtins get looked up in the aux-target if necessary. Repository: rG LLVM Github

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. Alternatively, there's `LinkerIsLLD` in the driver code, maybe the driver wants to check that in some way (if only to emit a better diag if it's false, I guess) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95166/new/ https

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

FarisRehman updated this revision to Diff 320145. FarisRehman added a comment. Remove -fno-fixed-form and -fno-free-form Remove options `-fno-fixed-form` and `-fno-free-form` allowing for help messages to be added to `-ffixed-form` and `-ffree-form`. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822 + static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args, DiagnosticsEngine &Diags) { jansvoboda11 wrote: > dexonsmith wrote: >

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

tskeith added inline comments. Comment at: clang/include/clang/Driver/Options.td:4133 def fconvert_EQ : Joined<["-"], "fconvert=">, Group; -def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">, Group; +def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-len

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e7e649d537: [AArch64][Clang][Linux] Enable out-of-line atomics by default. (authored by ilinpv). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] c5e7e64 - [AArch64][Clang][Linux] Enable out-of-line atomics by default.

Author: Pavel Iliin Date: 2021-01-29T17:44:45Z New Revision: c5e7e649d537067dec7111f3de1430d0fc8a4d11 URL: https://github.com/llvm/llvm-project/commit/c5e7e649d537067dec7111f3de1430d0fc8a4d11 DIFF: https://github.com/llvm/llvm-project/commit/c5e7e649d537067dec7111f3de1430d0fc8a4d11.diff LOG: [

[clang] 0217f1c - Make the profile-filter.c test compatible with 32-bit systems

Author: Petr Hosek Date: 2021-01-29T09:58:32-08:00 New Revision: 0217f1c7a31ba44715bc083a60cddc2192ffed96 URL: https://github.com/llvm/llvm-project/commit/0217f1c7a31ba44715bc083a60cddc2192ffed96 DIFF: https://github.com/llvm/llvm-project/commit/0217f1c7a31ba44715bc083a60cddc2192ffed96.diff LO

[PATCH] D95658: Make the profile-filter.c test compatible with 32-bit systems

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0217f1c7a31b: Make the profile-filter.c test compatible with 32-bit systems (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

MaskRay added inline comments. Comment at: clang/test/Driver/rocm-device-libs.cl:82 // RUN: %s \ -// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,COMMON-UNSAFE,GFX803,WAVE64 %s +// RUN: 2>&1 | FileCheck --check-prefixes=COMMON,GFX803,WAVE64 %s Since you

[clang] caaaebc - [AIX] Actually push back "-mabi=vec-extabi" when option is on.

Author: Zarko Todorovski Date: 2021-01-29T14:12:46-05:00 New Revision: caaaebcde462bf681498ce85c2659d683a07fc87 URL: https://github.com/llvm/llvm-project/commit/caaaebcde462bf681498ce85c2659d683a07fc87 DIFF: https://github.com/llvm/llvm-project/commit/caaaebcde462bf681498ce85c2659d683a07fc87.di

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

dyung added a comment. PS4 changes lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. https://bugs.llvm.org/show_bug.cgi?id=48668 already exists as a bug report linked to this review. I'm not sure "the Zeek project would like to start using this" is a good enough reason to block an LLVM release though. I'm fairly certain there aren't a whole lot of people

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, jyknight. aaron.ballman requested review of this revision. https://wg21.link/P2173 is making its way through WG21 currently and has not been formally adopted yet. This feature provides very useful functionality

[Diffusion] rGcaaaebcde462: [AIX] Actually push back "-mabi=vec-extabi" when option is on.

hubert.reinterpretcast added subscribers: ZarkoCA, hubert.reinterpretcast, cfe-commits. BRANCHES main Users: ZarkoCA (Author) https://reviews.llvm.org/rGcaaaebcde462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0703b0753c40: [CMake] Actually require python 3.6 or greater (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 0703b07 - [CMake] Actually require python 3.6 or greater

Author: Christopher Tetreault Date: 2021-01-29T11:47:21-08:00 New Revision: 0703b0753c40dad30f1683403f6600bd2cb42055 URL: https://github.com/llvm/llvm-project/commit/0703b0753c40dad30f1683403f6600bd2cb42055 DIFF: https://github.com/llvm/llvm-project/commit/0703b0753c40dad30f1683403f6600bd2cb420

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320184. arnamoy10 added a comment. Addressing reviewers' comments with the following changes: 1. Aliasing of -module-dir and -J to avoid code duplication 2. Moving the code to set the module and search directories from `FrontendActions.cpp` to `CompilerInv

[Diffusion] rGcaaaebcde462: [AIX] Actually push back "-mabi=vec-extabi" when option is on.

hubert.reinterpretcast added inline comments. BRANCHES main /clang/lib/Driver/ToolChains/Clang.cpp:4672-4678 This seems to be saying that `-maltivec` rather actively implies `-mabi=vec-default` (on AIX) even in cases where `-maltivec` really makes no difference. I suggest just removing this.

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320188. arnamoy10 added a comment. Added test for the driver-help, also contains all the changes that was done in the previous diff (Aliasing `-J` and `-module-dir`, changing data structures etc). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D954

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere reopened this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D95635#2529027 , @ctetreau wrote: > In D95635#2528851 , @JDevlieghere > wrote: > >>> However, t

[PATCH] D95694: [clang][RelativeVTablesABI] Place non-local vtables in comdat groups

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: clang. Herald added a subscriber: pengfei. leonardchan requested review of this revision. Currently, it's possible for vtables that fit precisely in a mergable constants group to not be

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. @JDevlieghere I personally have no skin in this game. This is actually quite an obnoxious development for me since my linux machine is stuck on an old version and Python 3.5 is the newest version in the repos. I sent a message to llvm-dev so hopefully this will get has

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2530791 , @thakis wrote: > Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 > . > Someone should file a PR to make sure that gets merged to

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

MaskRay added a comment. https://lists.llvm.org/pipermail/llvm-dev/2021-January/148229.html "Python version requirement" for the version discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

fcloutier created this revision. fcloutier added reviewers: jkorous, dcoughlin. fcloutier added a project: clang. Herald added a subscriber: Charusso. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. Since it gained a new

[clang-tools-extra] 632545e - [clang-tidy] Fix linking tests to LLVMTestingSupport

Author: Michał Górny Date: 2021-01-29T21:54:09+01:00 New Revision: 632545e8ce846ccaeca8df15a3dc5e36d01a1275 URL: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275 DIFF: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275.diff

[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport

This revision was automatically updated to reflect the committed changes. Closed by commit rG632545e8ce84: [clang-tidy] Fix linking tests to LLVMTestingSupport (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks updated this revision to Diff 320196. HazardyKnusperkeks added a comment. The previous one broke a (format) test in polly. This lead me to change the one breaking behavior, no it is not breaking anymore. A comment starting with `}` will only be indented if it is in a comment se

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic marked 2 inline comments as done. rsanthir.quic added a comment. Thank you for taking a look at this @labrinea ! Comment at: llvm/test/CodeGen/AArch64/neon-sm4-sm3.ll:77 +; CHECK: // %bb.0: // %entry +; CHECK-NEXT:sm4e v1.4s, v0.4s +; CHECK-NEXT:mov

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic updated this revision to Diff 320199. rsanthir.quic marked an inline comment as done. rsanthir.quic added a comment. Corrected register ordering for sm4e and removed redundant argument in sm3ss1 test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

fcloutier updated this revision to Diff 320204. fcloutier added a comment. Updating the diff using arcanist, which I'm told produces better results. Sorry for the churn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95695/new/ https://reviews.llvm

  1   2   >