hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
lgtm (with test nit) ================ Comment at: clang/test/Driver/cl-sysroot.cpp:10 + +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/include" +// CHECK: "-internal-isystem" "[[ROOT]]/VC/Tools/MSVC/14.26.28801/atlmfc/include" ---------------- could the slashes be backslashes when this test runs on a windows machine? ================ Comment at: clang/test/Driver/cl-sysroot.cpp:4 + +// RUN: %clang_cl /winsysroot %t /c -- %t/foo.cpp +// RUN: %clang_cl /vctoolsdir %t/VC/Tools/MSVC/14.26.28801 \ ---------------- thakis wrote: > hans wrote: > > Driver/ tests don't usually run the actual compiler. Any reason not to just > > check the -### output? > I had that at first, but it felt a bit brittle to me. But sure, moved back to > that. Thanks! Running the compiler here could be brittle too, since it will run for all backends, and some could get confused by seeing windows as part of the target triple. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D95534 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
