[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We cannot be sure whether a flag is CC1

[PATCH] D92969: [AST] Fix a constexpr-evaluator crash on error-dependent returnstmt.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:5147 + EvaluateDependentExpr(RetExpr, Info); + return ESR_Failed; +} this deserves a comme

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

kaz7 added a comment. Thank you for additional suggestions. I'll make next patch like "optimize ve-toolchain.c and .cpp." Thank you so much! Comment at: clang/test/Driver/ve-toolchain.cpp:72 // RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFINITARRAY

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

LuoYuanke updated this revision to Diff 310786. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92837/new/ https://reviews.llvm.org/D92837 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[clang] a053929 - [AST] Fix a constexpr-evaluator crash on error-dependent returnstmt.

Author: Haojian Wu Date: 2020-12-10T10:12:15+01:00 New Revision: a0539298540e49cb734c7b82f93572ab46bf9b00 URL: https://github.com/llvm/llvm-project/commit/a0539298540e49cb734c7b82f93572ab46bf9b00 DIFF: https://github.com/llvm/llvm-project/commit/a0539298540e49cb734c7b82f93572ab46bf9b00.diff LO

[PATCH] D92969: [AST] Fix a constexpr-evaluator crash on error-dependent returnstmt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGa0539298540e: [AST] Fix a constexpr-evaluator crash on error-dependent returnstmt. (authored by hokein). Ch

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 updated this revision to Diff 310792. jansvoboda11 added a comment. Fix comment typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93008/new/ https://reviews.llvm.org/D93008 Files: clang/include/clang/Driver/Options.td clang/lib/F

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn updated this revision to Diff 310799. fhahn added a comment. Loop over rotation variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92930/new/ https://reviews.llvm.org/D92930 Files: clang/include/clang/Basic/arm_neon.td clang/lib/Cod

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 310800. LuoYuanke added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c llvm/include/llvm-c/Core.h ll

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

sameeranjoshi added a comment. Thanks for patch, a few queries below. Are the tests in clang which are related to flang failing at https://reviews.llvm.org/B81474? Comment at: flang/include/flang/Frontend/FrontendActions.h:29 +class SyntaxOnlyAction : public FrontendAction

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

fhahn created this revision. fhahn added reviewers: SjoerdMeijer, dmgreen, t.p.northover. Herald added subscribers: danielkiss, kristof.beyls. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the LANE variants for VCMLA

[PATCH] D93017: [AMDGPU] Add missing targets to amdgpu-features.cl

t-tye created this revision. t-tye added a reviewer: kzhuravl. Herald added subscribers: kerbowa, tpr, dstuttard, yaxunl, nhaehnle, jvesely. t-tye requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo h

[PATCH] D93018: [AMDGPU] Add missing targets to target-invalid-cpu-note.c

t-tye created this revision. t-tye added a reviewer: kzhuravl. Herald added subscribers: tpr, dstuttard, yaxunl. t-tye requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D930

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 ___ cfe-commit

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 310814. njames93 added a comment. Fix lit test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files: clang-tools-extra/clangd/ConfigYAML.cpp clang-tools-e

[clang] 254677e - [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text

Author: mydeveloperday Date: 2020-12-10T11:06:48Z New Revision: 254677e9ed4e705c1138166dc8053edad8ee7ed3 URL: https://github.com/llvm/llvm-project/commit/254677e9ed4e705c1138166dc8053edad8ee7ed3 DIFF: https://github.com/llvm/llvm-project/commit/254677e9ed4e705c1138166dc8053edad8ee7ed3.diff LOG

[PATCH] D92822: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG254677e9ed4e: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text (authored by MyDeveloperDay). Repository: rG LLVM Git

[clang] 7b2d62f - [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess

Author: mydeveloperday Date: 2020-12-10T11:13:22Z New Revision: 7b2d62fd7f7befda2ce327d25075b0aac9bc6780 URL: https://github.com/llvm/llvm-project/commit/7b2d62fd7f7befda2ce327d25075b0aac9bc6780 DIFF: https://github.com/llvm/llvm-project/commit/7b2d62fd7f7befda2ce327d25075b0aac9bc6780.diff LOG

[PATCH] D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b2d62fd7f7b: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rGe9e6e3b34a8e: [clang-format] Add IndentPragma style to eliminate common clang-format off… (authored by MyDeveloperDay). Repository: rG LLVM Github Monore

[clang] e9e6e3b - [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

Author: mydeveloperday Date: 2020-12-10T11:17:33Z New Revision: e9e6e3b34a8e0857a274df51aac27e88c1de402b URL: https://github.com/llvm/llvm-project/commit/e9e6e3b34a8e0857a274df51aac27e88c1de402b DIFF: https://github.com/llvm/llvm-project/commit/e9e6e3b34a8e0857a274df51aac27e88c1de402b.diff LOG

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] 95616a0 - [clang-format] NFC Add release note for IndentPragmas

Author: mydeveloperday Date: 2020-12-10T11:24:12Z New Revision: 95616a033c16146b55352c5fb93af82e00422920 URL: https://github.com/llvm/llvm-project/commit/95616a033c16146b55352c5fb93af82e00422920 DIFF: https://github.com/llvm/llvm-project/commit/95616a033c16146b55352c5fb93af82e00422920.diff LOG

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 added a comment. Adding in support for fix-its(at least in vscode) didn't seem to work. The language server there doesn't seem to send the `textDocument/codeAction` message to the server for the `.clangd` file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang-tools-extra] bedf3a0 - [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

Author: Nathan James Date: 2020-12-10T11:34:57Z New Revision: bedf3a0f507113bb09acaa317c533d85fe52518a URL: https://github.com/llvm/llvm-project/commit/bedf3a0f507113bb09acaa317c533d85fe52518a DIFF: https://github.com/llvm/llvm-project/commit/bedf3a0f507113bb09acaa317c533d85fe52518a.diff LOG:

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbedf3a0f5071: [clang-tidy][NFC] Use moves instead of copies when constructing… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

rengolin accepted this revision. rengolin added a comment. LGTM too, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM created this revision. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. MarkMurrayARM requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch upstreams support for the Arm-v8 Cortex-A78C pro

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh created this revision. abidh added a reviewer: MaskRay. abidh added a project: clang. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2444399 , @MaskRay wrote: > This change has been failing on my machine for the past two weeks. > > `riscv32-toolchain-extra.c` and `riscv64-toolchain-extra.c` are not hermit. I > have installed `/usr/lib/gcc-cross/riscv64-

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

DavidSpickett added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:833 +} + } pass &= AArch64::getCPUAttr(AK).equals(CPUAttr); I assume this was left in from debugging, if not it should be its own change. (considering this file i

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

ktkachov added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686 +def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily", +"CortexA78C", +"Cortex-A78C ARM processors", [ +

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

miyuki added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:47 +if (!pass) + std::cout << "ExpectedFlags = 0x" << std::hex << ExpectedFlags +<< " do not equal ExtKind = 0x" << std::hex << ExtKind I suggest using LLVM I/O

[PATCH] D92986: [clangd][NFC] Remove unnecessary vector.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Ah, I see now, thanks for the follow-up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92986/new/ https://reviews.llvm.org/D92986 _

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190 const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) { - llvm::SmallVector Components; + llvm::SmallVector Components; QName.split(Components, "::"); k

[clang-tools-extra] ee02e20 - [clangd] NFC: Use SmallVector where possible

Author: Kirill Bobyrev Date: 2020-12-10T13:36:49+01:00 New Revision: ee02e20c0817745c47ea9be8e26e9a49afc9a7fd URL: https://github.com/llvm/llvm-project/commit/ee02e20c0817745c47ea9be8e26e9a49afc9a7fd DIFF: https://github.com/llvm/llvm-project/commit/ee02e20c0817745c47ea9be8e26e9a49afc9a7fd.diff

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee02e20c0817: [clangd] NFC: Use SmallVector where possible (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri commandeered this revision. lebedev.ri edited reviewers, added: nikic; removed: lebedev.ri. lebedev.ri added a comment. @mstorsjo please can you be more specific what kind of tests are starting to fail? Do those tests just check that the code compiled into an identical assembly? I red

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190 const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) { - llvm::SmallVector Components; + llvm::SmallVector Components; QName.split(Components, "::"); k

[PATCH] D93024: [clang-tidy] Use a MemoryBufferRef when parsing configuration files.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: usaxena95, kadircet, arphaman, xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using a MemoryBufferRef, If there

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

aaron.ballman added a comment. In D92600#2443716 , @tmroeder wrote: > @aaron.ballman It looks like those template tests fail on x64 windows; this > is a problem that came up with D58292 as > well. It ended up getting rol

[clang] 2315e98 - [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

Author: Peter Waller Date: 2020-12-10T12:43:14Z New Revision: 2315e9874c92bf625ec84a5f45a4fa28bfbc16ce URL: https://github.com/llvm/llvm-project/commit/2315e9874c92bf625ec84a5f45a4fa28bfbc16ce DIFF: https://github.com/llvm/llvm-project/commit/2315e9874c92bf625ec84a5f45a4fa28bfbc16ce.diff LOG:

[PATCH] D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2315e9874c92: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend (authored by peterwaller-arm). Herald added a subscriber:

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:630 )cpp", + R"cpp( +template struct Foo { static T Variable; }; hokein wrote: > hmm, looks like these two tests are already working at head (witho

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

asb added a comment. In D92715#2443376 , @craig.topper wrote: > Can we discuss this patch in tomorrows RISC-V meeting? @jrtc27 @kito-cheng > @khchen @liaolucy I've added it to the agenda CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new

[PATCH] D92956: Fix https://bugs.llvm.org/show_bug.cgi?id=48011

fanfuqiang updated this revision to Diff 310847. fanfuqiang added a comment. update testcase take advise of reviewers. fix conflict testcase fail, less warnning only for `hasNonTrivialCopyConstructor` . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/ https://reviews.llvm.org/

[clang] 99ad078 - [AArch64] Cortex-R82: remove crypto

Author: Sjoerd Meijer Date: 2020-12-10T12:54:51Z New Revision: 99ad078b91ed601cd19c75a44106a4f86bfa1a41 URL: https://github.com/llvm/llvm-project/commit/99ad078b91ed601cd19c75a44106a4f86bfa1a41 DIFF: https://github.com/llvm/llvm-project/commit/99ad078b91ed601cd19c75a44106a4f86bfa1a41.diff LOG:

[PATCH] D91994: [AArch64] Cortex-R82: remove crypto

This revision was automatically updated to reflect the committed changes. Closed by commit rG99ad078b91ed: [AArch64] Cortex-R82: remove crypto (authored by SjoerdMeijer). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for the changes, LGTM! Comment at: clang/test/Frontend/plugin-attribute.cpp:1 -// RUN: %clang -fplugin=%llvmshlibdir/Attribute%pluginext -emit-llvm -S %s

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2445414 , @lebedev.ri wrote: > @mstorsjo please can you be more specific what kind of tests are starting to > fail? > Do those tests just check that the code compiled into an identical assembly? No, it's video/audio de

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch updated this revision to Diff 310853. kiausch added a comment. fixed format errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92935/new/ https://reviews.llvm.org/D92935 Files: clang/include/clang/Driver/Options.td llvm/lib/Target/PowerPC/PPC.td llvm/lib/Target/PowerPC/

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

awarzynski created this revision. Herald added subscribers: usaxena95, kadircet. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This is just a small change in the Flang tool within libclangDriver. Currently it pass

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri updated this revision to Diff 310855. lebedev.ri added a comment. This revision is now accepted and ready to land. Partial rebase (without updating test coverage) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87188/new/ https://reviews.l

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

aaron.ballman added a comment. In D92920#2443748 , @njames93 wrote: > In D92920#2443578 , @aaron.ballman > wrote: > >> Nothing is calling the new `parseConfigurationWithDiags()`, is that >> intentional? Also, is t

[PATCH] D93024: [clang-tidy] Use a MemoryBufferRef when parsing configuration files.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93024/new/ https://reviews.llvm.org/D93024 ___

[PATCH] D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check.

njames93 added a comment. I'm definitely of the opinion this should be an option in the `modernize-make-(shared|unique)` check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92992/new/ https://reviews.llvm.org/D92992 __

[PATCH] D92994: Remove references to the ast_type_traits namespace

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:95 for (const auto *Arg : CallExpr->arguments()) { - if (StartArg--

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

usaxena95 updated this revision to Diff 310861. usaxena95 added a comment. Update error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93029/new/ https://reviews.llvm.org/D93029 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp I

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686 +def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily", +"CortexA78C", +"Cortex-A78C ARM processors", [ +

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

fanfuqiang updated this revision to Diff 310865. fanfuqiang marked 2 inline comments as done. fanfuqiang added a comment. update testcase take advise of reviewers. fix conflict testcase fail, less warnning only for hasNonTrivialCopyConstructor . Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong added a comment. I wouldn't worry much about the `ASTMerge` tests, those are mostly legacy and not actively used nowadays. (At one point we were thinking even to remove them because we could got rid of the `ASTMergeAction` which is exclusively used for testing.) The main test infrastruc

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, dang, hiraditya, mgorny. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch enables the fexec-charset opt

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

DavidSpickett added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:833 +} + } pass &= AArch64::getCPUAttr(AK).equals(CPUAttr); MarkMurrayARM wrote: > DavidSpickett wrote: > > I assume this was left in from debugging, if not it sh

[PATCH] D92962: [ASTImporter] Fix import of a typedef that has an attribute

martong updated this revision to Diff 310869. martong added a comment. - Check the attribute in the test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92962/new/ https://reviews.llvm.org/D92962 Files: clang/lib/AST/ASTImporter.cpp clan

[PATCH] D92962: [ASTImporter] Fix import of a typedef that has an attribute

martong marked an inline comment as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6098 + FirstDeclMatcher().match(TU, typedefDecl(hasName("X"))); + auto *ToD = Import(FromD, Lang_CXX17); + ASSERT_TRUE(ToD); shafik

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 310870. jansvoboda11 added a comment. Rebase, use BoolOption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

qchateau updated this revision to Diff 310872. qchateau added a comment. Fix unittests and behavior I've fixed the failing unittests, added some more to test the new behavior, and fixed some bugs in the new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. This is now ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

aaron.ballman added a comment. In D91979#2444327 , @jdoerfert wrote: > In D91979#2440554 , @aaron.ballman > wrote: > >> Thank you for your patience with the delays getting to your review! Along >> with the documen

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. AFAIK all comments were addressed. Could you have another look at/LGTM this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commi

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:304 +Index->relations(Req, [](const SymbolID &SID, const Symbol &S) { + llvm::outs() << S << " defined at: " << S.Definition << "\n"; +}); I think dumping the

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

sameeranjoshi accepted this revision. sameeranjoshi added a comment. This revision is now accepted and ready to land. Thanks for extracting it from D92854 . I think the tests in D92854 were failing for the same reason. LGTM. Rep

[PATCH] D93024: [clang-tidy] Use a MemoryBufferRef when parsing configuration files.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34d2688a50f2: [clang-tidy] Use a MemoryBufferRef when parsing configuration files. (authored by njames93). Repository: rG LLVM Github Monorepo CH

[clang-tools-extra] 34d2688 - [clang-tidy] Use a MemoryBufferRef when parsing configuration files.

Author: Nathan James Date: 2020-12-10T14:52:45Z New Revision: 34d2688a50f23b4b15bdeab054e28e033ece9363 URL: https://github.com/llvm/llvm-project/commit/34d2688a50f23b4b15bdeab054e28e033ece9363 DIFF: https://github.com/llvm/llvm-project/commit/34d2688a50f23b4b15bdeab054e28e033ece9363.diff LOG:

[clang-tools-extra] a0cf2b8 - [clangd][NFC] Remove unnecessary vector.

Author: Nathan James Date: 2020-12-10T14:59:17Z New Revision: a0cf2b8f712e0bca9185d77cf1def8160f165548 URL: https://github.com/llvm/llvm-project/commit/a0cf2b8f712e0bca9185d77cf1def8160f165548 DIFF: https://github.com/llvm/llvm-project/commit/a0cf2b8f712e0bca9185d77cf1def8160f165548.diff LOG:

[PATCH] D92986: [clangd][NFC] Remove unnecessary vector.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0cf2b8f712e: [clangd][NFC] Remove unnecessary vector. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D92986?vs=310729&

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:92 + // to reference it and avoid the copy. + if (!isa(T) && !isa(T)) +return true; Comment at: clang-tools-ext

[PATCH] D92967: Tooling: Migrate some tests to FileEntryRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92967/new/ https://reviews.llvm.org/D92967 ___ cfe-commits mailing list cf

[PATCH] D92968: Frontend: Migrate to FileEntryRef in TextDiagnosticTest, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92968/new/ https://reviews.llvm.org/D92968

[clang] a7b2847 - [openmp] Remove clause from OMPKinds.def and use OMP.td info

Author: Valentin Clement Date: 2020-12-10T10:19:09-05:00 New Revision: a7b2847216b4f7a84ef75461fd47a5adfbb63e27 URL: https://github.com/llvm/llvm-project/commit/a7b2847216b4f7a84ef75461fd47a5adfbb63e27 DIFF: https://github.com/llvm/llvm-project/commit/a7b2847216b4f7a84ef75461fd47a5adfbb63e27.di

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b2847216b4: [openmp] Remove clause from OMPKinds.def and use OMP.td info (authored by clementval). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/PerformanceTidyModule.cpp:39 +CheckFactories.registerCheck( +"performance-implicit-conversion"); CheckFactories.registerCheck( This check has been around s

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92971/new/ https://reviews.llvm.org/D92971

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

thakis added inline comments. Comment at: clang/include/clang/AST/ASTTypeTraits.h:152 +#define CLAUSE_CLASS(Enum, Str, Class) NKI_##Class, +#include "llvm/Frontend/OpenMP/OMP.cpp.inc" NKI_NumberOfKinds Now we're even including the `cpp.inc` file in .h files.

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92975/new/ https://reviews.llvm.org/D92975 ___ cfe-commits mailing list cf

[PATCH] D92983: SourceManager: Migrate to FileEntryRef in getOrCreateContentCache, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. This LGTM, but it'd be nice to apply the formatting suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92983/new/ https://re

[PATCH] D92984: SourceManager: Change getOrCreateFileID API to take FileEntryRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. This LGTM, but it'd be nice to apply the formatting suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92984/new/ https://rev

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

thakis added a comment. And a less philosophical comment: This causes a bunch of Wcovered-switch-default warnings: ../../clang/include/clang/AST/OpenMPClause.h::5: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default] ../../clang/include/clang/AST/R

[clang] 456c885 - Revert "[openmp] Remove clause from OMPKinds.def and use OMP.td info"

Author: clementval Date: 2020-12-10T10:34:59-05:00 New Revision: 456c885df369f1e94d60da2658055b21c88e471d URL: https://github.com/llvm/llvm-project/commit/456c885df369f1e94d60da2658055b21c88e471d DIFF: https://github.com/llvm/llvm-project/commit/456c885df369f1e94d60da2658055b21c88e471d.diff LO

[PATCH] D92531: Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

jansvoboda11 added a comment. Left one question. Comment at: clang/lib/Basic/SourceManager.cpp:567 + if (IR.ContentsEntry->isNamedPipe()) +(void)IR.getBufferOrNone(Diag, getFileManager(), SourceLocation()); + What's the reason behind duplicating the logic

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx updated this revision to Diff 310888. flx added a comment. Added positive variants of new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/ https://reviews.llvm.org/D91893 Files: clang-tools-extra/clang-tidy/performance/Unneces

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx marked an inline comment as done. flx added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:492 + Orig.nonConstMethod(); +} aaron.ballman wrote: > Making sure I understand properly, if

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

usaxena95 updated this revision to Diff 310893. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93029/new/ https://reviews.llvm.org/D93029 File

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 updated this revision to Diff 310894. njames93 added a comment. Herald added a subscriber: mgorny. Added test cases. Added assert to ensure Handler is valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92920/new/ https://reviews.llvm.org

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback Handler) { + llvm::yaml::Input Input(Config, nullptr, Handler ? diagHandlerImpl : nullptr, +

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ce242a163c3: [clangd] Find relations in Dex exploration tool. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] 4ce242a - [clangd] Find relations in Dex exploration tool.

Author: Utkarsh Saxena Date: 2020-12-10T16:54:03+01:00 New Revision: 4ce242a163c3b98385a5cb949a7e6b1e1ae7eb83 URL: https://github.com/llvm/llvm-project/commit/4ce242a163c3b98385a5cb949a7e6b1e1ae7eb83 DIFF: https://github.com/llvm/llvm-project/commit/4ce242a163c3b98385a5cb949a7e6b1e1ae7eb83.diff

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval added a comment. In D92955#2445815 , @thakis wrote: > And a less philosophical comment: This causes a bunch of > Wcovered-switch-default warnings: > > ../../clang/include/clang/AST/OpenMPClause.h::5: warning: default label > in switch whic

  1   2   3   >