kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190
const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) {
- llvm::SmallVector<llvm::StringRef, 4> Components;
+ llvm::SmallVector<llvm::StringRef> Components;
QName.split(Components, "::");
----------------
kbobyrev wrote:
> njames93 wrote:
> > A follow up refractor, this doesn't strictly need to be stored in a vector.
> Could you please elaborate? I don't really understand this comment.
(D92986 for context)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92788/new/
https://reviews.llvm.org/D92788
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
