sameeranjoshi added a comment. Thanks for patch, a few queries below.
Are the tests in clang which are related to flang failing at https://reviews.llvm.org/B81474? ================ Comment at: flang/include/flang/Frontend/FrontendActions.h:29 +class SyntaxOnlyAction : public FrontendAction { + void ExecuteAction() override; ---------------- Do you think following a pattern here for mapping with `enum ActionKind` would be better? something like `ParseSyntaxOnlyAction` ? ================ Comment at: flang/include/flang/Frontend/FrontendOptions.h:1 //===- FrontendOptions.h ----------------------------------------*- C -*-===// // ---------------- C++ ? ================ Comment at: flang/lib/Frontend/FrontendActions.cpp:96 + semantics.EmitMessages(ci.semaOutputStream()); +} ---------------- What happens in case one of the stages in the pipeline fails? Where is the error recovery done for e.g if parsing fails ? ================ Comment at: flang/unittests/Frontend/PrintPreprocessedTest.cpp:121 + + // 4. Executre the ParseSyntaxOnly action + bool success = ExecuteCompilerInvocation(&compInst); ---------------- Execute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
