martong marked an inline comment as done. martong added inline comments.
================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:6098 + FirstDeclMatcher<TypedefDecl>().match(TU, typedefDecl(hasName("X"))); + auto *ToD = Import(FromD, Lang_CXX17); + ASSERT_TRUE(ToD); ---------------- shafik wrote: > We can't check the attribute is present? Yes, good point. I've update with some more checks. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92962/new/ https://reviews.llvm.org/D92962 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits