clementval added a comment. In D92955#2445815 <https://reviews.llvm.org/D92955#2445815>, @thakis wrote:
> And a less philosophical comment: This causes a bunch of > Wcovered-switch-default warnings: > > ../../clang/include/clang/AST/OpenMPClause.h:7777:5: warning: default label > in switch which covers all enumeration values [-Wcovered-switch-default] > ../../clang/include/clang/AST/RecursiveASTVisitor.h:2962:3: warning: default > label in switch which covers all enumeration values [-Wcovered-switch-default] > > (and possibly more). Yeah just saw that and reverted the patch. I'll rework a bit the patch to include your suggestion from D83636 <https://reviews.llvm.org/D83636>. MLIR is doing it this way so I'm fine with doing it the other way as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
