[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

craig.topper added inline comments. Comment at: llvm/test/Bitcode/compatibility-6.0.ll:439 ; CHECK: declare hhvm_ccc void @f.hhvm_ccc() -declare cc83 void @f.cc83() +declare cc83 void @f.cc83(i8* byval(i8)) ; CHECK: declare x86_intrcc void @f.cc83() Why do we n

[clang] 776f92e - [X86] Add support for vex, vex2, vex3, and evex for MASM

Author: Liu, Chen3 Date: 2020-11-20T16:20:19+08:00 New Revision: 776f92e06759e2491018f66ea334adb687337f1c URL: https://github.com/llvm/llvm-project/commit/776f92e06759e2491018f66ea334adb687337f1c DIFF: https://github.com/llvm/llvm-project/commit/776f92e06759e2491018f66ea334adb687337f1c.diff LO

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG776f92e06759: [X86] Add support for vex, vex2, vex3, and evex for MASM (authored by LiuChen3). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet updated this revision to Diff 306615. kadircet marked 6 inline comments as done. kadircet added a comment. - Internalize synchronization of indexstorage rather than using Memoize Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90750/new/ htt

[PATCH] D90751: [clangd] Use ProjectAwareIndex

kadircet updated this revision to Diff 306621. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90751/new/ https://reviews.llvm.org/D90751 Files: clang-tools-extra/clangd/tool/ClangdMain.cpp Index: clang-tools-e

[clang-tools-extra] da14ae2 - [clangd] NFC: Reorder headers in tests accordig to Clang-Tidy

Author: Kirill Bobyrev Date: 2020-11-20T10:38:41+01:00 New Revision: da14ae23a54783a4bb2e20651af434530510e704 URL: https://github.com/llvm/llvm-project/commit/da14ae23a54783a4bb2e20651af434530510e704 DIFF: https://github.com/llvm/llvm-project/commit/da14ae23a54783a4bb2e20651af434530510e704.diff

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > ro wrote: > > MaskRay wrote: > > > GNU ld reports a warning instead of an error when an unk

[PATCH] D91806: [SVE] Remove warnings from release notes example on SVE ACLE.

fpetrogalli updated this revision to Diff 306626. fpetrogalli added a comment. I updated the RUN lines of the `.ll` test to prevent the failure at https://reviews.llvm.org/harbormaster/unit/view/196899/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

kadircet updated this revision to Diff 306633. kadircet marked 2 inline comments as done. kadircet added a comment. - Mention assertions and ninja Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91186/new/ https://reviews.llvm.org/D91186 Files: cl

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

kadircet added inline comments. Comment at: clang-tools-extra/clangd/README.md:26 +- Create a build directory, for example at `$LLVM_ROOT/build`. +- Inside the build directory run: `cmake $LLVM_ROOT/llvm/ + -DCMAKE_BUILD_TYPE=RELEASE -DLLVM_ENABLE_PROJECTS="clang;clang-tools-ext

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:91-94 +This mode is hard to use correctly and +requires more development iteration because it means +that the user must write AST Matchers to explicitly traverse or ignore nodes +which are not vis

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire updated this revision to Diff 306634. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersReference.html Index: clang/docs/LibASTMatc

[PATCH] D91104: APINotes: add property models for YAML attributes

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks, looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91104/new/ https://reviews.llvm.org/D91104 __

[PATCH] D91806: [SVE] Remove warnings from release notes example on SVE ACLE.

fpetrogalli added a comment. FYI: I am trying to figure out this failure that does not appear on my machine: https://reviews.llvm.org/harbormaster/unit/view/196974/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Config.h:95 + static inline ExternalIndexSpec getEmptyKey() { +static ExternalIndexSpec E{ExternalIndexSpec::File, "", ""}

[PATCH] D91806: [SVE] Remove warnings from release notes example on SVE ACLE.

fpetrogalli updated this revision to Diff 306643. fpetrogalli added a comment. This last change is trying to remove the failure at https://reviews.llvm.org/harbormaster/unit/view/196974/ I haven’t been able to reproduce such failure on my dev machine, so I just changed the RUN lines in the test

[clang-tools-extra] 44c96be - Fix MSVC "not all control paths return a value" warnings. NFCI.

Author: Simon Pilgrim Date: 2020-11-20T11:41:20Z New Revision: 44c96becc9734fa23b7f38688a8f5c72e1f2e891 URL: https://github.com/llvm/llvm-project/commit/44c96becc9734fa23b7f38688a8f5c72e1f2e891 DIFF: https://github.com/llvm/llvm-project/commit/44c96becc9734fa23b7f38688a8f5c72e1f2e891.diff LOG:

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

c-rhodes accepted this revision. c-rhodes added a comment. In D91696#2405082 , @joechrisellis wrote: > Address @c-rhodes's comments regarding lax conversion when > __ARM_FEATURE_SVE_BITS != N for GNU vectors. Cheers, LGTM Repository: rG LLVM Github

[PATCH] D91859: [clangd] Fix shared-lib builds

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Gith

[PATCH] D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a hack to prevent cyclic de

[clang] 2f1fe9a - [clang][CodeGen] Move riscv specific tests to RISCV subtarget folder

Author: Simon Pilgrim Date: 2020-11-20T12:03:28Z New Revision: 2f1fe9a3a60d6f18998c5f3b7e643d4cbaa4e65d URL: https://github.com/llvm/llvm-project/commit/2f1fe9a3a60d6f18998c5f3b7e643d4cbaa4e65d DIFF: https://github.com/llvm/llvm-project/commit/2f1fe9a3a60d6f18998c5f3b7e643d4cbaa4e65d.diff LOG:

[clang] 822c5c5 - [clang][CodeGen] Move WebAssembly specific tests to WebAssembly subtarget folder

Author: Simon Pilgrim Date: 2020-11-20T12:03:28Z New Revision: 822c5c50849a1f762c920d59baaa6a6edbb657ee URL: https://github.com/llvm/llvm-project/commit/822c5c50849a1f762c920d59baaa6a6edbb657ee DIFF: https://github.com/llvm/llvm-project/commit/822c5c50849a1f762c920d59baaa6a6edbb657ee.diff LOG:

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

jansvoboda11 created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang. Herald added projects: clang, LLVM. jansvoboda11 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91861 Files: clang/include/clang/Driver/Options.td

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

OikawaKirie updated this revision to Diff 306590. OikawaKirie added a comment. 1. Replace fatal errors with assertions. >> In D91410#2400018 , @tejohnson >> wrote: > > If these are not likely due to user input issues, then perhaps they should > all be as

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

tejohnson accepted this revision. tejohnson added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Thank you for taking care of thiis! The complete fix, however, should include two more things: 1. Moving this if (CLANGD_ENABLE_REMOTE) include(FindGRPC) endif() before

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. Actually, it would be safer if `FindGRPC` was also higher than `add_subdirectory(tool)`: right now it only includes `remote/index/Client.h` and `Client.h` does not depend on any gRPC/Protobuf headers for now but that might change at some point and break builds unexpect

[PATCH] D83694: Port DependencyOutput option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this revision as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D83694: Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 306668. jansvoboda11 added a comment. Rebase, undo the move of options, introduce makeFlagToValueNormalizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 Files:

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:473 +MarshallingInfoFlag<"DependencyOutputOpts.OutputFormat", "DependencyOutputFormat::Make">, +Normalizer<"makeFlagToValueNormalizer(DependencyOutputFormat::NMake)">; def Mach : Flag<

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new documentation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D9163

[clang] 2033fa2 - Add documentation illustrating use of IgnoreUnlessSpelledInSource

Author: Stephen Kelly Date: 2020-11-20T13:49:25Z New Revision: 2033fa29b09f9402a9f09f9de20414e82f7d174c URL: https://github.com/llvm/llvm-project/commit/2033fa29b09f9402a9f09f9de20414e82f7d174c DIFF: https://github.com/llvm/llvm-project/commit/2033fa29b09f9402a9f09f9de20414e82f7d174c.diff LOG:

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2033fa29b09f: Add documentation illustrating use of IgnoreUnlessSpelledInSource (authored by stephenkelly). Repository: rG LLVM Github Monorepo C

[clang] 2ce6352 - Add a call super attribute plugin example

Author: Yafei Liu Date: 2020-11-20T08:51:12-05:00 New Revision: 2ce6352e46344d97fed6a3ca6de7228345956191 URL: https://github.com/llvm/llvm-project/commit/2ce6352e46344d97fed6a3ca6de7228345956191 DIFF: https://github.com/llvm/llvm-project/commit/2ce6352e46344d97fed6a3ca6de7228345956191.diff LOG

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman closed this revision. aaron.ballman added a comment. In D91047#2407091 , @psionic12 wrote: > @aaron.ballman That would be nice if your could help, and `Yafei Liu > ` is okay. Thank you for the new example, I've commit on your behalf in 2ce

[PATCH] D83697: Port Frontend option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D83697: Port Frontend option flags to new option parsing system

jansvoboda11 updated this revision to Diff 306675. jansvoboda11 added a comment. Herald added a reviewer: sscalpone. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rebase, undo move of options, implement IsNegative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ https://reviews.llvm.org/D91009 __

[PATCH] D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/ProjectAware.h:27 /// Returns an index that answers queries using external indices. IndexGenerator /// can be used to

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

arsenm added inline comments. Comment at: llvm/test/Bitcode/compatibility-6.0.ll:439 ; CHECK: declare hhvm_ccc void @f.hhvm_ccc() -declare cc83 void @f.cc83() +declare cc83 void @f.cc83(i8* byval(i8)) ; CHECK: declare x86_intrcc void @f.cc83() craig.topper wrot

[PATCH] D91859: [clangd] Fix shared-lib builds

sammccall added a comment. I'm not totally following the discussion on the more complete fix (LMK if you want me to dig into that), but if the build is broken in some configurations we should likely prioritize fixing that over ensuring the fix is conceptually complete. > Otherwise by the time

[clang] 95ce9fb - [clang] Do not crash on pointer wchar_t pointer assignment.

Author: Adam Czachorowski Date: 2020-11-20T15:27:15+01:00 New Revision: 95ce9fbc235a467b84b2ffa2571f1d1a45af9427 URL: https://github.com/llvm/llvm-project/commit/95ce9fbc235a467b84b2ffa2571f1d1a45af9427 DIFF: https://github.com/llvm/llvm-project/commit/95ce9fbc235a467b84b2ffa2571f1d1a45af9427.d

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95ce9fbc235a: [clang] Do not crash on pointer wchar_t pointer assignment. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 306679. gbencze added a comment. Herald added a subscriber: jfb. Address comments: - add new test case for `_Atomic` (with a FIXME comment) - fix string literal formatting - update docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89651/new/ https

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 306680. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 Files: clang/include/clang/Basic/LangOptions.def clang/lib/Frontend/CompilerIn

[PATCH] D91868: [clangd] Mention when CXXThis is implicit in exposed AST.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Seeing an implicit this in the AST is pre

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein added a comment. should be ready to go -- from our internal experiment, we don't see any super crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 __

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 ___ cfe-commits mailing list cfe-commit

[PATCH] D91806: [SVE] Remove warnings from release notes example on SVE ACLE.

fpetrogalli updated this revision to Diff 306684. fpetrogalli added a comment. I have removed the C test, as the LL test is enough to test the changes I have done in `Local.cpp`. I can confirm that with this patch, the release note ton'r raise any warnings when compiling with debug info: fra

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jwakely added a comment. As of a few hours ago, GCC has [`__builtin_clear_padding`](https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#index-_005f_005fbuiltin_005fclear_005fpadding) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87974/new/ http

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4f9b5d442a2: [clang-tidy] Include std::basic_string_view in readability-redundant-string… (authored by ckennelly). Repository: rG LLVM Github Mon

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

sdesmalen added a comment. This patch needs to be retitled to what this is actually doing: changing the getTypeAllocationSizeInBits and getFragmentSizeInBits to return a TypeSize instead of `unsigned`. It would be even better if you can split those up into two patches with separate tests for ea

[clang-tools-extra] e4f9b5d - [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

Author: Chris Kennelly Date: 2020-11-20T10:06:57-05:00 New Revision: e4f9b5d442a260dd78b3de581cec1e90567a2aac URL: https://github.com/llvm/llvm-project/commit/e4f9b5d442a260dd78b3de581cec1e90567a2aac DIFF: https://github.com/llvm/llvm-project/commit/e4f9b5d442a260dd78b3de581cec1e90567a2aac.diff

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

faisalv added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91035/new/ https://reviews.llvm.org/D91035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc updated this revision to Diff 306686. smhc added a comment. Updated diff to use 'IgnoredRegexp' I see that a regexp has been used elsewhere for some other checks (macro usage, AllowedRegexp). (as a side note, I see that AllowedRegexp string is getting compiled on every match rather than pr

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc updated this revision to Diff 306687. smhc added a comment. removed notes on short length threshold CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-ex

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1756 /// a function. -enum FunctionDefinitionKind { - FDK_Declaration, - FDK_Definition, - FDK_Defaulted, - FDK_Deleted +enum class FunctionDefinitionKind : unsigned char { + Declaration, -

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 306690. abelkocsis added a comment. Fix, `MacroName == "__unix__"` seems really necessary. Without that, it throws a warning for me on Linux. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis added a comment. In D75229#2406758 , @jfb wrote: > Most of the tests as written should be failing right now, at least on macOS > and Linux, because they likely should be identified as POSIX, right? Yes, now it fails on my system too. What woul

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91373/new/ https://reviews.llvm.org/D91373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] 51e09e1 - [AMDGPU] Set the default globals address space to 1

Author: Alex Richardson Date: 2020-11-20T15:46:53Z New Revision: 51e09e1d5aa43296cf8baf26a74793fd86b0b0d2 URL: https://github.com/llvm/llvm-project/commit/51e09e1d5aa43296cf8baf26a74793fd86b0b0d2 DIFF: https://github.com/llvm/llvm-project/commit/51e09e1d5aa43296cf8baf26a74793fd86b0b0d2.diff LO

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

This revision was automatically updated to reflect the committed changes. Closed by commit rG51e09e1d5aa4: [AMDGPU] Set the default globals address space to 1 (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D84345?vs=289235&id=306693#toc Repository: rG LLVM Githu

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 5 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1443 + if (Arg *A = + Args.getLastArg(OPT_mabi_EQ_vec_default, OPT_mabi_EQ_vec_extabi)) { Xiangling_L wrote: > Should we als

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 306696. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Addressed comments and added a test to check whether the driver passes these options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D8968

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

erik2020 added a comment. In D90928#2405796 , @Anastasia wrote: > Do you think we could improve testing? I presume there is something that > triggers a failure without your change... I'm not really sure how to test this code. Best I can tell, there's no

[PATCH] D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls.

ymandel created this revision. ymandel added a reviewer: tdl-g. Herald added a project: clang. ymandel requested review of this revision. Currently, `node` only includes the semicolon for (some) statements. However, declarations have the same issue of trailing semicolons, so `node` should behave t

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new check! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89651/new/ https://reviews.llvm.org/D89651

[PATCH] D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls.

aaron.ballman added a comment. Drive-by question from the peanut gallery, sorry if this is an ignorant one -- not all declarations have a trailing semicolon; is that handled properly? e.g., `int x;` has a trailing semicolon but `int x, y;` only has a trailing semicolon for one of the two declar

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Thank you for the review @sdesmalen 1. I have replied to the comment about `auto` with my reason for removing it. 2. I removed the C test, as the LL file is enough. 3. The third comment requires more investigation, I'll ge

[PATCH] D91874: [GNU ObjC] Fix a regression listing methods twice.

theraven created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. theraven requested review of this revision. Methods synthesized from declared properties were being added to the method lists twice. This came from the change to list them in the class's method

[PATCH] D91874: [GNU ObjC] Fix a regression listing methods twice.

theraven added a comment. This was caught with the GNUstep runtime's test suite, which apparently had not been run with anything newer than clang 8 until recently. With this patch, all of the runtime's tests now pass again (a few others failed in 10 but appear to have been fixed in 11 or 12).

[PATCH] D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls.

ymandel updated this revision to Diff 306707. ymandel added a comment. Clarified that semicolons are only removed if present. Fixed test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91872/new/ https://reviews.llvm.org/D91872 Files: clang-tools

[PATCH] D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls.

ymandel added a comment. In D91872#2408278 , @aaron.ballman wrote: > Drive-by question from the peanut gallery, sorry if this is an ignorant one > -- not all declarations have a trailing semicolon; is that handled properly? > e.g., `int x;` has a traili

[PATCH] D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls.

aaron.ballman added a comment. In D91872#2408321 , @ymandel wrote: > In D91872#2408278 , @aaron.ballman > wrote: > >> Drive-by question from the peanut gallery, sorry if this is an ignorant one >> -- not all decla

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman added inline comments. Comment at: clang/test/Frontend/noderef.c:71 + x = sizeof(s->a + (s->b)); // ok + // Nested struct access Can you add tests for the weird situations where the expression actually is evaluated? e.g., ``` struct S { virtu

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

tejohnson added a comment. From a ThinLTO perspective, no specific concerns as the buildModuleSimplificationPipeline is invoked in both the pre and post LTO link pipelines, so they both get an equivalent change. But there is an issue for regular LTO, noted below. Comment at:

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 306715. fpetrogalli edited the summary of this revision. fpetrogalli added a comment. I have added assertions around before `TypeSize` comparisons where it made sense to do so, but not in the lambda used in the `sort` invocation. Repository: rG LLVM G

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:589 sort(FrameData.Allocas, [&](const auto &Iter1, const auto &Iter2) { -return GetAllocaSize(Iter1) > GetAllocaSize(Iter2); +retur

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:127-128 getFileStyleFromOptions(const ClangTidyCheck::OptionsView &Options) { SmallVector, 0> Styles( SK_Count); SmallString<64> StyleString;

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added a comment. In D91373#2408175 , @jacobdweightman wrote: > Ping 1. Provide full diff, see https://www.llvm.org/docs/Phabricator.html for the guidance. 2. Need some more test with ast printing and codegen. 3. Would be good if you could run

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

zequanwu updated this revision to Diff 306724. zequanwu added a comment. Herald added a subscriber: dexonsmith. Add ThreadModel to LangOptions and remove it from CodegenOption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91747/new/ https://review

[clang] 88e6208 - [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls.

Author: Yitzhak Mandelbaum Date: 2020-11-20T18:11:50Z New Revision: 88e62085624e7ec55bd4a41c6d77acdcb7f1d113 URL: https://github.com/llvm/llvm-project/commit/88e62085624e7ec55bd4a41c6d77acdcb7f1d113 DIFF: https://github.com/llvm/llvm-project/commit/88e62085624e7ec55bd4a41c6d77acdcb7f1d113.diff

[PATCH] D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88e62085624e: [libTooling] Update Transformer's `node` combinator to include the trailing… (authored by ymandel). Changed prior to commit: https:/

[PATCH] D91565: Guard init_priority attribute within libc++

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/init-priority-attr.cpp:26 Two foo __attribute__((init_priority(101))) ( 5, 6 ); +#if defined(__MVS__) + #if defined(SYSTEM) Rather than using the preprocessor, you can assign a prefix to be chec

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

kuhar added a comment. Looks fine to me, but I'm not confident enough to give an approval. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:733-735 + static AnalysisKey Key; + +public: This is already public CHANGES SINCE LAST ACTION https://review

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. In D87974#2408119 , @jwakely wrote: > As of a few hours ago, GCC has `__builtin_clear_padding`, see > https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#index-_005f_005fbuiltin_005fclear_005fpadding > for the docs. Great.

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

wmi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:978-982 Opts.DebugInfoForProfiling = Args.hasFlag( OPT_fdebug_info_for_profiling, OPT_fno_debug_info_for_profiling, false); + Opts.PseudoProbeForProfiling = + Args.hasFlag(OPT_fpseudo

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

hoy added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:978-982 Opts.DebugInfoForProfiling = Args.hasFlag( OPT_fdebug_info_for_profiling, OPT_fno_debug_info_for_profiling, false); + Opts.PseudoProbeForProfiling = + Args.hasFlag(OPT_fpseudo

[clang] 8f51dc4 - [OPENMP]Honor constantness of captured variables.

Author: Alexey Bataev Date: 2020-11-20T11:11:47-08:00 New Revision: 8f51dc49673c494cc1d118979b596288e938af13 URL: https://github.com/llvm/llvm-project/commit/8f51dc49673c494cc1d118979b596288e938af13 DIFF: https://github.com/llvm/llvm-project/commit/8f51dc49673c494cc1d118979b596288e938af13.diff

[PATCH] D91644: [OPENMP]Honor constantness of captured variables.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f51dc49673c: [OPENMP]Honor constantness of captured variables. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. njames93 requested review of this revision. Add methods for emitting diagnostics with no location as well as a specia

[PATCH] D91565: Guard init_priority attribute within libc++

ldionne accepted this revision as: libc++. ldionne added a comment. LGTM from libc++'s perspective. You should wait until the Clang part is LGTM'd before committing, of course. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91565/new/ https://revie

[clang] c964f30 - [OPENMP]Use the real pointer value as base, not indexed value.

Author: Alexey Bataev Date: 2020-11-20T11:34:14-08:00 New Revision: c964f308141578f24932c68a03af5fae7f876011 URL: https://github.com/llvm/llvm-project/commit/c964f308141578f24932c68a03af5fae7f876011 DIFF: https://github.com/llvm/llvm-project/commit/c964f308141578f24932c68a03af5fae7f876011.diff

[PATCH] D91805: [OPENMP]Use the real pointer value as base, not indexed value.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc964f3081415: [OPENMP]Use the real pointer value as base, not indexed value. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D91565: Guard init_priority attribute within libc++

zibi updated this revision to Diff 306753. zibi added a comment. Make test cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91565/new/ https://reviews.llvm.org/D91565 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Att

[PATCH] D91565: Guard init_priority attribute within libc++

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91565/new/ https://reviews.llvm.org/D91565 ___ cfe-commit

[PATCH] D91565: Guard init_priority attribute within libc++

zibi marked an inline comment as done. zibi added inline comments. Comment at: clang/test/SemaCXX/init-priority-attr.cpp:26 Two foo __attribute__((init_priority(101))) ( 5, 6 ); +#if defined(__MVS__) + #if defined(SYSTEM) aaron.ballman wrote: > Rather than using

[PATCH] D89046: [AST] Build recovery expression by default for all language.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-ppc-error.c:51 void testCTF(int index) { - vec_ctf(vsi, index); //expected-error {{argument to '__builtin_altivec_vcfsx'

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:978-982 Opts.DebugInfoForProfiling = Args.hasFlag( OPT_fdebug_info_for_profiling, OPT_fno_debug_info_for_profi

[clang-tools-extra] de5b0b7 - [clangd] semanticTokens: fields are 'property', not 'member'

Author: Sam McCall Date: 2020-11-20T20:53:12+01:00 New Revision: de5b0b776fd7de72078256e003ede4fb5c37cdcb URL: https://github.com/llvm/llvm-project/commit/de5b0b776fd7de72078256e003ede4fb5c37cdcb DIFF: https://github.com/llvm/llvm-project/commit/de5b0b776fd7de72078256e003ede4fb5c37cdcb.diff LO

  1   2   >