arsenm added inline comments.
================ Comment at: llvm/test/Bitcode/compatibility-6.0.ll:439 ; CHECK: declare hhvm_ccc void @f.hhvm_ccc() -declare cc83 void @f.cc83() +declare cc83 void @f.cc83(i8* byval(i8)) ; CHECK: declare x86_intrcc void @f.cc83() ---------------- craig.topper wrote: > Why do we need to change arguments here? Isn't no arguments allowed? It is allowed, although I'm not sure if it should be. Clang just ignores the attribute on functions with no arguments ================ Comment at: llvm/test/Bitcode/compatibility-6.0.ll:441 ; CHECK: declare x86_intrcc void @f.cc83() -declare x86_intrcc void @f.x86_intrcc() +declare x86_intrcc void @f.x86_intrcc()) ; CHECK: declare x86_intrcc void @f.x86_intrcc() ---------------- craig.topper wrote: > What's this extra parenthese for? To surprise us that this actually parses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91840/new/ https://reviews.llvm.org/D91840 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
