sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Config.h:95
+ static inline ExternalIndexSpec getEmptyKey() {
+ static ExternalIndexSpec E{ExternalIndexSpec::File, "", ""};
+ return E;
----------------
(nit: static isn't saving anything here I think: cost of constructing == cost
of copying)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90750/new/
https://reviews.llvm.org/D90750
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
