erik2020 added a comment. In D90928#2405796 <https://reviews.llvm.org/D90928#2405796>, @Anastasia wrote:
> Do you think we could improve testing? I presume there is something that > triggers a failure without your change... I'm not really sure how to test this code. Best I can tell, there's no way for the `clang` executable to call these functions with invalid strings. I only ran into the seg faults when I was programmatically setting options using the clang API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
