sdesmalen added a comment.
This patch needs to be retitled to what this is actually doing: changing the
getTypeAllocationSizeInBits and getFragmentSizeInBits to return a TypeSize
instead of `unsigned`.
It would be even better if you can split those up into two patches with
separate tests for each one of them.
================
Comment at: clang/test/CodeGen/aarch64-sve-acle-rel-note.c:1
+// REQUIRES: aarch64-registered-target
+// RUN: %clang --target=aarch64-linux-gnu -march=armv8-a+sve -S -emit-llvm -o
- -c %s -Werror -Wall -g -O0 2>%t | FileCheck %s
----------------
I'm not entirely sure if it is acceptable to have a clang test that generates
assembly, but in any case I think this test needs to be added in a separate
patch.
================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:56
+Optional<TypeSize> DbgVariableIntrinsic::getFragmentSizeInBits() const {
+ if (Optional<DIExpression::FragmentInfo> Fragment =
+ getExpression()->getFragmentInfo())
----------------
Change back to `auto` ?
================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1373
+ if (Optional<TypeSize> FragmentSize = DII->getFragmentSizeInBits())
+ return TypeSize::isKnownGE(ValueSize, *FragmentSize);
// We can't always calculate the size of the DI variable (e.g. if it is a
----------------
Should the scalable flag match? Same question for all the other cases in this
patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91806/new/
https://reviews.llvm.org/D91806
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
