[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge updated this revision to Diff 302759. nridge marked 4 inline comments as done. nridge added a comment. Address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89670/new/ https://reviews.llvm.org/D89670 Files: clang-too

[clang-tools-extra] 3bec07f - [clangd] Store the containing symbol for refs

Author: Nathan Ridge Date: 2020-11-04T03:21:45-05:00 New Revision: 3bec07f91fb1aea7a53ebc760f0511be1b5409f4 URL: https://github.com/llvm/llvm-project/commit/3bec07f91fb1aea7a53ebc760f0511be1b5409f4 DIFF: https://github.com/llvm/llvm-project/commit/3bec07f91fb1aea7a53ebc760f0511be1b5409f4.diff

[PATCH] D89670: [clangd] Store the containing symbol for refs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bec07f91fb1: [clangd] Store the containing symbol for refs (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 updated this revision to Diff 302769. LiuChen3 added a comment. 1. Address comments; 2. Only support parsing vex/vex2/vex3/evex prefix for MASM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90441/new/ https://reviews.llvm.org/D90441 Fil

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 added inline comments. Comment at: clang/test/CodeGen/X86/ms-inline-asm-prefix.c:1 +// RUN:%clang_cc1 %s -ferror-limit 0 -triple=x86_64-pc-widows-msvc -target-feature +avx512f -target-feature +avx2 -target-feature +avx512vl -fasm-blocks -mllvm -x86-asm-syntax=intel -S

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm updated this revision to Diff 302773. david-arm marked an inline comment as done. david-arm edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new/ https://reviews.llvm.org/D89031 Files: clang/docs/LanguageExtensions.rst clang/include/c

[clang-tools-extra] a57550d - [clangd] Pass parameters to config apply functions

Author: Kadir Cetinkaya Date: 2020-11-04T10:29:24+01:00 New Revision: a57550def15e77e33dd6a4de22c83885c8fdc6f1 URL: https://github.com/llvm/llvm-project/commit/a57550def15e77e33dd6a4de22c83885c8fdc6f1 DIFF: https://github.com/llvm/llvm-project/commit/a57550def15e77e33dd6a4de22c83885c8fdc6f1.dif

[PATCH] D90455: [clangd] Pass parameters to config apply functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa57550def15e: [clangd] Pass parameters to config apply functions (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske updated this revision to Diff 302778. balazske added a comment. Updated according to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 Files: clang-tools-extra/clang-tidy/bugprone/Bugpron

[PATCH] D90593: [Clang] Add more fp128 math library function builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG7faf62a80bfc: [Clang] Add more fp128 math library function builtins (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.l

[clang] 7faf62a - [Clang] Add more fp128 math library function builtins

Author: Qiu Chaofan Date: 2020-11-04T17:58:42+08:00 New Revision: 7faf62a80bfc3a9dfe34133681fcc31f8e8d658b URL: https://github.com/llvm/llvm-project/commit/7faf62a80bfc3a9dfe34133681fcc31f8e8d658b DIFF: https://github.com/llvm/llvm-project/commit/7faf62a80bfc3a9dfe34133681fcc31f8e8d658b.diff L

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. RemoteIndexClient implemen

[PATCH] D90747: [clangd] Mark AsyncTaskRunner::runAsync as const

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. RunAsync performs a write that's internally

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Enable configuration of remote and static i

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: ormris, MaskRay, ilya-biryukov. Compilation logic for External bloc

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. An index implementation that can di

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet planned changes to this revision. kadircet added a comment. This is a WIP patch. Provided as a way to demonstrate how `ExternalBlock` will be used in an index implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90750/new/ https:

[PATCH] D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Syntax.td:9 +// +// The C++ grammatical structure modeled by libSyntax is quite regular. +// ==

[PATCH] D90751: [clangd] Use ProjectAwareIndex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Put project-aware-index between command-lin

[PATCH] D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Syntax.td:31 + +// NodeType is the root of the archetype hierarchy. +class NodeType { "Records derived from NodeType correspond to syntax tree node types." Repository: rG LLVM Gi

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. > e.g. we may introduce abstract bases like "loop" that the grammar doesn't > care about in order to model is-a concepts that might make refactorings more > expressive. This is less na

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:115 LINK_LIBS + clangdRemoteIndex clangdSupport If we're moving `clangdRemoteIndex` to `clangDaemon` there is no need to link `clangd` itself to `clangdRemoteIndex` anymor

[PATCH] D90659: [Syntax] Tablegen Sequence classes. NFC

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Nodes.td:123 +Role<"CloseParen", Token<"r_paren">>, + ]; +} The reason why in my prototype th

[PATCH] D90754: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, ASDenysPetrov, Szelethus. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:916-918 + virtual const CXXInheritedCtorInitExpr *getOriginExpr() const { +return cast(AnyFunctionCall::getOriginExpr()); + } NoQ wrote: > steakha

[PATCH] D87360: clang-cl: Alias /wd4101 to -Wno-unused-variable

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87360/new/ https://reviews.llvm.org/D87360 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D87364: clang-cl: Alias /wd4238 to -Wno-address-of-temporary

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87364/new/ https://reviews.llvm.org/D87364 ___ cfe-c

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

DmitryPolukhin added a comment. Sorry, I don't think it's worth reverting and resubmitting the same changes in such a case. Commit attribution is correct and there is link to this code review. After all, most clang-tidy users will never read commit messages and will only use `--help` for discov

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/ipra-reg-usage.ll:6 define preserve_allcc void @foo()#0 { -; CHECK: foo Clobbered Registers: $cs $df $ds $eflags $eip $eiz $es $fpcw $fpsw $fs $gs $hip $ip $mxcsr $rip $riz $ss $ssp $bnd0 $bnd1 $bnd2 $bnd3 $cr0

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

steakhal added a comment. Herald added subscribers: ASDenysPetrov, martong, Charusso, dkrupp. I'm not sure if this implementation is correct. I'm expecting this checker code not to crash: const auto *alloc = dyn_cast(&Call); if (!alloc) return; const int NumImpArgs = alloc->getNumIm

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 302818. njames93 added a comment. Rebase and make apply take reference to Params. Fix fragments checks being applied on top of each other instead of overwriting the current config checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:115 LINK_LIBS + clangdRemoteIndex clangdSupport kbobyrev wrote: > If we're moving `clangdRemoteIndex` to `clangDaemon` there is no need to link > `clangd` itself to `clang

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

kadircet updated this revision to Diff 302820. kadircet marked 2 inline comments as done. kadircet added a comment. - Revert indentation changes - Move all libraries to private to be consistent on what we link in ClangdMain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D87368: clang-cl: Alias /wd5054 to -Wno-deprecated-anon-enum-enum-conversion

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87368/new/ https://reviews.llvm.org/D87368 ___ cfe-c

[PATCH] D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew

hans added a comment. I'm not sure ignoring these is the right thing to do. Maybe they should be "Unsupported but parsed options" instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87372/new/ https://reviews.llvm.org/D87372 _

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/CMakeLists.txt:115 LINK_LIBS + clangdRemoteIndex clangdSupport kadircet wrote: > kbobyrev wrote

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

epastor added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2851 +// Parse MASM style pseudo prefixes. +// FIXME: This prefix should only be used for MASM, not for intel-syntax. +if (isParsingIntelSyntax()) { LiuChen3 wro

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aqjune added a comment. In D90275#2371813 , @jdoerfert wrote: > As noted by the GCC docs, it doesn't mean anything on a definition so that > you can safely merge TUs. I want us to forbid `leaf` on IR function > definitions for that reason, it would not m

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

uabelho added a comment. Hi! I found a new problem after this was turned on again in 51ff04567b2f . With opt -S -o - bbi-49235.ll -memoryssa -gvn -dse -verify-memoryssa I hit opt: ../lib/Analysis/MemorySSA.cpp:2063: void

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added a comment. In D86559#2371581 , @Mordante wrote: > In D86559#2371058 , @aaron.ballman > wrote: > >> In D86559#2369317 , @Mordante wrote: >> >>> Then me tr

[PATCH] D90570: [mips] Add a -mmips3d command line option to clang

atanasyan added a comment. My bad, I missed that you implemented passing the option to backend. Could you add some improvements to the patch? 1. As far as I know GCC does not accept `-mmips3d` option. It uses `-mips3d`. We need do the same. 2. Add test cases. For the reference you might take a

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

uabelho added a comment. In D87163#2373580 , @uabelho wrote: > Hi! > > I found a new problem after this was turned on again in 51ff04567b2f > . I wrote https://bugs.llvm.org/show_bug.cg

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302827. erichkeane added a comment. Added test for +lambda as @rsmith requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634 Files: clang/lib/Sema/SemaLambda.cpp clang/test/CodeGenCXX/lambda-conve

[PATCH] D87981: [X86] AMX programming model prototype.

pengfei added a comment. You may still need to change the format according to the Lint suggestions. Comment at: clang/lib/Headers/amxintrin.h:227 + +/// This is new intrinsic interface +typedef int _tile_data __attribute__((__vector_size__(1024), __aligned__(64)));

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3801 +/// error. +class UnresolvedUsingIfExistsDecl final : public NamedDecl { + UnresolvedUsingIfExistsDecl(DeclContext *DC, SourceLocation Loc, erik.pilkington wrote: > aaron.ba

[clang] 7e2edf9 - [compiler-rt][AIX]: Link compiler-rt profile library when -fprofile-generate is specified

Author: etiotto Date: 2020-11-04T09:54:54-05:00 New Revision: 7e2edf973b64b3554404e527f506ad5bc44d9cba URL: https://github.com/llvm/llvm-project/commit/7e2edf973b64b3554404e527f506ad5bc44d9cba DIFF: https://github.com/llvm/llvm-project/commit/7e2edf973b64b3554404e527f506ad5bc44d9cba.diff LOG:

[PATCH] D90763: Traverse-ignore explicit template instantiations

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Continue to dump and match on explicit template specializations, but omit explicit instantiation declarations

[clang-tools-extra] 45e0f65 - Add a floating-point suffix to silence warnings; NFC

Author: Aaron Ballman Date: 2020-11-04T10:09:51-05:00 New Revision: 45e0f651623d5507a0ea85533c960956573533d7 URL: https://github.com/llvm/llvm-project/commit/45e0f651623d5507a0ea85533c960956573533d7 DIFF: https://github.com/llvm/llvm-project/commit/45e0f651623d5507a0ea85533c960956573533d7.diff

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (P

[PATCH] D90570: [mips] Add a -mmips3d command line option to clang

michael-roe added a comment. Thanks! I agree with those changes; I'll implement them and then resubmit a patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90570/new/ https://reviews.llvm.org/D90570 _

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pratlucas requested review of this revision. Add support for the Neoverse V1 CPU to the ARM and AArch64 backends. This is based on patch

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:130 m(ObjcIvar) \ +m(HungarianNotation) \ njames93 wrote: > Is this line needed? I will remove it. Thank you. Comment at:

[clang-tools-extra] d1b2a52 - [clang-tidy] Add signal-handler-check for SEI CERT rule SIG30-C

Author: Balázs Kéri Date: 2020-11-04T16:42:30+01:00 New Revision: d1b2a523191e22806aee381d54015b94b9dcad7a URL: https://github.com/llvm/llvm-project/commit/d1b2a523191e22806aee381d54015b94b9dcad7a DIFF: https://github.com/llvm/llvm-project/commit/d1b2a523191e22806aee381d54015b94b9dcad7a.diff L

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1b2a523191e: [clang-tidy] Add signal-handler-check for SEI CERT rule SIG30-C (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D87449?vs=302778&id=302841#toc Repository: rG L

[PATCH] D90409: [HIP] Math Headers to use type promotion

yaxunl added a comment. In D90409#2372183 , @tra wrote: > In D90409#2372042 , @yaxunl wrote: > >>> Practically the behavior is the same since they all promote integer types >>> to double. This matches the C++ behav

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:939 +def warn_pragma_attribute_scalable_unused : Warning< + "ignoring scalable vectorize_width flag due to lack of target support">, + InGroup; From what I can see, th

[PATCH] D90766: [OpenCL] Support vec_step in C++ for OpenCL mode

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: dexonsmith, yaxunl. svenvh requested review of this revision. For compatibility with OpenCL C, enable the `vec_step` builtin in C++ for OpenCL mode. https://reviews.llvm.org/D90766 Files: clang/includ

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (P

[PATCH] D90766: [OpenCL] Support vec_step in C++ for OpenCL mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Good spot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90766/new/ https://reviews.llvm.org/D90766 ___ cfe-commits mailing li

[clang-tools-extra] ed424b4 - [clangd] Cleanup dependencies around RemoteIndex

Author: Kadir Cetinkaya Date: 2020-11-04T16:58:11+01:00 New Revision: ed424b42880e256f579d4bc9fb13d2156d8e8eb4 URL: https://github.com/llvm/llvm-project/commit/ed424b42880e256f579d4bc9fb13d2156d8e8eb4 DIFF: https://github.com/llvm/llvm-project/commit/ed424b42880e256f579d4bc9fb13d2156d8e8eb4.dif

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rGed424b42880e: [clangd] Cleanup dependencies around RemoteIndex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90746/new/ https://revi

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington marked 3 inline comments as done. erik.pilkington added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3801 +/// error. +class UnresolvedUsingIfExistsDecl final : public NamedDecl { + UnresolvedUsingIfExistsDecl(DeclContext *DC, SourceLocation Loc

[PATCH] D90767: Add new matchers for dependent names in templates

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersRef

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 302852. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added a comment. Got it. No worries :) Thanks @DmitryPolukhin for your help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936 ___ cfe-commits mailing list c

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3801 +/// error. +class UnresolvedUsingIfExistsDecl final : public NamedDecl { + UnresolvedUsingIfExistsDecl(DeclContext *DC, SourceLocation Loc, erik.pilkington wrote: > aaron.ba

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2851 +// Parse MASM style pseudo prefixes. +// FIXME: This prefix should only be used for MASM, not for intel-syntax. +if (isParsingIntelSyntax()) { epastor

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. In D90174#2371577 , @rjmccall wrote: > Hmm. Do we actually want this behavior of `fast` overriding pragmas? What > do other compilers do here? It might be reasonable to just treat this as a > bug. I think clang is just trying

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added a comment. Update for review comments. Comment at: clang/test/CodeGen/builtin_float_strictfp.c:1 +// RUN: %clang_cc1 -emit-llvm -triple x86_64-windows-pc -ffp-exception-behavior=maytrap -o - %s | FileCheck %s --check-prefixes=CHECK,FP16 +// RUN: %clang_cc1 -emit-llv

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall added a comment. Thank you! This design looks really good, just have some nits on comments, possible simplifications etc. (Sorry about the delay getting to these, on it now!) Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:268 + void checkAdjuster(std::st

[PATCH] D90486: [NewPM] Add OptimizationLevel param to TargetMachine::registerPassBuilderCallbacks()

ychen added inline comments. Comment at: llvm/lib/Target/BPF/BPFTargetMachine.cpp:129 bool DebugPassManager) { PB.registerPipelineStartEPCallback([=](ModulePassManager &MPM) { FunctionPassManager FPM(DebugPassManager);

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812 +EmptyDefaults.User = llvm::sys::Process::GetEnv("USER"); +if (!EmptyDefaults.User) + Empt

[PATCH] D90543: [Syntax] Start to move trivial Node class definitions to TableGen. NFC

eduucaldas added a comment. > Compared to Dmitri's prototype, Nodes.td looks more like a class hierarchy and > less like a grammar. (E.g. variants list the Alternatives parent rather than > vice versa). > e.g. we may introduce abstract bases like "loop" that the grammar doesn't > care about in

[PATCH] D79279: Add overloaded versions of builtin mem* functions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I went through all the comments here, plus looked at the code myself. I believe all of the comments by other reviewers have been fixed/answered acceptably. I don't have any additional

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (Per

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

njames93 updated this revision to Diff 302871. njames93 marked an inline comment as done. njames93 added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90552/new/ https://reviews.llvm.org/D90552 Files: clang-tools-extra/clang

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

njames93 added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812 +EmptyDefaults.User = llvm::sys::Process::GetEnv("USER"); +if (!EmptyDefaults.User) + EmptyDefaults.User = llvm::sys::Process::GetEnv("USEUSERNAMER"); sammcc

[PATCH] D90188: Add support for attribute 'using_if_exists'

Mordante added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5273 + namespace empty_namespace {}; + using empty_namespace::does_not_exist __attribute__((using_if_exists)); // no error! + erik.pilkington wrote: > aaron.ballman wrote: > > er

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane added a comment. Ping! This was requested in post-commit on the last patch, so I'm hoping it shouldn't be too controversial. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. In D90174#2373829 , @yaxunl wrote: > In D90174#2371577 , @rjmccall wrote: > >> Hmm. Do we actually want this behavior of `fast` overriding pragmas? What >> do other compilers do here? It

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (Per

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (P

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas added a comment. As we discussed offline we will probably not provide `replaceChildRange` in the public mutations API anymore. As a result I don't think we should be chaining changes related to `replaceChildRange` in this patch, and thus it should be ready to go. Repository: rG L

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas updated this revision to Diff 302879. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90240/new/ https://reviews.llvm.org/D90240 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Syn

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aaron.ballman added a comment. In D90221#2358469 , @aronsky wrote: > In D90221#2357060 , @aaron.ballman > wrote: > >> In D90221#2356110 , @aronsky wrote: >> >>> In D90221#

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302882. cchen edited the summary of this revision. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302884. cchen added a comment. Fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenM

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5273 + namespace empty_namespace {}; + using empty_namespace::does_not_exist __attribute__((using_if_exists)); // no error! + Mordante wrote: > erik.pilkington wrote: > > aa

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 302886. Conanap marked 5 inline comments as done. Conanap added a comment. Addressed some formatting problems as well as corrected incorrect arguments for Hi case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap marked an inline comment as done. Conanap added a comment. The unrelated change no longer shows as diff, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 __

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:617 + StringRef ParentName, unsigned LineNum, + bool Registered = true) const; /// brief Applies action \a Action on all registere

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 302894. Conanap marked an inline comment as done. Conanap added a comment. Updated a test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target

[PATCH] D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: ormris, MaskRay, ilya-biryukov. This will enable users to have a `B

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302898. cchen added a comment. Refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 ___ c

[clang] d0d43b5 - [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

Author: cchen Date: 2020-11-04T12:36:57-06:00 New Revision: d0d43b58b109c2945e30d0bfabe77d3dcf1e4ad5 URL: https://github.com/llvm/llvm-project/commit/d0d43b58b109c2945e30d0bfabe77d3dcf1e4ad5 DIFF: https://github.com/llvm/llvm-project/commit/d0d43b58b109c2945e30d0bfabe77d3dcf1e4ad5.diff LOG: [O

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d43b58b109: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts (authored by cchen). Repository: rG LLVM Github Mon

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc updated this revision to Diff 302902. mibintc added a comment. Add lit test case, based on test case in bug report Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90714/new/ https://reviews.llvm.org/D90714 Files: clang/lib/AST/MicrosoftMan

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc added a comment. In D90714#2372458 , @dblaikie wrote: > Test case? Thanks, done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90714/new/ https://reviews.llvm.org/D90714 ___

[PATCH] D90486: [NewPM] Add OptimizationLevel param to TargetMachine::registerPassBuilderCallbacks()

aeubanks added inline comments. Comment at: llvm/lib/Target/BPF/BPFTargetMachine.cpp:129 bool DebugPassManager) { PB.registerPipelineStartEPCallback([=](ModulePassManager &MPM) { FunctionPassManager FPM(DebugPassManager

  1   2   >