kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/CMakeLists.txt:115
LINK_LIBS
+ clangdRemoteIndex
clangdSupport
----------------
If we're moving `clangdRemoteIndex` to `clangDaemon` there is no need to link
`clangd` itself to `clangdRemoteIndex` anymore (in `tool/CMakeLists.txt`).
================
Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:30
RemoteIndexServiceProto
- )
----------------
I think changing it is inconsistent with LLVM CMake style. Having closing paren
on the same indentation level as the items is awkward but that's what we do :(
================
Comment at:
clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt:11
clangdSupport
- )
----------------
same here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90746/new/
https://reviews.llvm.org/D90746
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
