kadircet created this revision.
kadircet added reviewers: sammccall, kbobyrev.
Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny.
Herald added a project: clang.
kadircet requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
RemoteIndexClient implementations only depends on clangdSupport for
logging functionality and has no dependence on clangDeamon itself. This clears
out that link time dependency and enables depending on it in clangDeamon itself,
so that we can have other index implementations that makes use of the
RemoteIndex.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D90746
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/remote/CMakeLists.txt
clang-tools-extra/clangd/index/remote/Client.cpp
clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
Index: clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
@@ -6,6 +6,5 @@
UnimplementedClient.cpp
LINK_LIBS
- clangDaemon
clangdSupport
- )
+)
Index: clang-tools-extra/clangd/index/remote/Client.cpp
===================================================================
--- clang-tools-extra/clangd/index/remote/Client.cpp
+++ clang-tools-extra/clangd/index/remote/Client.cpp
@@ -11,7 +11,6 @@
#include "Client.h"
#include "Service.grpc.pb.h"
#include "index/Index.h"
-#include "index/Serialization.h"
#include "marshalling/Marshalling.h"
#include "support/Logger.h"
#include "support/Trace.h"
Index: clang-tools-extra/clangd/index/remote/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/CMakeLists.txt
@@ -18,16 +18,14 @@
RemoteIndexProto
RemoteIndexServiceProto
clangdRemoteMarshalling
-
protobuf
grpc++
- clangDaemon
clangdSupport
DEPENDS
RemoteIndexProto
RemoteIndexServiceProto
- )
+ )
add_subdirectory(marshalling)
add_subdirectory(server)
Index: clang-tools-extra/clangd/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/CMakeLists.txt
+++ clang-tools-extra/clangd/CMakeLists.txt
@@ -112,6 +112,7 @@
refactor/Tweak.cpp
LINK_LIBS
+ clangdRemoteIndex
clangdSupport
clangTidy
${LLVM_PTHREAD_LIB}
Index: clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
@@ -6,6 +6,5 @@
UnimplementedClient.cpp
LINK_LIBS
- clangDaemon
clangdSupport
- )
+)
Index: clang-tools-extra/clangd/index/remote/Client.cpp
===================================================================
--- clang-tools-extra/clangd/index/remote/Client.cpp
+++ clang-tools-extra/clangd/index/remote/Client.cpp
@@ -11,7 +11,6 @@
#include "Client.h"
#include "Service.grpc.pb.h"
#include "index/Index.h"
-#include "index/Serialization.h"
#include "marshalling/Marshalling.h"
#include "support/Logger.h"
#include "support/Trace.h"
Index: clang-tools-extra/clangd/index/remote/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/index/remote/CMakeLists.txt
+++ clang-tools-extra/clangd/index/remote/CMakeLists.txt
@@ -18,16 +18,14 @@
RemoteIndexProto
RemoteIndexServiceProto
clangdRemoteMarshalling
-
protobuf
grpc++
- clangDaemon
clangdSupport
DEPENDS
RemoteIndexProto
RemoteIndexServiceProto
- )
+ )
add_subdirectory(marshalling)
add_subdirectory(server)
Index: clang-tools-extra/clangd/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/CMakeLists.txt
+++ clang-tools-extra/clangd/CMakeLists.txt
@@ -112,6 +112,7 @@
refactor/Tweak.cpp
LINK_LIBS
+ clangdRemoteIndex
clangdSupport
clangTidy
${LLVM_PTHREAD_LIB}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
