atanasyan added a comment. My bad, I missed that you implemented passing the option to backend.
Could you add some improvements to the patch? 1. As far as I know GCC does not accept `-mmips3d` option. It uses `-mips3d`. We need do the same. 2. Add test cases. For the reference you might take a look at the -mdspr2 option in the following tests: test/Driver/mips-as.c test/Driver/mips-features.c test/Driver/mips-integrated-as.c 3. GCC defines `#define __mips3d 1` macro when the `-mips3d` option is provided. Take a look at the `MipsTargetInfo::getTargetDefines()` as a point for implementation. 4. As far as I remember MIPS 3D requires 64-bit floating-point registers. We need to check that 64-bit is enabled and show an error otherwise like GCC does. 3 and 4 need test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90570/new/ https://reviews.llvm.org/D90570 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
