[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12880 return Result.getValueOr(QualType()); } sammccall wrote: > Wouldn't we be better to handle undeduced type here rather than in the loop? > > Not sure if it practically matters,

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

eduucaldas updated this revision to Diff 293085. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. - `deepCopy` returns `nullptr` if copy code with Macro expansions. - `deepCopy` also deep copies the Tokens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons

mstorsjo created this revision. mstorsjo added reviewers: rnk, amccarth, thakis, hans. Herald added subscribers: llvm-commits, hiraditya. Herald added projects: clang, LLVM. mstorsjo requested review of this revision. When cross compiling with clang-cl, clang splits the INCLUDE env variable aroun

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:216 + Child = Child->getNextSibling()) +if (!Child->canModify()) + return false; Shouldn't we call canModifyAllDescendants recursively? Comment

[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12880 return Result.getValueOr(QualType()); } hokein wrote: > sammccall wrote: > > Wouldn't we be better to handle undeduced type here rather than in the loop? > > > > Not sure if

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:237 + +syntax::Node *clang::syntax::deepCopy(syntax::Arena &A, const Node *N) { + if (!canModifyAllDescendants(N)) We are ignoring nullability of pointers. The casting machiner

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

sammccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:963 }; +static_assert(llvm::PointerLikeTypeTraits::SpecializationForExpr, + "Specialization in TemplateBase.h must be seen here"); I think this is it: ``` // PointerLikeType

[PATCH] D88003: Fix typos in ASTMatchers.h

YangZhihui created this revision. YangZhihui added a reviewer: aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. YangZhihui requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88003 Files: clang/include/clang/ASTMatch

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

eduucaldas updated this revision to Diff 293089. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. Fix canModifyAllDescendants, add tests for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87749/new/ https://reviews.llvm.or

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

martong added a subscriber: steakhal. martong added a comment. Hi Valery, Together with @steakhal we have found a serious issue. The below code crashes if you compile with `-DEXPENSIVE_CHECKS`. The analyzer goes on an unfeasible path, the State has a contradiction. We think that `getRange(Sym("a

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett updated this revision to Diff 293090. DavidSpickett added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85118/new/ https://reviews.llvm.org/D85118 Files: clang/include/clang/Basic/arm_neon.td clang/test/CodeGen

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG349af8054218: [clang][AArch64] Correct return type of Neon vqmovun intrinsics (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CH

[clang] 349af80 - [clang][AArch64] Correct return type of Neon vqmovun intrinsics

Author: David Spickett Date: 2020-09-21T09:21:51+01:00 New Revision: 349af8054218017a2ac0c4bfeddd63e6ccbf4a21 URL: https://github.com/llvm/llvm-project/commit/349af8054218017a2ac0c4bfeddd63e6ccbf4a21 DIFF: https://github.com/llvm/llvm-project/commit/349af8054218017a2ac0c4bfeddd63e6ccbf4a21.diff

[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

dylanmckay added a comment. Hey @aykevl, could you please confirm that this patch looks okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86629/new/ https://reviews.llvm.org/D86629 ___ cfe-commits mail

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:152 + // Attribute relations to both their subject's and object's locations. + // See https://github.com/clangd/clangd/issues/510 for discussion of why. if (Index.Relations) { --

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein updated this revision to Diff 293094. hokein marked 2 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87080/new/ https://reviews.llvm.org/D87080 Files: clang/include/

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein added inline comments. Comment at: clang/include/clang/AST/Expr.h:963 }; +static_assert(llvm::PointerLikeTypeTraits::SpecializationForExpr, + "Specialization in TemplateBase.h must be seen here"); sammccall wrote: > I think this is it: > ```

[PATCH] D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88004 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

awarzynski added a comment. Thanks for reviewing @sanwou01 ! No new comments, so I'll submit as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87816/new/ https://reviews.llvm.org/D87816 ___ cfe-commit

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

mstorsjo created this revision. mstorsjo added reviewers: rnk, amccarth. Herald added a project: clang. mstorsjo requested review of this revision. GCC 8 changed behaviour wrt this, and made it consistent for cross compilation cases. While it's a change, it's a more sensible behaviour going forwa

[clang] 4eae6fc - [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

Author: Andrzej Warzynski Date: 2020-09-21T09:41:39+01:00 New Revision: 4eae6fc95f95563a73a510a8b09cfce01004930a URL: https://github.com/llvm/llvm-project/commit/4eae6fc95f95563a73a510a8b09cfce01004930a DIFF: https://github.com/llvm/llvm-project/commit/4eae6fc95f95563a73a510a8b09cfce01004930a.d

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

This revision was automatically updated to reflect the committed changes. Closed by commit rG4eae6fc95f95: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87

[PATCH] D86077: [clangd] Add a way for exporting memory usage metrics

kadircet planned changes to this revision. kadircet added a comment. In D86077#2281218 , @sammccall wrote: > Just for the record, as I think Kadir and Adam are both aware... > > We discussed making this a bit richer and less reliant on static state. > We'd

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko added a comment. In D82445#2284680 , @martong wrote: > Hi Valery, > > Together with @steakhal we have found a serious issue. > The below code crashes if you compile with `-DEXPENSIVE_CHECKS`. > The analyzer goes on an unfeasible path, the State

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

eduucaldas updated this revision to Diff 293101. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87749/new/ https://reviews.llvm.org/D87749 Files: clang/include/clang/Tooling/Syntax/BuildTree.h clang/lib/Tooling/Syn

[PATCH] D87785: [analyzer][StdLibraryFunctionsChecker] Fix a BufferSize constraint crash

martong abandoned this revision. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:694 // execution continues on a code whose behaviour is undefined. assert(SuccessSt); NewState = SuccessSt; --

[clang] 4a5cc38 - [SyntaxTree][Synthesis] Implement `deepCopy`

Author: Eduardo Caldas Date: 2020-09-21T09:27:15Z New Revision: 4a5cc389c51d267f39286a9a8c58c32f758b9d4b URL: https://github.com/llvm/llvm-project/commit/4a5cc389c51d267f39286a9a8c58c32f758b9d4b DIFF: https://github.com/llvm/llvm-project/commit/4a5cc389c51d267f39286a9a8c58c32f758b9d4b.diff LOG

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a5cc389c51d: [SyntaxTree][Synthesis] Implement `deepCopy` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

baloghadamsoftware updated this revision to Diff 293111. baloghadamsoftware added a comment. Tests updated: some execution paths merged by refactoring assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 Files: clang/include/clang/Stat

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Forgot to mention, 3% memory saving is huge, way more than I expected (was mostly just hoping for no regression). Nice work! Comment at: clang/include/clang/AST/Templa

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:205 + if (L->canModify()) +syntax::FactoryImpl::setCanModify(Leaf); + eduucaldas wrote: > gribozavr2 wrote: > > Since we are creating new leaves, why prohibit their mutation

[PATCH] D88009: [AArch64] Fix return type of Neon scalar comparison intrinsics

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. The following should have unsigned return types but were signed: vceqd_s64 vceqzd_s64 vcged_s64 vcgezd_s64 vcgtd_s6

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

mati865 added a comment. LGTM Confirmed that GCC 9 still adds `.exe`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88005/new/ https://reviews.llvm.org/D88005 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D88009: [AArch64] Fix return type of Neon scalar comparison intrinsics

DavidSpickett added a reviewer: efriedma. DavidSpickett added a comment. Links instead of searching the document: https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vceqd_s64 https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?s

[PATCH] D88013: [AArch64] Correct parameter type for Neon scalar shift intrinsics

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. In the following intrinsics the shift amount (parameter 2) should be signed. vqshlh_u16 vqshls_u32 vqshld_u64 vq

[PATCH] D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins

nemanjai accepted this revision. nemanjai added a comment. The nits can be addressed when committing the code. LGTM otherwise. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1452 // Vector Extend Sign -def VEXTSB2W : VX_VT5_EO5_VB5<1538, 16, "vextsb2w", []>; -def VEXTS

[PATCH] D88013: [AArch64] Correct parameter type for Neon scalar shift intrinsics

DavidSpickett added a reviewer: efriedma. DavidSpickett added a comment. Links to save combing the document: https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqshlh_u16 https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?searc

[clang] af29591 - [AST] Reduce the size of TemplateArgumentLocInfo.

Author: Haojian Wu Date: 2020-09-21T13:08:53+02:00 New Revision: af29591650c43bd3bdc380c9d47b8bfd0f1664a2 URL: https://github.com/llvm/llvm-project/commit/af29591650c43bd3bdc380c9d47b8bfd0f1664a2 DIFF: https://github.com/llvm/llvm-project/commit/af29591650c43bd3bdc380c9d47b8bfd0f1664a2.diff LO

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGaf29591650c4: [AST] Reduce the size of TemplateArgumentLocInfo. (authored by hokein). Changed prior to comm

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan added a comment. Ping. Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 293139. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.tx

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware added a comment. Prerequeisite patch is committed, the check is tested now on the //LLVM Project//. @lebedev.ri, @aaron.ballman can I recommit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 __

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. In D71199#2285076 , @baloghadamsoftware wrote: > Prerequeisite patch is committed, the check is tested now on the //LLVM > Project//. @le

[clang] 41a8bba - Fix buildbot.

Author: Haojian Wu Date: 2020-09-21T13:40:00+02:00 New Revision: 41a8bbad5e52a94a485c5bfe3d7871784fe6d8ed URL: https://github.com/llvm/llvm-project/commit/41a8bbad5e52a94a485c5bfe3d7871784fe6d8ed DIFF: https://github.com/llvm/llvm-project/commit/41a8bbad5e52a94a485c5bfe3d7871784fe6d8ed.diff LO

[PATCH] D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG87f0b51d68de: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

martong created this revision. martong added reviewers: vsavchenko, steakhal, NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a revi

[clang] 87f0b51 - [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration

Author: Eduardo Caldas Date: 2020-09-21T11:45:15Z New Revision: 87f0b51d68de40e7106be89d934b5191d983e3d5 URL: https://github.com/llvm/llvm-project/commit/87f0b51d68de40e7106be89d934b5191d983e3d5 DIFF: https://github.com/llvm/llvm-project/commit/87f0b51d68de40e7106be89d934b5191d983e3d5.diff LOG

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

martong added a comment. We came up with a quick fix, let us know what you think: https://reviews.llvm.org/D88019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82445/new/ https://reviews.llvm.org/D82445

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

martong added a comment. @steakhal, thank you for your time and huge effort in debugging this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88019/new/ https://reviews.llvm.org/D88019 ___ cfe-commits mai

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

vsavchenko added a comment. I came up with exactly the same fix! Great job! I just wanted to refactor it and not having if (New.isEmpty()) // this is infeasible assumption return nullptr; ProgramStateRef NewState = setConstraint(St, Sym, New); return trackNE(NewState, Sym, Int, A

[clang-tools-extra] 4fc0214 - [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

Author: Adam Balogh Date: 2020-09-21T14:42:58+02:00 New Revision: 4fc0214a10140fa77449677e8094ea22d3d17701 URL: https://github.com/llvm/llvm-project/commit/4fc0214a10140fa77449677e8094ea22d3d17701 DIFF: https://github.com/llvm/llvm-project/commit/4fc0214a10140fa77449677e8094ea22d3d17701.diff L

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc0214a1014: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

vsavchenko added a comment. After this "accepted" and a huge thank you 😄 Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1350-1371 ProgramStateRef trackEQ(ProgramStateRef State, SymbolRef Sym, const llvm::APSInt &Int,

[PATCH] D88021: [clang] Fix a misleading variable name. NFC.

ikudrin created this revision. ikudrin added reviewers: thakis, hans, MaskRay. ikudrin added projects: LLVM, clang. ikudrin requested review of this revision. The variable is true when frame pointers should be omitted in leaf functions, not kept. Repository: rG LLVM Github Monorepo https://r

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

arsenm added a comment. I assume this makes 1f4e7463b5e3ff654c84371527767830e51db10d redundant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri added a comment. In D87972#2285176 , @arsenm wrote: > I assume this makes 1f4e7463b5e3ff654c84371527767830e51db10d > > redundant? Yes, see `llvm/lib/Target/AMDGPU/AMDGPUTar

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

xbolva00 added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:2 +// RUN: %clang -O1 -fexperimental-new-pass-manager -fno-unroll-loops -S -o - %s -emit-llvm | FileCheck %s -check-prefixes=CHECK-ALL,CHECK-NEWPM +// RUN: %clang -O1 -fno-experimental-new-pass-manager

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

chill added a comment. Some tests started failing: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/9071 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004 __

[PATCH] D88003: Fix typos in ASTMatchers.h

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for the fixes! Please regenerate the AST matcher documentation by running `clang/docs/tools/dump_ast_matchers.py` so that the public documentation picks up the typo fixes as well. Repository: rG LLVM Gith

[PATCH] D87942: [Analyzer] GNU named variadic macros in Plister

chrish_ericsson_atx updated this revision to Diff 293154. chrish_ericsson_atx added a comment. Addressed feedback from @Szelethus Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87942/new/ https://reviews.llvm.org/D87942 Files: clang/lib/StaticAna

[PATCH] D87942: [Analyzer] GNU named variadic macros in Plister

chrish_ericsson_atx marked 2 inline comments as done. chrish_ericsson_atx added a comment. Thanks for the quick feedback, Kristof! I changed the macro to be just a decrement operator, and triggered DBZ with that. Added the checks as you suggested. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. @JakeMerdichAMD this has caused a regression https://bugs.llvm.org/show_bug.cgi?id=47589 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388 ___

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2996 Line->Tokens.back().Tok->MustBreakBefore = true; +Line->Tokens.back().Tok->MustBreakAlignBefore = true; MustBreakBeforeNextToken = false; If the line end

[PATCH] D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. Thanks for open coding. Aside from Nemanja's nits, I believe all my concerns have been addressed. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87394/new/ https://reviews.llvm.org/

[PATCH] D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM

amyk updated this revision to Diff 293161. amyk added a comment. Updated identation/formatting of code in `CGExprScalar.cpp` and `altivec.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87910/new/ https://reviews.llvm.org/D87910 Files: clang/i

[PATCH] D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`

eduucaldas updated this revision to Diff 293163. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. - Answer Review - Change names in `generateAllTreesWithShape` - `auto x = vector()` -> `vector x;` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87914/new/ https://reviews.llvm.org/D87914

[PATCH] D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`

eduucaldas updated this revision to Diff 293167. eduucaldas added a comment. Comment `generateAllTreesWithShape` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87779/new/ https://reviews.llvm.org/D87779 Files: clang/lib/Tooling/Syntax/Tree.cpp

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

martong added a comment. Thanks for the quick review! I updated according to your suggestion, so we avoid the same pattern. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1350-1371 ProgramStateRef trackEQ(ProgramStateRef State, SymbolRef Sym,

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

martong updated this revision to Diff 293168. martong marked an inline comment as done. martong added a comment. - Avoid same pattern when checking whether the assumption is infeasible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88019/new/ https:

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Amazing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88019/new/ https://reviews.llvm.org/D88019 _

[clang] 7c4575e - [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent

Author: Raphael Isemann Date: 2020-09-21T16:41:00+02:00 New Revision: 7c4575e15f065312ad40ebe0d1ec1e1ffa4c6628 URL: https://github.com/llvm/llvm-project/commit/7c4575e15f065312ad40ebe0d1ec1e1ffa4c6628 DIFF: https://github.com/llvm/llvm-project/commit/7c4575e15f065312ad40ebe0d1ec1e1ffa4c6628.dif

[PATCH] D87619: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c4575e15f06: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] 699089f - [AIX][Clang][Driver] Add handling of nostartfiles option

Author: David Tenty Date: 2020-09-21T10:42:46-04:00 New Revision: 699089f2a9702baa987dc2dbe915a2c845c7027f URL: https://github.com/llvm/llvm-project/commit/699089f2a9702baa987dc2dbe915a2c845c7027f DIFF: https://github.com/llvm/llvm-project/commit/699089f2a9702baa987dc2dbe915a2c845c7027f.diff L

[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option

This revision was automatically updated to reflect the committed changes. Closed by commit rG699089f2a970: [AIX][Clang][Driver] Add handling of nostartfiles option (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87904/new/ http

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

hliao added a comment. In D87972#2284096 , @lebedev.ri wrote: > In D87972#2284064 , @xbolva00 wrote: > >> In D87972#2284060 , @MaskRay wrote: >> >>> I have tested this patch

[PATCH] D88024: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for `createTree`

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. I also assured that there are no other functions unnecessarily using std::vector as argument. Repositor

[clang] 0c4f91f - [analyzer][solver] Fix issue with symbol non-equality tracking

Author: Gabor Marton Date: 2020-09-21T16:59:18+02:00 New Revision: 0c4f91f84b2efe8975848a7a13c08d7479abe752 URL: https://github.com/llvm/llvm-project/commit/0c4f91f84b2efe8975848a7a13c08d7479abe752 DIFF: https://github.com/llvm/llvm-project/commit/0c4f91f84b2efe8975848a7a13c08d7479abe752.diff

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c4f91f84b2e: [analyzer][solver] Fix issue with symbol non-equality tracking (authored by martong). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

jasonliu added a comment. I think it would help the review if we could put the NFC portion(e.g. TypeSize -> StorageUnitSize) to a new patch, and give some rationale about the NFC change. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:624 /// a byte, but larger units are

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2996 Line->Tokens.back().Tok->MustBreakBefore = true; +Line->Tokens.back().Tok->MustBreakAlignBefore = true; MustBreakBeforeNextToken = false; MyDeveloperDay

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

martong added a reviewer: vsavchenko. martong added a comment. Adding Valeriy as a reviewer. He's been working with the solver recently, so his insights might be really useful here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 __

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

baloghadamsoftware updated this revision to Diff 293183. baloghadamsoftware added a comment. New test cases added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76604/new/ https://reviews.llvm.org/D76604 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp clang/lib/Stati

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

vsavchenko added a comment. Hi @baloghadamsoftware Great job! I also wanted to support more operations for range-based logic. However, I don't think that this is the right place to make this kind of assumptions. A couple months ago, I added the `SymbolicRangeInferrer` component to aggregate

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

amccarth accepted this revision. amccarth added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70378/new/ https://reviews.llvm.org/D70378 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. I'd be very surprised if any of the tests included in this change pass with that line commented it's meant so that things like #if and #else properly separate alignment after the first preprocessor run, where the whitespace manager doesn't have the full conte

[PATCH] D87949: [ThinLTO] Option to bypass function importing.

mtrofin updated this revision to Diff 293189. mtrofin marked 2 inline comments as done. mtrofin added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87949/new/ https://reviews.llvm.org/D87949 Files: clang/include/clang/CodeGen

[PATCH] D88021: [clang] Fix a misleading variable name. NFC.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! (I did notice this but I forgot to update it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88021/new/ https://reviews.llvm.org/D

[PATCH] D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88002/new/ https://reviews.llvm.org/D88002 ___ cfe-com

[clang] 474d527 - [clang] Fix a misleading variable name. NFC.

Author: Igor Kudrin Date: 2020-09-21T22:59:34+07:00 New Revision: 474d527c28f4e88ffda7b82e93e351aec2602380 URL: https://github.com/llvm/llvm-project/commit/474d527c28f4e88ffda7b82e93e351aec2602380 DIFF: https://github.com/llvm/llvm-project/commit/474d527c28f4e88ffda7b82e93e351aec2602380.diff L

[PATCH] D88021: [clang] Fix a misleading variable name. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG474d527c28f4: [clang] Fix a misleading variable name. NFC. (authored by ikudrin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88021/new/ https://reviews.l

[clang] f91f28c - [Sema] Split special builtin type lookups into a separate function

Author: Raul Tambre Date: 2020-09-21T19:12:29+03:00 New Revision: f91f28c350df6815d37c521e8f3dc0641a3ca467 URL: https://github.com/llvm/llvm-project/commit/f91f28c350df6815d37c521e8f3dc0641a3ca467 DIFF: https://github.com/llvm/llvm-project/commit/f91f28c350df6815d37c521e8f3dc0641a3ca467.diff L

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

This revision was automatically updated to reflect the committed changes. tambre marked an inline comment as done. Closed by commit rGf91f28c350df: [Sema] Split special builtin type lookups into a separate function (authored by tambre). Changed prior to commit: https://reviews.llvm.org/D87983?v

[PATCH] D87983: [Sema] Split special builtin type lookups into a separate function

tambre added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:924 +void Sema::LookupNecessaryTypesForBuiltin(Scope *S, unsigned ID) { + if (getLangOpts().ObjC && ID == Builtin::BIobjc_msgSendSuper) +LookupPredefedObjCSuperType(*this, S); rjmccall w

[PATCH] D87923: [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87923/new/ https://reviews.llvm.org/D87923 _

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 293195. tianshilei1992 added a comment. Continued to fix the case `target_parallel_for_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clan

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

MaskRay added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87737/new/ https://reviews.llvm.org/D87737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 6950db3 - The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled.

Author: Sriraman Tallam Date: 2020-09-21T10:00:12-07:00 New Revision: 6950db36d33d85d18e3241ab6c87494c05ebe0fb URL: https://github.com/llvm/llvm-project/commit/6950db36d33d85d18e3241ab6c87494c05ebe0fb DIFF: https://github.com/llvm/llvm-project/commit/6950db36d33d85d18e3241ab6c87494c05ebe0fb.dif

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG6950db36d33d: The wrong placement of add pass with optimizations led to -funique-internal… (authored by tmsriram). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to c

[PATCH] D88034: [SyntaxTree][Synthesis] Implement `deepCopyExpandingMacros`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88034 Files: clang/include/clang/Tooling/Syntax/BuildTree.h clang/lib/Tooling

  1   2   >