tambre added inline comments.
================ Comment at: clang/lib/Sema/SemaLookup.cpp:924 +void Sema::LookupNecessaryTypesForBuiltin(Scope *S, unsigned ID) { + if (getLangOpts().ObjC && ID == Builtin::BIobjc_msgSendSuper) + LookupPredefedObjCSuperType(*this, S); ---------------- rjmccall wrote: > I'm pretty sure this builtin only exists in ObjC mode, so there's no need to > separately check the language mode. (Even if you did want to check it, it > would be better to check the builtin mode first, as that's a very trivial > check.) Fixed, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87983/new/ https://reviews.llvm.org/D87983 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits