kadircet planned changes to this revision.
kadircet added a comment.

In D86077#2281218 <https://reviews.llvm.org/D86077#2281218>, @sammccall wrote:

> Just for the record, as I think Kadir and Adam are both aware...
>
> We discussed making this a bit richer and less reliant on static state.
> We'd build a tree-shaped profile by passing a tree-builder recursively into 
> various components.
> Then the metrics would be exported at the top level, but we'd also want to 
> expose it via debugging actions. (The tree edges from e.g. dynamic index to 
> individual files would probably be optional - collapsed for metrics but 
> present for debugging)
>
> LMK if I have this wrong and you want to move forward with a simpler approch.

No that aligns perfectly with what I have in my mind as well. I just didn't 
have time to get back to this yet. Thanks a lot for summarizing offline 
discussions here!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86077/new/

https://reviews.llvm.org/D86077

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D86077: [clangd] A... Sam McCall via Phabricator via cfe-commits
    • [PATCH] D86077: [clan... Kadir Cetinkaya via Phabricator via cfe-commits

Reply via email to