jasonliu added a comment. I think it would help the review if we could put the NFC portion(e.g. TypeSize -> StorageUnitSize) to a new patch, and give some rationale about the NFC change.
================ Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:624 /// a byte, but larger units are used if IsMsStruct. unsigned char UnfilledBitsInLastUnit; + /// LastBitfieldStorageUnitSize - If IsMsStruct, represents the size of the ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits