[clang] a52aea0 - Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

Author: Logan Smith Date: 2020-07-27T08:37:01-07:00 New Revision: a52aea0ba624fcf46602bff8463b7b831e87ba55 URL: https://github.com/llvm/llvm-project/commit/a52aea0ba624fcf46602bff8463b7b831e87ba55 DIFF: https://github.com/llvm/llvm-project/commit/a52aea0ba624fcf46602bff8463b7b831e87ba55.diff L

[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

This revision was automatically updated to reflect the committed changes. Closed by commit rGa52aea0ba624: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that… (authored by logan-5). Changed prior to commit: https://reviews.llvm.org/D84554?vs=280564&id=280933#toc Re

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl marked 4 inline comments as done. yaxunl added a comment. In D84364#2170769 , @tra wrote: > In D84364#2170244 , @tra wrote: > > > I'm going to try the patch on our CUDA code and see how it fares. Stay > > tu

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

martong added a comment. In D83174#2158275 , @aaron.ballman wrote: > In D83174#2156454 , @v.g.vassilev > wrote: > > > >> Also, I would like to add that the current test present in this diff > > >> does not fail i

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl updated this revision to Diff 280938. yaxunl marked 2 inline comments as done. yaxunl retitled this revision from "[CUDA][HIP] Defer all diagnostics for host device functions" to "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions". yaxunl edited the summary of

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. AFAIK, BuiltinBug is deprecated and we should be using BugType anyway. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84564/new/ https://reviews.llvm.org/D84564 _

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

aaron.ballman accepted this revision. aaron.ballman added a comment. The changes LGTM but it seems like there may be some formatting issues with the patch (or the lint tool is acting up). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84656/new/ ht

[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8000 return ExprWithCleanups::CleanupObject(cast(*R)); + } else if (auto *ICE = From.dyn_cast()) { +if (Expected R = Import(ICE)) I am not sure how this hunk is related to `os_lo

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

aaron.ballman added a comment. I think these changes are going in the right direction (and I agree with the feedback from Erich). Thank you for looking into this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84658/new/ https://reviews.llvm.org/D8

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2176014 , @bkramer wrote: > Nice, those relocations have annoyed me for years. I'm worried about whether > the way you're accessing StaticDiagInfoDescriptionStringTable might be > undefined behavior. I won't block this

[PATCH] D83817: [clangd] Add option to use remote index as static index

thakis added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ +#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMTE@ hans wrote: > I'm guessing this should be @CLANGD_ENABLE_REMOTE@ > The gn build w

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked 2 inline comments as done. alanphipps added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1368 CaseDest = createBasicBlock("sw.bb"); - EmitBlockWithFallThrough(CaseDest, &S); + EmitBlockWithFallThrough(CaseDest, CurCase); }

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

JDevlieghere added inline comments. Comment at: clang/include/clang/Driver/Options.td:693 def e : JoinedOrSeparate<["-"], "e">, Group; +def external_dsym_dir : JoinedOrSeparate<["-"], "external-dsym-dir">, + Flags<[DriverOption, RenderAsInput]>, Could we drop t

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 280945. dang added a comment. Update with latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/lib/Fronten

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

dang updated this revision to Diff 280946. dang added a comment. Update with latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/ https://reviews.llvm.org/D83298 Files: clang/include/clang/Driver/Options.td clang/lib/Fronte

[PATCH] D84186: Convert Analyzer option string based options to new option parsing system

dang updated this revision to Diff 280948. dang added a comment. Update with latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84186/new/ https://reviews.llvm.org/D84186 Files: clang/include/clang/Driver/Options.td clang/lib/Fronten

[PATCH] D84668: Port TargetOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84190 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84668 Files: clang/include/clang

[PATCH] D84669: Port CodeGenOpts simple string flags to new option parsing system

dang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84668 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84669 Files: clang/include/clang/Basic/CodeGenOptions.h clang/in

[PATCH] D84670: Port HeaderSearch simple string options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84669 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84670 Files: clang/include/clang

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, mgrang. Herald added projects: clang, LLVM. Depends on D84670 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84671 F

[PATCH] D84672: Port PreprocessorOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84671 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84672 Files: clang/include/clang

[PATCH] D84673: Port DiagnosticOpts to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. DiagnosticOpts are special because the parsing is code is shared with the driver. To ensure the code can still be shared this commit le

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D84673 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84674 Files:

[PATCH] D84675: Streamline MarhsallingInfoFlag description

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, dexonsmith, aheejin. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This replaces the existing `MarshallingInfoFlag` and `IsNegative` with simpler

[PATCH] D84676: Add new diagnostic for invalid value provided for enum-based option

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This adds a more precise diagnostics for options that have a well defined set of acceptable values. Depends on D84675

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 created this revision. Jac1494 added a reviewer: rsmith. Jac1494 added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes false line number in a function definition with "void" parameter. For more details PR46417. Repository: rG LLVM Github Monorepo https://r

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support

hfinkel accepted this revision as: hfinkel. hfinkel added a comment. This revision is now accepted and ready to land. LGTM. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83915/new/ https://reviews.llvm.org/D83915 _

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. This LGTM. Thanks for addressing the comments Baptiste. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang marked an inline comment as done. dang added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signe

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); + Analyzer->Handler.handleMutexNotH

[PATCH] D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given."

dokyungs updated this revision to Diff 280981. dokyungs added a comment. Add '-fno-builtin-bcmp' and a corresponding test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files: clang/lib/Driver/Sani

[PATCH] D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given."

dokyungs updated this revision to Diff 280982. dokyungs added a comment. Disable noasan-bcmp.test on darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files: clang/lib/Driver/SanitizerArgs.cpp com

[PATCH] D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given."

morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1465 + let Spellings = [Clang<"msp430_builtin">]; + let Documentation = [Undocumented]; +} No new, undocumented attributes, please. Or is this attribute not expected to be used

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

rjmccall added a comment. Is there only one special calling convention, or is there any chance that different builtin functions would use different conventions? I don't have a problem with introducing a new convention even if it's only used for "builtin" functions. Repository: rG LLVM Githu

[clang] b52b2e1 - Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given."

Author: Dokyung Song Date: 2020-07-27T18:27:49Z New Revision: b52b2e1c188072e3cbc91500cfd503fb26d50ffc URL: https://github.com/llvm/llvm-project/commit/b52b2e1c188072e3cbc91500cfd503fb26d50ffc DIFF: https://github.com/llvm/llvm-project/commit/b52b2e1c188072e3cbc91500cfd503fb26d50ffc.diff LOG:

[PATCH] D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given."

This revision was automatically updated to reflect the committed changes. Closed by commit rGb52b2e1c1880: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like… (authored by dokyungs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

dblaikie added a comment. In D81865#2176148 , @froydnj wrote: > In D81865#2176014 , @bkramer wrote: > > > Nice, those relocations have annoyed me for years. I'm worried about > > whether the way you're accessing St

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

aaron.ballman added a comment. In D84602#2176584 , @rjmccall wrote: > I don't have a problem with introducing a new convention even if it's only > used for "builtin" functions. To be clear, I also don't have a problem with it, but if users aren't suppos

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280993. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve all but 1 post-LGTM comment and rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://re

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev marked an inline comment as not done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:203 + TracerStream.reset(); + llvm::errs() << "Error while opening trace file " << TraceFile << ": " + <<

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280997. kbobyrev marked an inline comment as done. kbobyrev added a comment. Switch from llvm::errs() to elog() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files:

[clang-tools-extra] 731043c - [clangd] Add more logs and attach tracers to remote index server routines

Author: Kirill Bobyrev Date: 2020-07-27T20:45:18+02:00 New Revision: 731043c0c494672efe1eeea9ee0f0c7788813dea URL: https://github.com/llvm/llvm-project/commit/731043c0c494672efe1eeea9ee0f0c7788813dea DIFF: https://github.com/llvm/llvm-project/commit/731043c0c494672efe1eeea9ee0f0c7788813dea.diff

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

This revision was automatically updated to reflect the committed changes. Closed by commit rG731043c0c494: [clangd] Add more logs and attach tracers to remote index server routines (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); + Analyzer->Handler.handleMutexNotHe

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

phosek created this revision. phosek added reviewers: smeenai, compnerd, mehdi_amini. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antia

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek marked 4 inline comments as done. phosek added inline comments. Comment at: mlir/examples/standalone/CMakeLists.txt:35 +endif() + include(TableGen) stephenneuendorffer wrote: > mehdi_amini wrote: > > mehdi_amini wrote: > > > I am a bit unsure that it is d

[clang] 05ad8e9 - [AIX] Implement AIX special alignment rule about double/long double

Author: Xiangling Liao Date: 2020-07-27T15:13:03-04:00 New Revision: 05ad8e942996f36cc694478542ccd84aa5bbb80f URL: https://github.com/llvm/llvm-project/commit/05ad8e942996f36cc694478542ccd84aa5bbb80f DIFF: https://github.com/llvm/llvm-project/commit/05ad8e942996f36cc694478542ccd84aa5bbb80f.diff

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

This revision was automatically updated to reflect the committed changes. Closed by commit rG05ad8e942996: [AIX] Implement AIX special alignment rule about double/long double (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

riccibruno updated this revision to Diff 281019. riccibruno marked 2 inline comments as done. riccibruno added a comment. Remove a few missed `getPackingKind`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84306/new/ https://reviews.llvm.org/D84306

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

grokos added a comment. In D84422#2173500 , @jdenny wrote: > I've added a comment to the runtime code that performs the check. As you can > see, the check is performed regardless. It's just a question of whether the > runtime treats it as an error. I

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny added a comment. In D84422#2176802 , @grokos wrote: > In D84422#2173500 , @jdenny wrote: > > > I've added a comment to the runtime code that performs the check. As you > > can see, the check is performed re

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

riccibruno added a comment. In D84656#2176139 , @aaron.ballman wrote: > The changes LGTM but it seems like there may be some formatting issues with > the patch (or the lint tool is acting up). Looks like the bot is right this time. Thanks! Repository

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84697 Files: clang-tools-

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev updated this revision to Diff 281027. kbobyrev added a comment. Don't use llvm::toString in elog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84697/new/ https://reviews.llvm.org/D84697 Files: clang-tools-extra/clangd/benchmarks/IndexBe

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 281035. Conanap added a comment. Included sext test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files: clang/lib/Headers/altivec.h clang/test/CodeGen/buil

[libunwind] 145acac - [libunwind] Remove old keymgr related logic

Author: Louis Dionne Date: 2020-07-27T16:12:59-04:00 New Revision: 145acacaea1d7fb4ffc055a3e92ee8fee7c58634 URL: https://github.com/llvm/llvm-project/commit/145acacaea1d7fb4ffc055a3e92ee8fee7c58634 DIFF: https://github.com/llvm/llvm-project/commit/145acacaea1d7fb4ffc055a3e92ee8fee7c58634.diff

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 281038. zzheng marked 7 inline comments as done. zzheng edited the summary of this revision. zzheng added a comment. Addressed styling & code clarity issues. Fixed wrong opcode for RV64. Unlike x18 on AArch64, there's no register that should normally be res

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

sammccall added a comment. Thanks for sending this... after looking at the examples and thinking again about our conversation I may have shifted a bit :-\ I think it's important *log() should only be used for messages intended to be logged! (i.e. read later as a sequence of log messages). We ha

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng marked 2 inline comments as done. zzheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:33-37 + std::vector &CSI = MF.getFrameInfo().getCalleeSavedInfo(); + if (std::none_of(CSI.begin(), CSI.end(), [](CalleeSavedInfo &CSR) { +retu

[PATCH] D84197: [PowerPC][Power10] 128-bit Vector String Isolate instruction definitions and MC Tests

Conanap updated this revision to Diff 281042. Conanap added a comment. Recovered accidentally deleted test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84197/new/ https://reviews.llvm.org/D84197 Files: llvm/lib/Target/PowerPC/PPCInstrPre

[PATCH] D84473: Dump Accumulator

kazu marked an inline comment as done. kazu added inline comments. Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// mtrofin wrote: > I'd clarify that transferring the data from pre-link thinlto to pos

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

riccibruno updated this revision to Diff 281044. riccibruno marked 3 inline comments as done. riccibruno added a comment. Address Erich's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84658/new/ https://reviews.llvm.org/D84658 Files: c

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: clang/lib/AST/Decl.cpp:2032 + // additional complexity needed to prevent this is not worthwhile. + OS << (Policy.MSVCFormatting ? '`' : '(') + << (IsAnonymousStructOrUnion ? "anonymou

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

dsanders marked an inline comment as done. dsanders added inline comments. Comment at: clang/include/clang/Driver/Options.td:693 def e : JoinedOrSeparate<["-"], "e">, Group; +def external_dsym_dir : JoinedOrSeparate<["-"], "external-dsym-dir">, + Flags<[DriverOption, RenderAsIn

[PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

efriedma created this revision. efriedma added reviewers: sdesmalen, SjoerdMeijer, t.p.northover, cameron.mcinally. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. fptosi/fptoui have similar, but not identical, semantics. In particular, the behav

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang added a comment. I put everything together in a single diff so that it is easier to get the whole idea. The change itself is too big to go in as a single diff, and I'd like to get inputs on how to split it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D84473: Dump Accumulator

mtrofin added inline comments. Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// kazu wrote: > mtrofin wrote: > > I'd clarify that transferring the data from pre-link thinlto to post-link > > isn't su

[PATCH] D84473: Dump Accumulator

mtrofin accepted this revision. mtrofin added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 _

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl added a comment. In D80858#2171266 , @hliao wrote: > We may try to solve the issue without RDC firstly, where we don't need to > change that static variable name (if the runtime maintains the device > binaries correctly.) We only need to ensure th

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

riccibruno added inline comments. Comment at: clang/test/Sema/void-argument.cpp:1 +// RUN: not %clang_cc1 %s 2>&1 | FileCheck %s + These kinds of tests are typically done with a `-verify` test. See the other tests in `Sema/` for examples. Repository: rG LLVM

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks, this is a great idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 __

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

tra added a comment. It's a good point. Perhaps this is one of the cases where we should *not* follow nvcc. We can't have our cake (preserve static behavior) and eat it (treat it as non-static in case something on the host side may decide to use an API which uses symbol names). Something's got

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 281062. zzheng added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.org/D84414 Files: clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolChain

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:173 + Arg *A = Args.getLastArg(options::OPT_g_Group); + if (A && !A->getOption().matches(options::OPT_g0) && + !A->getOption().matches(options::OPT_gstabs)) Why not hoist th

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu added a comment. @vsk Do you think it's ok to reland this commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, aaron.ballman, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84707 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/bindings/go/llvm/Instrumentat

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny updated this revision to Diff 281067. jdenny edited the summary of this revision. jdenny added a comment. Rewrite patch as discussed: instead of generating different runtime calls for the end of an `omp target data` vs. the beginning of an `omp target exit data` so that the runtime can de

[PATCH] D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

amyk added a comment. I will need to update this patch to remove the instruction definition and MC tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82726/new/ https://reviews.llvm.org/D82726 ___ c

[PATCH] D82725: [PowerPC][Power10] Implement Move to VSR Mask builtins in LLVM/Clang

amyk added a comment. I will need to update this patch to remove the instruction definition and MC tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82725/new/ https://reviews.llvm.org/D82725 ___ c

[PATCH] D82675: [PowerPC][Power10] Implement Vector Extract Mask builtins in LLVM/Clang

amyk added a comment. I will need to update this patch to remove the instruction definition and MC tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82675/new/ https://reviews.llvm.org/D82675 ___ c

[PATCH] D82727: [PowerPC][Power10] Implement Vector Expand Mask builtins in LLVM/Clang

amyk added a comment. I will need to update this patch to remove the instruction definition and MC tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82727/new/ https://reviews.llvm.org/D82727 ___ c

[PATCH] D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake

vvereschaka added a comment. Hi Sergei, sorry for a late answer. I have tested these changes on Windows cross build to Aarch64 and I found the following problems: - looks like `ssh.py` arguments have been changed since the diff file was placed. Currently the correct string for `COMPILER_RT_EMUL

[PATCH] D84710: [OpenMP][NFC] Consolidate `to` and `from` clause modifiers

jdenny created this revision. jdenny added reviewers: ABataev, grokos, jdoerfert, RaviNarayanaswamy. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. `to` and `from` clauses take the same modifiers, which are called "motion modifiers" in TR8, so imp

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny created this revision. jdenny added reviewers: ABataev, grokos, jdoerfert, RaviNarayanaswamy. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. This patch implements Clang front end support for the OpenMP TR8 `present` motion modifier for `om

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang updated this revision to Diff 281077. weiwang added a comment. Fix msvc build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84246/new/ https://reviews.llvm.org/D84246 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake

broadwaylamb added a comment. In D83490#2177256 , @vvereschaka wrote: > - looks like `ssh.py` arguments have been changed since the diff file was > placed. Currently the correct string for `COMPILER_RT_EMULATOR` is the > following: ``` set(COMPILER_RT_EM

[clang] f250eb3 - [OpenMP][Docs] Update `present` modifier status

Author: Joel E. Denny Date: 2020-07-27T19:23:55-04:00 New Revision: f250eb37cd4fabcc9f222ca2da80b62d110d9fff URL: https://github.com/llvm/llvm-project/commit/f250eb37cd4fabcc9f222ca2da80b62d110d9fff DIFF: https://github.com/llvm/llvm-project/commit/f250eb37cd4fabcc9f222ca2da80b62d110d9fff.diff

[PATCH] D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk updated this revision to Diff 281080. amyk added a comment. Addressed the following comments: - updated CHECK lines to check for the full intrinsic call - updated indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82609/new/ https://re

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

asbirlea created this revision. asbirlea added reviewers: kuhar, dblaikie. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Simplify ChildrenGetter to a simple wrapper around a GraphDiff call. GraphDiff already handles nullptr in children, so the special casing in clang

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

mehdi_amini added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 64d99cc - [CMake] Move find_package(ZLIB) to LLVMConfig

Author: Petr Hosek Date: 2020-07-27T17:13:55-07:00 New Revision: 64d99cc6abed78c00a2a7863b02ce54911a5264f URL: https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f DIFF: https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f.diff LO

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

This revision was automatically updated to reflect the committed changes. Closed by commit rG64d99cc6abed: [CMake] Move find_package(ZLIB) to LLVMConfig (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.l

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

stephenneuendorffer added a comment. Perfect! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a subscriber: dneilson. jfb added a comment. I've addressed @rsmith @rjmccall suggestions (unless noted), thanks! An open question: as of 6e4aa1e48138182685431c76184dfc36e620aea2 @dneilson added an assertion on `CreateElementUnorderedAtomicMemCpy` to check that the pointer arguments ha

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 281087. jfb marked 15 inline comments as done. jfb added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/LanguageExtensions.

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. LGTM. One tiny nit: the function name `ChildrenGet` sounds kind of backwards to me, but it seems like the other direction is already taken. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8793 +BuiltinOp == Builtin::BI__builtin_memmove_overloaded || BuiltinOp == Builtin::BI__builtin_wmemmove; If we end up m

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

dblaikie added a comment. In D84713#2177408 , @kuhar wrote: > LGTM. > > One tiny nit: the function name `ChildrenGet` sounds kind of backwards to me, > but it seems like the other direction is already taken. If there are both "ChildrenGet" and "GetChild

<    1   2   3   >