kbobyrev marked an inline comment as not done. kbobyrev added inline comments.
================ Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:203 + TracerStream.reset(); + llvm::errs() << "Error while opening trace file " << TraceFile << ": " + << EC.message(); ---------------- kadircet wrote: > any reasons for not using elog in here (and in other places using > `llvm::errs()` ? I think we tend to use `llvm::errs()` instead of logs in CLI tools (ClangdMain.cpp and particularly `TraceFile` handling were the inspiration and it uses `llvm::errs()` although there are many `elog`s there, too) and I'm a little confused about when to use either of those. Could you explain how those are chosen in each case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
