thakis added inline comments.
================ Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ +#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMTE@ ---------------- hans wrote: > I'm guessing this should be @CLANGD_ENABLE_REMOTE@ > The gn build was upset: http://45.33.8.238/linux/23942/step_4.txt > Speculatively fixed in 47a0254229ca425aa4e169c2db14e92b8db86784. Please shout > if this was wrong. Also, you probably either want `#cmakedefine` or you want to check with `#if` instead of `#ifdef` below. As-is, in the disabled case this will write `#define CLANGD_ENABLE_REMOTE 0` in the disabled case, which causes the `#ifdef` to activate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
