dsanders marked an inline comment as done. dsanders added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:693 def e : JoinedOrSeparate<["-"], "e">, Group<Link_Group>; +def external_dsym_dir : JoinedOrSeparate<["-"], "external-dsym-dir">, + Flags<[DriverOption, RenderAsInput]>, ---------------- JDevlieghere wrote: > Could we drop the `external` prefix or did you pick this for consistency with > other flags? It seems rather specific for the externalize debug info scenario > while the functionality seems generic enough by itself. Sure, I wasn't terribly keen on the name and I didn't find any precedent to work from Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84572/new/ https://reviews.llvm.org/D84572 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
