froydnj added a comment.

In D81865#2176014 <https://reviews.llvm.org/D81865#2176014>, @bkramer wrote:

> Nice, those relocations have annoyed me for years. I'm worried about whether 
> the way you're accessing StaticDiagInfoDescriptionStringTable might be 
> undefined behavior. I won't block this change on that though.


Is there somebody who should review that particular bit?  My understanding is 
that it is OK, but my understanding of the C++ standard is not necessarily 
complete, and I'd like to get a second opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81865/new/

https://reviews.llvm.org/D81865



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to