yvvan accepted this revision.
yvvan added a comment.
This revision is now accepted and ready to land.
Let's proceed with this one. I really see that it's going to be useful.
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@li
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Comment at: clangd/CodeComplete.cpp:210
+const std::string Name = Method->getNameAsString();
+Overrides[Name].push_back(Method);
+ }
n
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
This patch prints information about built index size estimation to verbose
logs. This is useful
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: test/clang-tidy/abseil-no-namespace.cpp:10
+#include "absl/external-file.h"
+// CHECK: absl/external-file.h:1:11: warning: namespace 'absl' is reserve
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/MemIndex.cpp:105
+size_t MemIndex::estimateMemoryUsage() {
+ size_t Bytes = Index.size() * sizeof(std::pair);
+ return Bytes / (1000 * 1000);
access to Index needs to be guarded by mute
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This part looks good (I think everything controversial got moved into the other
patch). Thanks!
Comment at: clangd/Threading.cpp:75
+std::string ThreadName;
+d
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, kbobyrev, sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
The new mode avoids serializing and deserializing YAML.
This results in better performance and less memory usage. Reduce phase
is
ilya-biryukov added a comment.
Collecting the timings to build the index for LLVM now. Will publish when
they're ready
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: yvvan
Date: Thu Aug 23 02:48:11 2018
New Revision: 340521
URL: http://llvm.org/viewvc/llvm-project?rev=340521&view=rev
Log:
[libclang] Fix cursors for arguments of Subscript and Call operators
The DeclRefExpr of CXXOperatorCallExpr refering to the custom operator
is visited before the arg
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340521: [libclang] Fix cursors for arguments of Subscript
and Call operators (authored by yvvan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
Hi Richard,
There was a change in the spec to disallow unprototyped functions, which was
made this year. Unfortunately it seems it didn't make into the Khronos registry
yet to appear publicly. I will chase it up with Khronos.
I would like to highlight that OpenCL C was based on C99 originally
Author: arichardson
Date: Thu Aug 23 03:21:36 2018
New Revision: 340522
URL: http://llvm.org/viewvc/llvm-project?rev=340522&view=rev
Log:
Update avr attributes test for output change in r340519
After this commit there is an addrspace(1) before the attribute #. Since
these tests are only checking
Author: ibiryukov
Date: Thu Aug 23 03:25:07 2018
New Revision: 340523
URL: http://llvm.org/viewvc/llvm-project?rev=340523&view=rev
Log:
[clangd] Increase the timeouts in TUScheduler tests to 10 seconds.
Some of them timeout on our buildbots in certain configurations.
The timeouts are there to avo
sammccall added a comment.
first few comments, sorry I'll need to come back to this.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:90
virtual DocID peek() const = 0;
/// Retrieves boosting score. Query tree root should pass Root->peek() to
this
/// functio
kbobyrev updated this revision to Diff 162146.
kbobyrev marked 6 inline comments as done.
kbobyrev added a comment.
Address a bunch of comments.
https://reviews.llvm.org/D51154
Files:
clang-tools-extra/clangd/index/FileIndex.cpp
clang-tools-extra/clangd/index/FileIndex.h
clang-tools-extra
ioeric added a comment.
Overall looks good to me.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:61
+/// rely on MR use-case to work properly.
+llvm::cl::init(false));
+
AFAIK, this flag would basically depend on the executor being
ilya-biryukov added a comment.
Really excited about this one, this should give us decent latency improvements
when using the static index.
My main suggestion would be to put almost all of the speculating code into
`CodeComplete.cpp`.
We could merely return the request that should be used for sp
ilya-biryukov added a comment.
- New mode
./bin/global-symbol-builder -merge-on-the-fly -executor=all-TUs > /dev/null
40079.41s user 1874.40s system 5340% cpu 13:05.56 total
- Old mode
Still running, expect it to be more than 40minutes... Will update when I have
the numbers.
Repository:
ilya-biryukov added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:61
+/// rely on MR use-case to work properly.
+llvm::cl::init(false));
+
ioeric wrote:
> AFAIK, this flag would basically depend on the executor bein
theraven added a comment.
In https://reviews.llvm.org/D50144#1209758, @smeenai wrote:
> I'm confused by the funclet-based unwinding support. Do you intend GNUStep to
> be used with windows-msvc triples? If so, how is the runtime throwing
> exceptions? We took the approach of having the Obj-C ru
Author: uabelho
Date: Thu Aug 23 03:59:49 2018
New Revision: 340524
URL: http://llvm.org/viewvc/llvm-project?rev=340524&view=rev
Log:
Removed unused variable [NFC]
The compiler warned:
../tools/clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp:329:19: error:
unused variable 'MD' [-Werror,-W
ilya-biryukov added a comment.
The numbers are finally there
New mode
./bin/global-symbol-builder -merge-on-the-fly -executor=all-TUs > /dev/null
40079.41s user 1874.40s system 5340% cpu 13:05.56 total
Old mode
./bin/global-symbol-builder -merge-on-the-fly=false -executor=all-TUs >
/dev
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1050-1051
+// NOTE: if it is unsigned, then the comparison is naturally always
'false'.
+llvm::ICmpInst::Predicate Pred =
+VSigned ? llvm::ICmpInst::ICMP_SLT : llvm::ICmpInst::ICMP_ULT;
+
asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Thanks, looks good to me.
https://reviews.llvm.org/D50043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
mstorsjo added inline comments.
Comment at: src/Unwind-seh.cpp:163
+#ifdef __x86_64__
+unw_get_reg(&cursor, UNW_X86_64_RAX, &retval);
+unw_get_reg(&cursor, UNW_X86_64_RDX, &exc->private_[3]);
Without understanding the code flow completely - is there a ris
svenvh added inline comments.
Comment at: CMakeLists.txt:288
-if( CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR AND NOT MSVC_IDE )
- message(FATAL_ERROR "In-source builds are not allowed. CMake would overwrite
"
-"the makefiles distributed with LLVM. Please create a directory an
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:180
+ Bytes += SymbolQuality.size() * sizeof(std::pair);
+ Bytes += InvertedIndex.size() * sizeof(Token);
+ {
sammccall wrote:
> I think you're not counting the size of
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
chandlerc created this revision.
chandlerc added reviewers: rsmith, rnk, echristo, craig.topper, kristof.beyls.
Herald added subscribers: jfb, dexonsmith, steven_wu, hiraditya, eraman,
mcrosier, mehdi_amini, sanjoy.
Wires up the existing pass to work with a proper IR attribute rather
than just a
Author: kadircet
Date: Thu Aug 23 05:19:39 2018
New Revision: 340527
URL: http://llvm.org/viewvc/llvm-project?rev=340527&view=rev
Log:
[clangd] Move function argument snippet disable mechanism from LSP rendering to
internal clangd reprensentation.
Summary:
We were handling the EnableFunctionArgS
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340527: [clangd] Move function argument snippet disable
mechanism from LSP rendering to… (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revi
ilya-biryukov added a comment.
One major limitation of the current workaround is that IIRC clang can actually
call code completion callbacks, including this method, multiple times (e.g.
when completing inside a macro definition that gets expanded later in the file
or during parser recovery).
Th
kadircet updated this revision to Diff 162151.
kadircet added a comment.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCo
ioeric added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:61
+/// rely on MR use-case to work properly.
+llvm::cl::init(false));
+
ilya-biryukov wrote:
> ioeric wrote:
> > AFAIK, this flag would basically depend on
ilya-biryukov added inline comments.
Comment at: clangd/index/Index.h:46
+
+inline bool operator==(const SymbolLocation::Position &L,
+ const SymbolLocation::Position &R) {
hokein wrote:
> ilya-biryukov wrote:
> > NIT: having friend decls in
kadircet updated this revision to Diff 162157.
kadircet added a comment.
- Resolve discussions.
- Move override generation logic from render to item generation so that
internal clients can use it as well, also use a boolean for checking override
status of a bundle to be more efficient.
- Change
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM. Many thanks!
See the NIT about avoiding the helper class too.
Comment at: clangd/Threading.cpp:88
+ llvm::llvm_execute_on_thread_async(
+ Callable{Name.str(), std::move(Action), std::move(CleanupTa
ilya-biryukov added a comment.
Some drive-by NITS.
Comment at: clang-tools-extra/clangd/index/MemIndex.cpp:109
+std::lock_guard Lock(Mutex);
+
+Bytes += Index.getMemorySize();
Why not simply `return Index.getMemorySize()` under a lock?
===
asb added a comment.
Herald added a subscriber: jocewei.
Thanks for the patch and sorry for the delay. Once someone else marked it
accepted it moves to a separate list in Phabricator - obviously I need to check
the 'waiting on authors' list better.
As I see it are two changes here:
1. Calculat
hokein accepted this revision.
hokein added a comment.
still LG.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:61
+/// rely on MR use-case to work properly.
+llvm::cl::init(false));
+
ioeric wrote:
> ilya-biryukov wrote:
> > ioeric wrote:
> > > AFAIK, this fla
Author: kadircet
Date: Thu Aug 23 06:14:50 2018
New Revision: 340530
URL: http://llvm.org/viewvc/llvm-project?rev=340530&view=rev
Log:
[clangd] Suggest code-completions for overriding base class virtual methods.
Summary:
Whenever a code-completion is triggered within a class/struct/union looks at
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE340530: [clangd] Suggest code-completions for overriding
base class virtual methods. (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50898?vs=162157&id=162158
Author: uabelho
Date: Thu Aug 23 06:18:27 2018
New Revision: 340531
URL: http://llvm.org/viewvc/llvm-project?rev=340531&view=rev
Log:
Change dyn_cast(FD) to isa(FD) [NFC]
The result of the dyn_cast wasn't used to we can just check isa.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/RetainSummar
Author: mramalho
Date: Thu Aug 23 06:20:18 2018
New Revision: 340532
URL: http://llvm.org/viewvc/llvm-project?rev=340532&view=rev
Log:
[analyzer] Delete SMTContext. NFC.
Summary: There is no reason to have a base class for a context anymore as each
SMT object carries a reference to the specific
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340532: [analyzer] Delete SMTContext. NFC. (authored by
mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50768
Files:
include/clang/St
Author: mramalho
Date: Thu Aug 23 06:21:00 2018
New Revision: 340533
URL: http://llvm.org/viewvc/llvm-project?rev=340533&view=rev
Log:
[analyzer] Templatefy SMTConstraintManager so more generic code can be moved
from solver specific implementations. NFC.
Summary:
By making SMTConstraintManager a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340535: [analyzer] added cache for SMT queries in the
SMTConstraintManager (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D
Author: mramalho
Date: Thu Aug 23 06:21:31 2018
New Revision: 340534
URL: http://llvm.org/viewvc/llvm-project?rev=340534&view=rev
Log:
[analyzer] Moved all CSA code from the SMT API to a new header, `SMTConv.h`.
NFC.
Summary:
With this patch, the SMT backend is almost completely detached from th
Author: mramalho
Date: Thu Aug 23 06:21:35 2018
New Revision: 340535
URL: http://llvm.org/viewvc/llvm-project?rev=340535&view=rev
Log:
[analyzer] added cache for SMT queries in the SMTConstraintManager
Summary:
This patch implements a new cache for the result of SMT queries; with this
patch the
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, simark.
Herald added a subscriber: cfe-commits.
This partially rolls back the change in https://reviews.llvm.org/D48903:
https://github.com/llvm-mirror/clang/commit/89aa7f45a1f728144935289d4ce69d8522999de0#diff-0025af005307891b54
ioeric updated this revision to Diff 162166.
ioeric added a comment.
- Add comment
Repository:
rC Clang
https://reviews.llvm.org/D51159
Files:
lib/Basic/FileManager.cpp
Index: lib/Basic/FileManager.cpp
===
--- lib/Basic/File
ioeric added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:61
+/// rely on MR use-case to work properly.
+llvm::cl::init(false));
+
ilya-biryukov wrote:
> ioeric wrote:
> > ilya-biryukov wrote:
> > > ioeric wrote:
>
hugoeg marked 7 inline comments as done.
hugoeg added a comment.
If the fix-it can be implemented, I certainly do not know how. As mentioned
above, I am not the original author for this check.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51132
_
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D50617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
hugoeg updated this revision to Diff 162174.
hugoeg added a comment.
corrections applied
https://reviews.llvm.org/D51132
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
clang-tidy/abseil/RedundantStrcatCallsC
On Wed, Aug 22, 2018 at 6:35 PM, Aaron Puchert via Phabricator
wrote:
> aaronpuchert added inline comments.
>
>
>
> Comment at: lib/Analysis/ThreadSafety.cpp:932
> + // We're relocking the underlying mutexes. Warn on double locking.
> + if (FSet.findLock(FactMan, UnderCp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Excellent!
Repository:
rL LLVM
https://reviews.llvm.org/D51049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
kristina added inline comments.
Comment at: src/UnwindCursor.hpp:1801
+ if (pc != getLastPC()) {
+UNWIND_INFO *xdata = reinterpret_cast(base +
unwindEntry->UnwindData);
+if (xdata->Flags & (UNW_FLAG_EHANDLER|UNW_FLAG_UHANDLER)) {
mstorsjo wrote:
> I can
kadircet created this revision.
kadircet added reviewers: ilya-biryukov, hokein, ioeric.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Currently we match an include only if we are inside filename, with this patch we
will match whenever we are on the starting line of the includ
lewis-revill updated this revision to Diff 162179.
lewis-revill added a comment.
Added tests for the case where `--sysroot` is not provided.
Repository:
rC Clang
https://reviews.llvm.org/D50246
Files:
lib/Driver/ToolChains/RISCV.cpp
lib/Driver/ToolChains/RISCV.h
test/Driver/riscv32-too
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: ioeric.
Herald added a subscriber: kadircet.
Used in clangd's symbol builder to optimize for the common
shared-memory executor case.
Repository:
rC Clang
https://reviews.llvm.org/D51164
Files:
include/clang/Tooling/AllTUs
kbobyrev updated this revision to Diff 162183.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Address a round comments from Sam.
https://reviews.llvm.org/D51029
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/dex/Iterator.h
clang
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D51164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
kbobyrev updated this revision to Diff 162184.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Slightly simplify the code.
https://reviews.llvm.org/D51154
Files:
clang-tools-extra/clangd/index/FileIndex.cpp
clang-tools-extra/clangd/index/FileIndex.h
clang-tools-extra/
gtbercea added inline comments.
Comment at: lib/Basic/Targets/NVPTX.cpp:232
+ // getting inlined on the device.
+ Builder.defineMacro("__NO_MATH_INLINES");
}
tra wrote:
> This relies on implementation detail of particular variant of the header file
> you're a
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me.
https://reviews.llvm.org/D51093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov updated this revision to Diff 162194.
ilya-biryukov added a comment.
- Don't merge on-the-fly for multi-process executors
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51155
Files:
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
Index: clangd/global-s
Author: kadircet
Date: Thu Aug 23 08:55:27 2018
New Revision: 340539
URL: http://llvm.org/viewvc/llvm-project?rev=340539&view=rev
Log:
[clangd] Check for include overlapping looks for only the line now.
Summary:
Currently we match an include only if we are inside filename, with this patch we
will
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340539: [clangd] Check for include overlapping looks for
only the line now. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
Author: teemperor
Date: Thu Aug 23 09:06:30 2018
New Revision: 340541
URL: http://llvm.org/viewvc/llvm-project?rev=340541&view=rev
Log:
Re-land [ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt
Lands r340468 again, but this time we mark the test as unsupported on Windows
be
Thanks! Looking at the list of failing bots that seems indeed to be
the most likely explanation.
- Raphael
Am Mi., 22. Aug. 2018 um 16:59 Uhr schrieb Shoaib Meenai :
>
> Might be because the constructed AST for a @finally on Windows will contain a
> CapturedStmt: https://reviews.llvm.org/D47564.
Szelethus updated this revision to Diff 162198.
Szelethus added a comment.
Addressed the inline comments.
- Added a `llvm::SmallSet` to further ensure the termination of the loop.
- Changed `isLocType` to `isDereferencableType`, block pointers are regarded as
primitive objects.
- Added new tests
ldionne created this revision.
ldionne added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
The state associated to the future was set in one thread (with synchronization)
but read in another thread without synchronization, wh
ilya-biryukov added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:61
+/// rely on MR use-case to work properly.
+llvm::cl::init(false));
+
ioeric wrote:
> ilya-biryukov wrote:
> > ioeric wrote:
> > > ilya-biryukov w
Szelethus marked 5 inline comments as done.
Szelethus added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h:259
+ return T->isBuiltinType() || T->isEnumeralType() ||
+ T->isMemberPointerType() || T->isBlockPointerType()
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:60
+"MapReduce."),
+llvm::cl::init(true));
+
Maybe make this hidden?
Szelethus updated this revision to Diff 162205.
Szelethus added a comment.
Rebased to https://reviews.llvm.org/D51057.
https://reviews.llvm.org/D50892
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
Ind
Hahnfeld added a comment.
The discussion kind of moved away from the original patch, probably because the
problem is larger than the defition of some host macros. However I still think
that this patch improves the situation.
Repository:
rC Clang
https://reviews.llvm.org/D50845
__
erik.pilkington created this revision.
erik.pilkington added reviewers: ldionne, mclow.lists, hans.
Herald added a reviewer: EricWF.
Herald added subscribers: dexonsmith, christof.
The other half of this is in https://reviews.llvm.org/D48896, so we shouldn't
claim that we support this feature. Th
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM. Don't forget to update https://reviews.llvm.org/D48896 so it uncomments
this. Also, this should be merged into LLVM 7.
Repository:
rCXX libc++
https://reviews.llvm.org/D51172
__
Author: epilk
Date: Thu Aug 23 10:08:02 2018
New Revision: 340544
URL: http://llvm.org/viewvc/llvm-project?rev=340544&view=rev
Log:
Comment out #define __cpp_lib_node_extract, we only support half of that
functionality
Differential revision: https://reviews.llvm.org/D51172
Modified:
libcxx/
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX340544: Comment out #define __cpp_lib_node_extract, we
only support half of that… (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51172?vs=162208&id=162215#toc
rjmccall added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:4924
+<< Callee->getSourceRange();
+ }
+
Why is the diagnostic at the end location? And why are you separately checking
whether it's ignored at the begin location?
erik.pilkington added a comment.
Landed as r340544. @hans: Can you cherry-pick?
Repository:
rCXX libc++
https://reviews.llvm.org/D51172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:16
+
+ string s = StrCat("A", StrCat("B", StrCat("C", "D")));
+ ==> string s = StrCat("A", "B", "C", "D");
Please add namespaces and use empty l
Author: shuaiwang
Date: Thu Aug 23 10:16:06 2018
New Revision: 340547
URL: http://llvm.org/viewvc/llvm-project?rev=340547&view=rev
Log:
[ASTMatchers] Let hasObjectExpression also support UnresolvedMemberExpr,
CXXDependentScopeMemberExpr
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differe
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340547: [ASTMatchers] Let hasObjectExpression also support
UnresolvedMemberExpr… (authored by shuaiwang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50617?vs=161830&id=162218#toc
Szelethus added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:187-191
// If FR is a pointer pointing to a non-primitive type.
if (Optional RecordV =
DerefdV.getAs()) {
const TypedValueRegion *R = Rec
hugoeg updated this revision to Diff 162219.
https://reviews.llvm.org/D51132
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
clang-tidy/abseil/RedundantStrcatCallsCheck.h
docs/ReleaseNotes.rst
docs/clang-ti
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-redundant-strcat-calls.rst:16
+
+ string s = absl::StrCat("A", absl::StrCat("B", absll::StrCat("C",
"D")));
+ string s = absl::StrCat("A", "B", "C", "D");
std::string
ioeric updated this revision to Diff 162221.
ioeric marked 5 inline comments as done.
ioeric added a comment.
Herald added subscribers: jfb, javed.absar.
- Moved most logic into CodeComplete.cc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cp
hugoeg updated this revision to Diff 162223.
https://reviews.llvm.org/D51132
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
clang-tidy/abseil/RedundantStrcatCallsCheck.h
docs/ReleaseNotes.rst
docs/clang-ti
ioeric updated this revision to Diff 16.
ioeric added a comment.
- minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/TUScheduler.h
clangd/i
ioeric updated this revision to Diff 162224.
ioeric added a comment.
- another minior cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/TUScheduler.h
ioeric added inline comments.
Comment at: clangd/ClangdServer.cpp:159
+ }
+ if (SpecFuzzyReq) {
+if (auto Filter = speculateCompletionFilter(Content, Pos)) {
ilya-biryukov wrote:
> NIT: maybe invert condition to reduce nesting?
It would become something lik
simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:319
- SmallString<128> RealPathName;
- if (!FS->getRealPath(InterndFileName, RealPathName))
-UFE.RealPathName = RealPathName.str();
+ if (UFE.File) {
+if (auto Path = UFE.File->getName()) {
-
hugoeg added a comment.
Let me know if there's anything else I can fix to move the process along.
https://reviews.llvm.org/D51061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-str-cat-append.rst:11
+
+ a = StrCat(a, b); // Use StrAppend(&a, b) instead.
+
Please add namespace.
https://reviews.llvm.org/D51061
1 - 100 of 178 matches
Mail list logo
