asb added a comment.
Herald added a subscriber: jocewei.

Thanks for the patch and sorry for the delay. Once someone else marked it 
accepted it moves to a separate list in Phabricator - obviously I need to check 
the 'waiting on authors' list better.

As I see it are two changes here:

1. Calculating libcxx include paths based on specified sysroot
2. Computing the sysroot when an explicit path isn't provided

Could you please add a test that covers 2) above?


Repository:
  rC Clang

https://reviews.llvm.org/D50246



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to