ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM. Many thanks!
See the NIT about avoiding the helper class too.
================
Comment at: clangd/Threading.cpp:88
+ llvm::llvm_execute_on_thread_async(
+ Callable{Name.str(), std::move(Action), std::move(CleanupTask)},
+ clang::DesiredStackSize);
----------------
NIT: we usually do the following to avoid writing those classes (not great, but
arguably a bit less boilerplate):
```
// 'Bind' is in 'Function.h'
Bind([](decltype(ThreadFunc) ThreadFunc, decltype(CleanupTask), std::string
ThreadName) {
// ... code
},
std::move(Action), std::move(CelanupTask), std::move(ThreadName));
```
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50993
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
