hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Looks good. ================ Comment at: test/clang-tidy/abseil-no-namespace.cpp:10 +#include "absl/external-file.h" +// CHECK: absl/external-file.h:1:11: warning: namespace 'absl' is reserved +// for implementation of the Abseil library and should not be opened in user ---------------- Does the test get passed on the first command `%check_clang_tidy %s abseil-no-namespace %t -- -- -I %S/Inputs`? The first command will suppress all warning in headers, I think it will fail? https://reviews.llvm.org/D50580 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits