[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

labath added a comment. This was reverted in r333482 because it was causing "definition with same mangled name as another definition" errors in some internal google builds. It turned out this uncovered an (unrelated) issue in module importing. This has now been fixed (r336240), so I'm planning

[PATCH] D48786: [Preprocessor] Stop entering included files after hitting a fatal error.

jkorous added a reviewer: jkorous. jkorous added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1875 + // Stop further preprocessing if a fatal error has occurred. Any diagnostics + // we might have raised will not be visible. + if (ShouldEnter && Diags->hasFatalE

[PATCH] D49075: [NEON] Define fp16 vld and vst intrinsics conditionally

kosarev added a comment. Ping. https://reviews.llvm.org/D49075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48829: [NEON] Fix support for vrndi_f32(), vrndiq_f32() and vrndns_f32() intrinsics

kosarev added a comment. Ping. https://reviews.llvm.org/D48829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

ioeric added a comment. Some high-level comments before jumping into details. Comment at: clang-tools-extra/clangd/index/noctem/SearchAtom.cpp:23 + +// FIXME(kbobyrev): Deal with short symbol symbol names. +std::vector generateSearchAtoms(StringRef SymbolName) { ---

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @rsmith and @probinson: Is there anything I can add to this patch? The review https://reviews.llvm.org/D44826 is already approved and it is blocked by this patch being reviewed. Thanks very much https://reviews.llvm.org/D46190

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark added inline comments. Herald added a subscriber: ldionne. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do lichray wrote: > mclow.lists wrote: > > I have been ask

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

dkrupp added a comment. > Which means that for some calls we aren't even trying to make a CTU lookup. Thanks @NoQ, we will take a look at it! Repository: rC Clang https://reviews.llvm.org/D30691 ___ cfe-commits mailing list cfe-commits@lists.llv

r337381 - Mention clang-cl improvements from r335466 and r336379 in ReleaseNotes.rst

Author: nico Date: Wed Jul 18 04:55:03 2018 New Revision: 337381 URL: http://llvm.org/viewvc/llvm-project?rev=337381&view=rev Log: Mention clang-cl improvements from r335466 and r336379 in ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst UR

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

thakis added a comment. In https://reviews.llvm.org/D46652#1164016, @thakis wrote: > And finally (sorry about all the mails), this should probably be mentioned in > the release notes (docs/ReleaseNotes.rst in the clang repo) since it's a > notable new feature :-) I added this to releasenotes

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding Richard to see if he agrees with the direction taken. Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `Accesse

[PATCH] D49457: DR330: when determining whether a cast casts away constness, consider qualifiers from all levels matching a multidimensional array

davezarzycki added a comment. Hi @rsmith – I've verified this patch fixes the original issue. Thanks for the quick fix! Repository: rC Clang https://reviews.llvm.org/D49457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D49476: [Index] Set OrigD before D is changed.

ioeric created this revision. ioeric added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49476 Files: lib/Index/IndexingContext.cpp Index: lib/Index/IndexingContext.cpp ==

Re: r336380 - Add PCH tests for R336379

I think normally we don't set all these svn properties. Did you set them intentionally? On Thu, Jul 5, 2018 at 1:28 PM Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Thu Jul 5 10:23:15 2018 > New Revision: 336380 > > URL: http://llvm.org/viewvc/llvm

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric updated this revision to Diff 156056. ioeric marked 4 inline comments as done. ioeric added a comment. - addressed review comments. Repository: rC Clang https://reviews.llvm.org/D49421 Files: lib/Sema/SemaAccess.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-access-checks

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric added a comment. Thanks for the review! Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `AccessedEntity::getAccess` describes what access was used to +// access an entity. -

RE: r336380 - Add PCH tests for R336379

Ugg… I did not. Seemingly my svn-property cleaning script isn’t working for some reason. If it hasn’t been done yet, I’ll clear the properties now. From: Nico Weber [mailto:tha...@chromium.org] Sent: Wednesday, July 18, 2018 5:21 AM To: Keane, Erich Cc: cfe-commits Subject: Re: r336380 - Add

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

aaron.ballman added inline comments. Comment at: include/clang/AST/Decl.h:2212-2213 + bool isCpuDispatchMultiVersion() const; + bool isCpuSpecificMultiVersion() const; + aaron.ballman wrote: > Pedantic nit: CPU instead of Cpu? Thoughts on `isCPUDispatchMultiV

r337388 - Clear properties inadvertantly added to tests in R336379

Author: erichkeane Date: Wed Jul 18 06:07:13 2018 New Revision: 337388 URL: http://llvm.org/viewvc/llvm-project?rev=337388&view=rev Log: Clear properties inadvertantly added to tests in R336379 Modified: cfe/trunk/test/PCH/Inputs/pch-through-use0.cpp (props changed) cfe/trunk/test/PCH/I

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

erichkeane added a subscriber: olga.chupina. erichkeane added a comment. In https://reviews.llvm.org/D49403#1165845, @rjmccall wrote: > Can you explain why this is important for the optimizer? @olga.a.chupina (or is it @olga.chupina ) is the one who reported this to me, so hopefully she can e

[PATCH] D49112: [Sema] Implement -Wmemset-transposed-args

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7975-7976 +static void CheckMemsetSizeof(Sema &S, unsigned BId, const CallExpr *Call) { + if (BId != Builtin::BImemset) +return; + erik.pilkington wrote: > aaron.ballman wrote:

Re: r337255 - Temporarily revert r337226 "Restructure checking for, and warning on, lifetime extension."

On 17/07/2018 23:29, Richard Smith wrote: Thank you. I added an 'alignas(8)' and reapplied in r337329. Great thank you very much! ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49480: Haiku: support for secondary arch

kallisti5 created this revision. Herald added subscribers: cfe-commits, mgorny. Enables Haiku to build llvm for secondary architectures. Repository: rC Clang https://reviews.llvm.org/D49480 Files: CMakeLists.txt lib/Driver/ToolChains/Haiku.cpp lib/Frontend/InitHeaderSearch.cpp Index:

[PATCH] D49480: Haiku: support for secondary arch

kallisti5 added a comment. Original author is "Jerome Duval " I don't have permission to modify this, can author be updated? (I don't have permission to) Repository: rC Clang https://reviews.llvm.org/D49480 ___ cfe-commits mailing list cfe-comm

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

ABataev added a comment. In https://reviews.llvm.org/D49148#1165826, @echristo wrote: > I think you should break it out on an option by option basis. Just warning on > "non-standard" options won't make as much sense to end users. Perhaps a "this > option is unsupported on the target you're comp

[PATCH] D49481: Haiku: Enable thread-local storage and disable PIE by default

kallisti5 created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49481 Files: lib/Basic/Targets/OSTargets.h lib/Driver/ToolChains/Haiku.h Index: lib/Driver/ToolChains/Haiku.h ==

[PATCH] D49481: Haiku: Enable thread-local storage and disable PIE by default

kallisti5 added a comment. The original author is "Jerome Duval " I don't have permission to modify this, can the author be updated? Repository: rC Clang https://reviews.llvm.org/D49481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D49482: Haiku: add a test for haiku driver

kallisti5 created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49482 Files: test/Driver/haiku.c Index: test/Driver/haiku.c === --- /dev/null +++ test/Driver/haiku.c @@ -

[PATCH] D49482: Haiku: add a test for haiku driver

kallisti5 added a comment. Original author is "Jerome Duval " I don't have permission to modify this, can author be updated? Repository: rC Clang https://reviews.llvm.org/D49482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

martong added a comment. Just added a new entry to our roadmap: https://github.com/Ericsson/clang/issues/435 Repository: rC Clang https://reviews.llvm.org/D30691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

martong added a comment. @NoQ , @dkrupp CallEvent::getRuntimeDefinition is overwritten in - AnyFunctionCall - CXXInstanceCall - CXXMemberCall - CXXDestructorCall - ObjCMethodCall AnyFunctionCall handles the CTU logic. CXXInstanceCall calls into AnyFunctionCall if the function is not virtual. If

[PATCH] D48341: [clang-doc] Refactoring mapper to map by scope

ioeric added a comment. Map/Reduce change looks good to me. Comment at: clang-tools-extra/test/clang-doc/yaml-record.cpp:44 +// CHECK-0: --- +// CHECK-0-NEXT: USR: '06B5F6A19BA9F6A832E127C9968282B94619B210' +// CHECK-0-NEXT: Name:'C' > Y

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 updated this revision to Diff 156064. avt77 added a comment. I added required comments and did the required changes. https://reviews.llvm.org/D47196 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.h include/clang/Frontend/Utils.h lib/CodeGen/CodeGen

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

erichkeane updated this revision to Diff 156068. erichkeane marked 13 inline comments as done. erichkeane added a comment. All of @aaron.ballman s comments have been dealt with except for Cpus->CPUs in the Attr.td file for explained reasons. Still negotiable :) https://reviews.llvm.org/D47474

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

erichkeane added a comment. Comment at: include/clang/AST/Decl.h:2212-2213 + bool isCpuDispatchMultiVersion() const; + bool isCpuSpecificMultiVersion() const; + aaron.ballman wrote: > aaron.ballman wrote: > > Pedantic nit: CPU instead of Cpu? > Thoughts o

[PATCH] D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result.

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added a subscriber: cfe-commits. RK_Pattern results can also have associated declarations e.g. field decls in constructor initializers. Repository: rC Clang https://reviews.llvm.org/D49484 Files: include/clang/Sema/Code

[PATCH] D49480: Haiku: support for secondary arch

joerg requested changes to this revision. joerg added a comment. This revision now requires changes to proceed. This is absolutely not how the clang driver is supposed to work. No conditional compilation. Repository: rC Clang https://reviews.llvm.org/D49480 ___

[PATCH] D49482: Haiku: add a test for haiku driver

joerg added a comment. It seems to miss most of the interesting checks, i.e. crt files. Compare with any of the entries on netbsd.c for example. Repository: rC Clang https://reviews.llvm.org/D49482 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

philip.pfaffe created this revision. philip.pfaffe added reviewers: mgorny, beanz, gottesmm. Herald added a subscriber: bollu. Out-of-tree tools trying to parse source files need the builtin headers such as `stddef.h`. If the tool isn't installed together with clang, it can't find them automatical

[PATCH] D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D49484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49302: [AST] Various micro-optimizations in CXXInheritance

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. cool Repository: rC Clang https://reviews.llvm.org/D49302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1080 + unsigned int r; + asm("vabsdiff2.u32.u32.u32.sat %0,%1,%2,0;" : "=r"(r) : "r"(__a), "r"(__b)); +

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz updated this revision to Diff 156073. omtcyfz marked 11 inline comments as done. omtcyfz added a comment. Addressed all comments by Eric. As discussed internally, I should also exercise my naming skills and come up with a better for the symbol index to substitute "Noctem" which doesn't p

[PATCH] D49480: Haiku: support for secondary arch

kallisti5 added a comment. No worries. I was wondering if this one would match llvm's goals. Do you see any iteration of these changes that would be accepted? (not using define's, etc) We currently support "hybrid" operating system builds where we compile a secondary toolchain / abi. An curren

[PATCH] D49083: [HIP] Register/unregister device fat binary only once

yaxunl added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:444 +auto HandleValue = +CtorBuilder.CreateAlignedLoad(GpuBinaryHandle, CGM.getPointerAlign()); +llvm::Constant *Zero = llvm::Constant::getNullValue(HandleValue->getType()); rjmcc

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

NoQ added a comment. Aha, cool, so it's probably just virtual functions. Repository: rC Clang https://reviews.llvm.org/D30691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r337394 - [CodeComplete] Allow getDeclaration on RK_Pattern result.

Author: ioeric Date: Wed Jul 18 08:17:52 2018 New Revision: 337394 URL: http://llvm.org/viewvc/llvm-project?rev=337394&view=rev Log: [CodeComplete] Allow getDeclaration on RK_Pattern result. Summary: RK_Pattern results can also have associated declarations e.g. field decls in constructor initiali

[PATCH] D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337394: [CodeComplete] Allow getDeclaration on RK_Pattern result. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49484 File

[PATCH] D49481: Haiku: Enable thread-local storage and disable PIE by default

joerg requested changes to this revision. joerg added a comment. This revision now requires changes to proceed. Both needs a test case :) Repository: rC Clang https://reviews.llvm.org/D49481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r337396 - [clangd] Also get scope for RK_pattern completion results.

Author: ioeric Date: Wed Jul 18 08:31:14 2018 New Revision: 337396 URL: http://llvm.org/viewvc/llvm-project?rev=337396&view=rev Log: [clangd] Also get scope for RK_pattern completion results. For exmaple, clas field candidates in constructor initializers can be RK_Pattern, but they can still have

[PATCH] D49294: Sema: Fix explicit address space cast in C++

yaxunl added inline comments. Comment at: lib/Sema/SemaOverload.cpp:3150 + !getLangOpts().OpenCLCPlusPlus) +return false; + rjmccall wrote: > It's not really OpenCL C++ that's special here, it's the possibility of > promotions between address spaces. Fo

[PATCH] D49492: Run bounds checking sanitizer earlier to make it easier to optimize away its checks.

jgalenson created this revision. jgalenson added reviewers: eugenis, chandlerc. Herald added a subscriber: cfe-commits. Running the bounds checking sanitizer earlier makes it easier for other optimizations to remove the checks it inserts. While it could also inhibit other optimizations, I ran a

[PATCH] D49058: [analyzer] Move DanglingInternalBufferChecker out of alpha

rnkovacs added a comment. Two more reports on Ceph that seem to be true positives (no other reports from this checker): 1. Here (or if it does not work, the bug is on L130 here ). 2. Here

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

tra added a comment. I'm in the middle of writing the tests for these as it's very easy to mess things up. I'll update the patch once I run it through the tests. Another problem with the patch in the current form is that these instructions apparently do not accept immediate arguments. PTX is a

[PATCH] D46190: For a used declaration, mark any associated usings as referenced.

probinson added a comment. A bunch of style comments. Maybe try clang-format-diff. Comment at: include/clang/Sema/SemaInternal.h:91 Var->markUsed(SemaRef.Context); + SemaRef.MarkUsingReferenced(Var, Loc, /*CXXScopeSpec*=*/nullptr, RefExpr); } The comments

[PATCH] D49466: Initial implementation of -fmacro-prefix-mapand -ffile-prefix-map

erichkeane added inline comments. Comment at: include/clang/Lex/Preprocessor.h:155 + /// A prefix map for __FILE__ and __BASEFILE__ + llvm::SmallDenseMap MacroPrefixMap; + Scrolling back up, put this implementation as close to the debug implementation as you c

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

mgrang added a comment. Ping 3 for reviews please. https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r337406 - Update the synopsis for for C++20. No functional change.

Author: marshall Date: Wed Jul 18 10:37:51 2018 New Revision: 337406 URL: http://llvm.org/viewvc/llvm-project?rev=337406&view=rev Log: Update the synopsis for for C++20. No functional change. Modified: libcxx/trunk/include/chrono Modified: libcxx/trunk/include/chrono URL: http://llvm.org/

[PATCH] D49294: Sema: Fix explicit address space cast in C++

rjmccall added inline comments. Comment at: lib/Sema/SemaOverload.cpp:3150 + !getLangOpts().OpenCLCPlusPlus) +return false; + yaxunl wrote: > rjmccall wrote: > > It's not really OpenCL C++ that's special here, it's the possibility of > > promotions betw

[PATCH] D49083: [HIP] Register/unregister device fat binary only once

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:444 +auto HandleValue = +CtorBuilder.CreateAlignedLoad(GpuBinaryHandle, CGM.getPointerAlign()); +llvm::Constant *Zero = llvm::Constant::getNullValue(HandleValue->getType()); yax

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

echristo added a comment. In https://reviews.llvm.org/D49148#1166429, @ABataev wrote: > In https://reviews.llvm.org/D49148#1165826, @echristo wrote: > > > I think you should break it out on an option by option basis. Just warning > > on "non-standard" options won't make as much sense to end user

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

echristo added a comment. It's usually preferred to submit patches with full context - it'll make this a bit easier if you do please? Repository: rC Clang https://reviews.llvm.org/D46230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D49083: [HIP] Register/unregister device fat binary only once

yaxunl added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:444 +auto HandleValue = +CtorBuilder.CreateAlignedLoad(GpuBinaryHandle, CGM.getPointerAlign()); +llvm::Constant *Zero = llvm::Constant::getNullValue(HandleValue->getType()); rjmcc

[PATCH] D49458: Support implicit _Atomic struct load / store

jfb added a comment. I'm sure there are other bugs around `_Atomic`, please file a bug an CC me if that's the case. I'll commit this fix for now. Repository: rC Clang https://reviews.llvm.org/D49458 ___ cfe-commits mailing list cfe-commits@lists

r337410 - Support implicit _Atomic struct load / store

Author: jfb Date: Wed Jul 18 11:01:41 2018 New Revision: 337410 URL: http://llvm.org/viewvc/llvm-project?rev=337410&view=rev Log: Support implicit _Atomic struct load / store Summary: Using _Atomic to do implicit load / store is just a seq_cst atomic_load / atomic_store. Stores currently assert

[PATCH] D49458: Support implicit _Atomic struct load / store

This revision was automatically updated to reflect the committed changes. Closed by commit rL337410: Support implicit _Atomic struct load / store (authored by jfb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49458 Files: cfe/trunk/l

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

echristo added a comment. In https://reviews.llvm.org/D49148#1166859, @echristo wrote: > In https://reviews.llvm.org/D49148#1166429, @ABataev wrote: > > > In https://reviews.llvm.org/D49148#1165826, @echristo wrote: > > > > > I think you should break it out on an option by option basis. Just > >

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading updated this revision to Diff 156117. gaijiading added a comment. Include the full context in the update diff. Repository: rC Clang https://reviews.llvm.org/D46230 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/Inputs/ami_linux_tree/usr/lib/gcc/x86_64-amazon-linux/7/crtbegin

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric Repository: rC Clang https://reviews.llvm.org/D46230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. Thanks very much for the comments and the review. Repository: rC Clang https://reviews.llvm.org/D46230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r337417 - [analyzer] Remove a debug print that was accidentally left around.

Author: dergachev Date: Wed Jul 18 11:44:40 2018 New Revision: 337417 URL: http://llvm.org/viewvc/llvm-project?rev=337417&view=rev Log: [analyzer] Remove a debug print that was accidentally left around. No functional change intended. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cp

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. In https://reviews.llvm.org/D46230#1166919, @echristo wrote: > LGTM. > > -eric Hi Eric, I do not have commit access to trunk. Could you commit the change for me? Thanks. Repository: rC Clang https://reviews.llvm.org/D46230 ___

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:851 + let Spellings = [Clang<"cpu_specific">]; + let Args = [VariadicIdentifierArgument<"Cpus">]; + let Subjects = SubjectList<[Function]>; erichkeane wrote: > aaron.ballman wrote: >

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek created this revision. phosek added a reviewer: EricWF. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. Currently it's possible to select whether to statically link unwinder or the C++ ABI library, but this option applies to both the shared and static library. However, in

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek added a comment. This came up in Fuchsia. Clang driver, add `-lc++` as a dependency. This is sufficient for shared libc++, but for static user has to manually pass `-lc++abi -lunwind`, so for static libc++ we would actually like to combine both libc++abi and libunwind into a single archi

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

phosek added inline comments. Comment at: libcxx/CMakeLists.txt:158 +cmake_dependent_option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY_STATIC + "Statically link the ABI library to static library" ON Maybe `LIBCXX_ENABLE_STATIC_ABI_LIBRARY_IN_STATIC_LIBRARY` would be mor

[PATCH] D49502: [CMake] Support statically linking dependencies only to shared or static library

ldionne added inline comments. Comment at: libcxx/CMakeLists.txt:158 +cmake_dependent_option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY_STATIC + "Statically link the ABI library to static library" ON phosek wrote: > Maybe `LIBCXX_ENABLE_STATIC_ABI_LIBRARY_IN_STATIC_LIBR

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `AccessedEntity::getAccess` describes what access was used to +// access an entity.

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

echristo added a comment. In https://reviews.llvm.org/D46230#1166958, @gaijiading wrote: > In https://reviews.llvm.org/D46230#1166919, @echristo wrote: > > > LGTM. > > > > -eric > > > Hi Eric, I do not have commit access to trunk. Could you commit the change > for me? Thanks. The binaries make

[PATCH] D49504: Enable C++2a Chrono Literals

erichkeane created this revision. erichkeane added reviewers: rsmith, gribozavr, ddunbar, eli.friedman. Herald added a subscriber: cfe-commits. C++2a via http://wg21.link/p0355 permits the library literals of 'd' and 'y'. This patch enables them in the Lexer so that they can be properly parsed.

Re: r337381 - Mention clang-cl improvements from r335466 and r336379 in ReleaseNotes.rst

This is lovely! Found a bit inline... On Wed, Jul 18, 2018, 14:00 Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Wed Jul 18 04:55:03 2018 > New Revision: 337381 > > URL: http://llvm.org/viewvc/llvm-project?rev=337381&view=rev > Log: > Mention clang-cl impro

[PATCH] D49504: Enable C++2a Chrono Literals

mclow.lists added a comment. This looks ok to me - I'm assuming that somewhere there's a test for `int foo = 0x123d`, so we're sure that didn't get broken. Comment at: test/SemaCXX/cxx2a-user-defined-literals.cpp:8 +namespace std { + struct string {}; + namespace chrono { --

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

erichkeane added inline comments. Comment at: include/clang/Basic/Attr.td:851 + let Spellings = [Clang<"cpu_specific">]; + let Args = [VariadicIdentifierArgument<"Cpus">]; + let Subjects = SubjectList<[Function]>; aaron.ballman wrote: > erichkeane wrote: > > a

[PATCH] D49504: Enable C++2a Chrono Literals

erichkeane added a comment. In https://reviews.llvm.org/D49504#1167045, @mclow.lists wrote: > This looks ok to me - I'm assuming that somewhere there's a test for `int foo > = 0x123d`, so we're sure that didn't get broken. The hex_d SHOULD be testing that, it ensures that the RHS is an integer

[PATCH] D49492: Run bounds checking sanitizer earlier to make it easier to optimize away its checks.

efriedma added a comment. Are you sure this will actually do what you want, in general? I suspect it will end up missing bounds checks in some cases because it's running it too early (before mem2reg/inlining/etc). Repository: rC Clang https://reviews.llvm.org/D49492

r337420 - Add support for __declspec(code_seg("segname"))

Author: erichkeane Date: Wed Jul 18 13:04:48 2018 New Revision: 337420 URL: http://llvm.org/viewvc/llvm-project?rev=337420&view=rev Log: Add support for __declspec(code_seg("segname")) This patch uses CodeSegAttr to represent __declspec(code_seg) rather than building on the existing support for

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

ABataev updated this revision to Diff 156139. ABataev added a comment. Renamed function supportsNonDefaultDebugOptions() -> supportsDebugInfoOption(const Arg*). Instead of the enum it accepts and should check one of the debug info options. Repository: rC Clang https://reviews.llvm.org/D4914

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

aaron.ballman added inline comments. Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:23 + +const char DefaultIgnoredValues[] = "0;1;2;10;100;"; + Why 2, 10, and 100? Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:30-32 + for

r337422 - DR330: when determining whether a cast casts away constness, consider

Author: rsmith Date: Wed Jul 18 13:13:36 2018 New Revision: 337422 URL: http://llvm.org/viewvc/llvm-project?rev=337422&view=rev Log: DR330: when determining whether a cast casts away constness, consider qualifiers from all levels matching a multidimensional array. For example, this allows casting

[PATCH] D49457: DR330: when determining whether a cast casts away constness, consider qualifiers from all levels matching a multidimensional array

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC337422: DR330: when determining whether a cast casts away constness, consider (authored by rsmith, committed by ). Reposi

[PATCH] D49504: Enable C++2a Chrono Literals

erichkeane updated this revision to Diff 156143. erichkeane added a comment. @mclow.lists s comments. https://reviews.llvm.org/D49504 Files: lib/Lex/LiteralSupport.cpp test/SemaCXX/cxx2a-user-defined-literals.cpp Index: lib/Lex/LiteralSupport.cpp ==

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from an `assert` than can be removed, this LGTM on the attribute side of things. Comment at: lib/CodeGen/CodeGenModule.cpp:2446 + const auto *FD = cast(

[PATCH] D49508: [CodeGen] VisitMaterializeTemporaryExpr(): don't skip NoOp Casts.

lebedev.ri created this revision. lebedev.ri added reviewers: rsmith, rjmccall, majnemer, efriedma. Herald added a subscriber: cfe-commits. As discussed in PR38166 , we need to be able to distinqush whether the cast we are visiting is actually a cast,

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

lebedev.ri added inline comments. Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:23 + +const char DefaultIgnoredValues[] = "0;1;2;10;100;"; + aaron.ballman wrote: > Why 2, 10, and 100? These really should be a config option. Repository: rCTE Clang T

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric updated this revision to Diff 156146. ioeric marked an inline comment as done. ioeric added a comment. - addressed review comments. - Addressed review comments. Repository: rC Clang https://reviews.llvm.org/D49421 Files: lib/Sema/SemaAccess.cpp lib/Sema/SemaCodeComplete.cpp test

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric added inline comments. Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `AccessedEntity::getAccess` describes what access was used to +// access an entity. aaron.b

[PATCH] D49466: Initial implementation of -fmacro-prefix-mapand -ffile-prefix-map

joerg added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:609 static void addDebugPrefixMapArg(const Driver &D, const ArgList &Args, ArgStringList &CmdArgs) { + for (const Arg *A : Args.filtered(options::OPT_ffile_prefix_map_EQ)) { +StringRef Map = A->getVal

[PATCH] D49360: [analyzer] Add support for more basic_string API in DanglingInternalBufferChecker

NoQ accepted this revision. NoQ added a comment. Let's commit this patch and make another round later, as we gather ideas for better names and messages. https://reviews.llvm.org/D49360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D49360: [analyzer] Add support for more basic_string API in DanglingInternalBufferChecker

NoQ added inline comments. Comment at: test/Analysis/dangling-internal-buffer.cpp:175 std::string s; - { -c = s.c_str(); - } - consume(c); // no-warning + c = s.c_str(); // expected-note {{Pointer to dangling buffer was obtained here}} + s.clear(); // expected-no

[PATCH] D46230: For x86_64, gcc 7.2 under Amazon Linux AMI sets its paths to x86_64-amazon-linux

gaijiading added a comment. In https://reviews.llvm.org/D46230#1167023, @echristo wrote: > In https://reviews.llvm.org/D46230#1166958, @gaijiading wrote: > > > In https://reviews.llvm.org/D46230#1166919, @echristo wrote: > > > > > LGTM. > > > > > > -eric > > > > > > Hi Eric, I do not have commit

  1   2   >