ldionne added inline comments.
================
Comment at: libcxx/CMakeLists.txt:158
+cmake_dependent_option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY_STATIC
+ "Statically link the ABI library to static library" ON
----------------
phosek wrote:
> Maybe `LIBCXX_ENABLE_STATIC_ABI_LIBRARY_IN_STATIC_LIBRARY` would be more
> accurate?
`LIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY` and
`LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY`?
And then
`LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_STATIC_LIBRARY`/`LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY`.
================
Comment at: libcxx/lib/CMakeLists.txt:269
+ AND (TARGET cxxabi_static OR HAVE_LIBCXXABI))
+ #if ((TARGET ${LIBCXX_CXX_ABI_LIBRARY}) OR
+ #(${LIBCXX_CXX_ABI_LIBRARY} MATCHES "cxxabi(_static|_shared)?" AND
HAVE_LIBCXXABI))
----------------
I don't understand why any of this needs to change -- can you please explain?
Also, you probably didn't mean to leave the commented-out lines.
Repository:
rCXX libc++
https://reviews.llvm.org/D49502
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
