erichkeane added a comment.
In https://reviews.llvm.org/D49504#1167045, @mclow.lists wrote:
> This looks ok to me - I'm assuming that somewhere there's a test for `int foo
> = 0x123d`, so we're sure that didn't get broken.
The hex_d SHOULD be testing that, it ensures that the RHS is an integer.
================
Comment at: test/SemaCXX/cxx2a-user-defined-literals.cpp:8
+namespace std {
+ struct string {};
+ namespace chrono {
----------------
mclow.lists wrote:
> Do you need `string` here, or is this a copy-pasto?
Gah, good catch. I was testing something else briefly.
Repository:
rC Clang
https://reviews.llvm.org/D49504
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
