ebevhan updated this revision to Diff 150683.
ebevhan edited the summary of this revision.
ebevhan added a comment.
Added a warning for identical address spaces.
https://reviews.llvm.org/D47630
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaType.cpp
test/Sema/address_space
ebevhan added a comment.
> Well, the documentation mismatch is worth fixing even if the code isn't. But
> I think at best your use-case calls for weakening the assertion to be that
> any existing address space isn't *different*, yeah.
Alright, I'll give that a shot.
> Separately, I'm not sure
arichardson added a comment.
> Well, the documentation mismatch is worth fixing even if the code isn't. But
> I think at best your use-case calls for weakening the assertion to be that
> any existing address space isn't *different*, yeah.
>
> Separately, I'm not sure that's really the right re
takuto.ikuta updated this revision to Diff 150685.
takuto.ikuta added a comment.
Follow llvm style
https://reviews.llvm.org/D47578
Files:
llvm/lib/Support/Windows/Process.inc
llvm/unittests/Support/CommandLineTest.cpp
Index: llvm/unittests/Support/CommandLineTest.cpp
==
takuto.ikuta marked 5 inline comments as done.
takuto.ikuta added a comment.
Rui-san, can I ask you to merge this?
https://reviews.llvm.org/D47578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
djasper added a comment.
The normal rule for formatting options apply. If you can dig up a public style
guide and a project of reasonable size where it is used, we can add an option.
Repository:
rC Clang
https://reviews.llvm.org/D42787
___
cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Sorry for the delay.
Repository:
rC Clang
https://reviews.llvm.org/D43015
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
sammccall added inline comments.
Comment at: clangd/index/Index.h:275
+ /// Contextually relevant files (e.g. the file we're code-completing in).
+ /// Paths should be absolute.
+ std::vector ProximityPaths;
Hmm, the returned results have URIs, not paths.
It
Author: labath
Date: Mon Jun 11 03:28:04 2018
New Revision: 334399
URL: http://llvm.org/viewvc/llvm-project?rev=334399&view=rev
Log:
Move VersionTuple from clang/Basic to llvm/Support
Summary:
This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334399: Move VersionTuple from clang/Basic to llvm/Support
(authored by labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47887?vs=150339&id=150701#toc
Repository:
rL LLVM
h
ioeric added inline comments.
Comment at: clangd/index/Index.h:275
+ /// Contextually relevant files (e.g. the file we're code-completing in).
+ /// Paths should be absolute.
+ std::vector ProximityPaths;
sammccall wrote:
> Hmm, the returned results have URIs,
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/Format/TokenAnnotator.cpp:2942
+ // }
+ //
+ // Be careful to exclude the case [proto.ext] { ... } since the `]` is
One more hig
labath closed this revision.
labath added a comment.
Committed as a part of https://reviews.llvm.org/D47887 via monorepo.
Repository:
rC Clang
https://reviews.llvm.org/D47886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Index.h:275
+ /// Contextually relevant files (e.g. the file we're code-completing in).
+ /// Paths should be absolute.
+ std::vector Pr
balazske added a comment.
I want this change to be committed by somebody. I have no commit right.
Repository:
rC Clang
https://reviews.llvm.org/D47445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: alexfh
Date: Mon Jun 11 05:46:48 2018
New Revision: 334400
URL: http://llvm.org/viewvc/llvm-project?rev=334400&view=rev
Log:
Add support for arrays in performance-implicit-conversion-in-loop
Summary:
Add support for arrays (and structure that use naked pointers for their
iterator, like s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334400: Add support for arrays in
performance-implicit-conversion-in-loop (authored by alexfh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
krasimir updated this revision to Diff 150730.
krasimir marked 5 inline comments as done.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D46757
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/
Author: krasimir
Date: Mon Jun 11 05:53:25 2018
New Revision: 334401
URL: http://llvm.org/viewvc/llvm-project?rev=334401&view=rev
Log:
[clang-format] text protos: put entries on separate lines if there is a
submessage
Summary:
This patch updates clang-format text protos to put entries of a subme
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334401: [clang-format] text protos: put entries on separate
lines if there is a… (authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46757?vs=150730&id=150731#toc
miyuki created this revision.
miyuki added reviewers: aprantl, JDevlieghere.
This patch adds aliases for -Qn (-fno-ident) and -Qy (-fident) which
look less cryptic than -Qn/-Qy. The aliases are compatible with GCC.
https://reviews.llvm.org/D48021
Files:
CodeGen/no-ident-version.c
clang/Driv
Prazek updated this revision to Diff 150735.
Prazek added a comment.
- Fixed templates
Repository:
rL LLVM
https://reviews.llvm.org/D47108
Files:
clang/docs/ClangCommandLineReference.rst
clang/docs/ReleaseNotes.rst
clang/docs/UsersManual.rst
clang/include/clang/Basic/LangOptions.def
russellmcc added a comment.
Bump! Thanks again for your feedback.
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MTC created this revision.
MTC added reviewers: xazax.hun, NoQ, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, rnkovacs, szepet.
`CallDecription` can only handle function for the time being. If we want to
match c++ method, we can only use method name to match and can't im
Typz updated this revision to Diff 150755.
Typz added a comment.
rebase
Repository:
rC Clang
https://reviews.llvm.org/D43015
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
Author: typz
Date: Mon Jun 11 07:41:26 2018
New Revision: 334408
URL: http://llvm.org/viewvc/llvm-project?rev=334408&view=rev
Log:
clang-format: Introduce BreakInheritanceList option
Summary:
This option replaces the BreakBeforeInheritanceComma option with an
enum, thus introducing a mode where t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334408: clang-format: Introduce BreakInheritanceList option
(authored by Typz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43015?vs=150755&id=150756#toc
Repository:
rC Clang
h
MTC added a comment.
The implementation is not complicated, the difficulty is that there is no good
way to get the qualified name without template arguments. For
'std::basic_string::c_str()', its qualified name may be
`std::__1::basic_string,
std::__1::allocator >::c_str`, it is almost impossi
MTC updated this revision to Diff 150758.
MTC added a comment.
Remove useless header files for testing.
Repository:
rC Clang
https://reviews.llvm.org/D48027
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
lib/StaticAnalyzer/Core/CallEvent.cpp
Index: lib/StaticAnalyze
xazax.hun added a comment.
Having C++ support would be awesome!
Thanks for working on this!
While I do agree matching is not trivial with qualified names, this problem is
already solved with AST matchers.
I wonder if using matchers or reusing the `HasNameMatcher` class would make
this easier.
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
It sounds like adding proper support for HLE prefixes is a largeish project.
ctopper, rnk: Do you think it would be worth adding inline asm versions (with
the xacquire/release prefixes) of these intrinsics in the meantime? It would
inhibit optimizations but be better than
GBuella updated this revision to Diff 150767.
GBuella added a comment.
I altered the code, to ignore the the signaling behaviour, as suggested.
Also, it handles more vector cmp builtins now.
https://reviews.llvm.org/D45616
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
test/
GBuella added a comment.
Ping @efriedma
https://reviews.llvm.org/D45616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst created this revision.
mprobst added a reviewer: krasimir.
TypeScript uses the `!` token for strict property initialization
assertions, as in:
class X {
strictPropAsserted!: string;
}
Previously, clang-format would wrap between the `!` and the `:` for
overly long lines. This patc
mprobst updated this revision to Diff 150770.
mprobst added a comment.
fix typo in test
Repository:
rC Clang
https://reviews.llvm.org/D48030
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
=
malaperle added a comment.
Very nice! I tried "std" and got much less (unimportant) results. I see
something a bit weird with "getStandardResourceDir" but it might be VSCode.
Here, I guess it's the "d" in Dir that matches but what's odd is that VS Code
will highlight the first "d", i.e. in "sta
Author: miyuki
Date: Mon Jun 11 09:10:06 2018
New Revision: 334414
URL: http://llvm.org/viewvc/llvm-project?rev=334414&view=rev
Log:
[Driver] Add aliases for -Qn/-Qy
This patch adds aliases for -Qn (-fno-ident) and -Qy (-fident) which
look less cryptic than -Qn/-Qy. The aliases are compatible wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334414: [Driver] Add aliases for -Qn/-Qy (authored by
miyuki, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48021?vs=150732&id=150772#toc
Repository:
rC Clang
https://reviews.ll
Author: mprobst
Date: Mon Jun 11 09:20:13 2018
New Revision: 334415
URL: http://llvm.org/viewvc/llvm-project?rev=334415&view=rev
Log:
clang-format: [JS] strict prop init annotation.
Summary:
TypeScript uses the `!` token for strict property initialization
assertions, as in:
class X {
s
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334415: clang-format: [JS] strict prop init annotation.
(authored by mprobst, committed by ).
Herald added a subscriber: l
ormris marked 2 inline comments as done.
ormris added a comment.
Thanks for the review @MTC! I'll wait for @NoQ's feedback.
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
alexfh added a comment.
Herald added a subscriber: mikhail.ramalho.
This commit seems to have introduced
https://bugs.llvm.org/show_bug.cgi?id=37769. Could you take a look?
Repository:
rL LLVM
https://reviews.llvm.org/D45706
___
cfe-commits mail
Author: rkovacs
Date: Sat Jun 9 14:08:27 2018
New Revision: 334352
URL: http://llvm.org/viewvc/llvm-project?rev=334352&view=rev
Log:
[analyzer] Clean up the program state map of DanglingInternalBufferChecker.
Symbols are cleaned up from the program state map when they go out of scope.
Memory reg
Author: ctopper
Date: Mon Jun 11 09:34:10 2018
New Revision: 334416
URL: http://llvm.org/viewvc/llvm-project?rev=334416&view=rev
Log:
[X86] Properly account for the immediate being multiplied by 8 in the immediate
range checking for BI__builtin_ia32_psrldqi128 and friends.
The limit was set to 1
morehouse added inline comments.
Comment at: tools/clang-fuzzer/cxx_loop_proto.proto:67
-AssignmentStatement assignment = 1;
-IfElse ifelse = 2;
- }
Do you really want to get rid of if-else?
Comment at: tools/clang-fuz
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
IMO using the iterator directly (e.g. like it was done in
https://github.com/l
krasimir created this revision.
Herald added a subscriber: cfe-commits.
Currently clang-format allows this for text protos:
submessage:
{ key: 'aa' }
when it is under the column limit and when putting it all on one line exceeds
the column limit.
This
Author: rnk
Date: Mon Jun 11 09:49:43 2018
New Revision: 334417
URL: http://llvm.org/viewvc/llvm-project?rev=334417&view=rev
Log:
[MS] Use mangled names and comdats for string merging with ASan
This should reduce the binary size penalty of ASan on Windows. After
r334313, ASan will add red zones t
Author: rnk
Date: Mon Jun 11 09:50:07 2018
New Revision: 334418
URL: http://llvm.org/viewvc/llvm-project?rev=334418&view=rev
Log:
Enable crash recovery tests on Windows, globs work in the lit internal shell now
Modified:
cfe/trunk/test/Driver/crash-report-header.h
cfe/trunk/test/Driver/cr
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D47341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
emmettneyman added a comment.
@kcc suggested removing conditionals for now and adding them back later.
include statement was for testing; I'll remove it and resubmit.
Repository:
rC Clang
https://reviews.llvm.org/D47964
___
cfe-commits mailing l
emmettneyman updated this revision to Diff 150783.
emmettneyman added a comment.
- removed include statement meant for testing
Repository:
rC Clang
https://reviews.llvm.org/D47964
Files:
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loop_proto_to_cxx.cpp
Index:
sammccall added a comment.
All else equal, I'd expect this to be a hard rule, at least in google-style.
"foo\n { a: b }" --> "foo {\n a: b\n}" only makes the first line longer, by 2
chars. So if 78 < indent + len("foo") <= 80 we're breaking the line limit, but
that seems vanishingly rare.
If
krasimir added a comment.
In https://reviews.llvm.org/D48034#1128475, @sammccall wrote:
> All else equal, I'd expect this to be a hard rule, at least in google-style.
>
> "foo\n { a: b }" --> "foo {\n a: b\n}" only makes the first line longer, by
> 2 chars. So if 78 < indent + len("foo") <= 80
sammccall added a comment.
In https://reviews.llvm.org/D47950#1128370, @malaperle wrote:
> Very nice! I tried "std" and got much less (unimportant) results. I see
> something a bit weird with "getStandardResourceDir" but it might be VSCode.
> Here, I guess it's the "d" in Dir that matches but w
Author: morehouse
Date: Mon Jun 11 10:05:45 2018
New Revision: 334421
URL: http://llvm.org/viewvc/llvm-project?rev=334421&view=rev
Log:
[clang-fuzzer] Modified protobuf and converter to add new signature, remove
conditionals.
Changed the function signature and removed conditionals from loop body
Author: ctopper
Date: Mon Jun 11 10:06:01 2018
New Revision: 334422
URL: http://llvm.org/viewvc/llvm-project?rev=334422&view=rev
Log:
[X86] Fix operand order in the shuffle created for blend builtins.
This was broken when the builtin was added in r334249.
Modified:
cfe/trunk/lib/CodeGen/CGBu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334421: [clang-fuzzer] Modified protobuf and converter to
add new signature, remove… (authored by morehouse, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47964
Files:
cfe/trunk/tool
ormris added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
george.karpenkov wrote:
> IMO using the iterator directly (e.g. like it was done in
> ht
malaperle added a comment.
In https://reviews.llvm.org/D47950#1128487, @sammccall wrote:
> In https://reviews.llvm.org/D47950#1128370, @malaperle wrote:
>
> > Very nice! I tried "std" and got much less (unimportant) results. I see
> > something a bit weird with "getStandardResourceDir" but it mi
svenvh updated this revision to Diff 150788.
svenvh added a comment.
Dropped 2 redundant uses of `getTypePtr()`; minor formatting changes.
https://reviews.llvm.org/D46651
Files:
lib/Sema/SemaDeclCXX.cpp
lib/Sema/SemaExprCXX.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCLCXX/newdelete.cl
Inde
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
ormris wrote:
> george.karpenkov wrote:
> > IMO using the iterator directly (e.
svenvh added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+ }
+}
rjmccall wrote:
> Anastasia wrote:
> > svenvh wrote:
> > > rjmccall wrote:
> > > > I think a better interpretation of this rule would be to just error on
> > > > attempts t
jlebar created this revision.
jlebar added a reviewer: rsmith.
Herald added a subscriber: sanjoy.
Fixes PR37753: min/max can't be called from __host__ __device__
functions in C++14 mode.
Testcase in a separate test-suite commit.
https://reviews.llvm.org/D48036
Files:
clang/lib/Headers/cuda_w
jlebar created this revision.
jlebar added a reviewer: rsmith.
Herald added subscribers: llvm-commits, sanjoy.
Tests for https://reviews.llvm.org/D48036 / PR37753.
Repository:
rT test-suite
https://reviews.llvm.org/D48037
Files:
External/CUDA/algorithm.cu
Index: External/CUDA/algorithm.c
tzik added a comment.
rsmith: ping. Any chance you could review this?
Repository:
rC Clang
https://reviews.llvm.org/D47586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Wizard created this revision.
Herald added a subscriber: cfe-commits.
Wizard edited the summary of this revision.
Wizard added reviewers: benhamilton, hokein.
Now we can support property names like "hasADog" correctly.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48039
Files:
erichkeane created this revision.
erichkeane added reviewers: eli.friedman, rjmccall.
As requested here:https://bugs.llvm.org/show_bug.cgi?id=37633
permit the __builtin_*_overflow builtins in constexpr functions.
Repository:
rC Clang
https://reviews.llvm.org/D48040
Files:
lib/AST/ExprCons
rjmccall added a comment.
In https://reviews.llvm.org/D47627#1127716, @ebevhan wrote:
> > Well, the documentation mismatch is worth fixing even if the code isn't.
> > But I think at best your use-case calls for weakening the assertion to be
> > that any existing address space isn't *different*
rjmccall accepted this revision.
rjmccall added a comment.
LGTM.
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+ }
+}
svenvh wrote:
> rjmccall wrote:
> > Anastasia wrote:
> > > svenvh wrote:
> > > > rjmccall wrote:
> > > > > I think a better interpretati
rjmccall added inline comments.
Comment at: lib/AST/ExprConstant.cpp:8260
+ // It won't GROW, since that isn't possible, so use this to allow
+ // TruncOrSelf.
+ APSInt Temp = Result.extOrTrunc(Info.Ctx.getTypeSize(ResultType));
The comment should
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Ok.
https://reviews.llvm.org/D47733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
lei created this revision.
lei added reviewers: hfinkel, kbarton, nemanjai, power-llvm-team.
Update clang to treat fp128 as a valid base type for homogeneous aggregate
passing and returning.
https://reviews.llvm.org/D48044
Files:
include/clang/AST/Type.h
lib/CodeGen/TargetInfo.cpp
test/C
erichkeane updated this revision to Diff 150808.
erichkeane marked an inline comment as done.
https://reviews.llvm.org/D48040
Files:
lib/AST/ExprConstant.cpp
lib/Sema/SemaChecking.cpp
test/SemaCXX/builtins-overflow.cpp
Index: lib/AST/ExprConstant.cpp
===
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
Can you split this change into a separate patch? Testcase:
```
int a() {
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
efriedma wrote:
> Can you split this change into a separate patch? Testcas
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#1125489, @vlad.tsyrklevich wrote:
> Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this
> revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix
> under review in https://reviews.llvm.org/D478
dexonsmith added a comment.
In https://reviews.llvm.org/D47687#1127120, @Higuoxing wrote:
> In https://reviews.llvm.org/D47687#1126607, @dexonsmith wrote:
>
> > In https://reviews.llvm.org/D47687#1126074, @lebedev.ri wrote:
> >
> > > In https://reviews.llvm.org/D47687#1126032, @Higuoxing wrote:
>
Author: vsapsai
Date: Mon Jun 11 12:42:27 2018
New Revision: 334431
URL: http://llvm.org/viewvc/llvm-project?rev=334431&view=rev
Log:
Mark the test using to require c++experimental.
When built against the old libc++ version the test was causing linker error
Undefined symbols for architecture x8
gtbercea marked 3 inline comments as done.
gtbercea added inline comments.
Comment at: include/clang/Driver/Compilation.h:312
+ /// \param skipBundler - bool value set once by the driver.
+ void setSkipOffloadBundler(bool skipBundler);
+
sfantao wrote:
> Why is
lei updated this revision to Diff 150821.
https://reviews.llvm.org/D48044
Files:
include/clang/AST/Type.h
lib/CodeGen/TargetInfo.cpp
test/CodeGen/ppc64le-f128Aggregates.c
Index: test/CodeGen/ppc64le-f128Aggregates.c
===
--- /d
NoQ added a comment.
In https://reviews.llvm.org/D47671#1127486, @xazax.hun wrote:
> Just for the record, there is a common example where relying on copy elision
> might bite and google do not recommend relying on it for correctness:
> https://abseil.io/tips/120
>
> The main purpose of sharing
rnk added a comment.
In https://reviews.llvm.org/D47672#1128308, @hans wrote:
> It sounds like adding proper support for HLE prefixes is a largeish project.
>
> ctopper, rnk: Do you think it would be worth adding inline asm versions (with
> the xacquire/release prefixes) of these intrinsics in t
george.burgess.iv closed this revision.
george.burgess.iv added a comment.
Herald added a subscriber: JDevlieghere.
(Committed as noted by echristo; just trying to clean my queue a bit. :) )
https://reviews.llvm.org/D30760
___
cfe-commits mailing li
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
erichkeane wrote:
> efriedma wrote:
> > Can you split this change into a sepa
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
efriedma wrote:
> erichkeane wrote:
> > efriedma wrote:
> > > Can you split
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
I prefer `DEPS` to `COMPONENTS` because I've tried to explicitly use the term
components to mean targets that have paired build and install targets.
Otherwise looks good.
Repository:
rC Clan
Author: phosek
Date: Mon Jun 11 13:59:31 2018
New Revision: 334437
URL: http://llvm.org/viewvc/llvm-project?rev=334437&view=rev
Log:
[CMake] Allow specifying extra dependencies of bootstrap stage
This allows adding additional bootstrap dependencies to the bootstrap
compiler that may be needed by
phosek updated this revision to Diff 150838.
phosek marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D47355
Files:
clang/CMakeLists.txt
Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
++
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334437: [CMake] Allow specifying extra dependencies of
bootstrap stage (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47
phosek updated this revision to Diff 150841.
Repository:
rC Clang
https://reviews.llvm.org/D47356
Files:
clang/cmake/caches/Fuchsia.cmake
Index: clang/cmake/caches/Fuchsia.cmake
===
--- clang/cmake/caches/Fuchsia.cmake
+++ cla
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This makes much more sense. Thanks @joerg
https://reviews.llvm.org/D38680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
erichkeane created this revision.
erichkeane added a reviewer: eli.friedman.
Enable these builtins to be called across a lambda
boundary, as brought up by Eli here: https://reviews.llvm.org/D48040
Repository:
rC Clang
https://reviews.llvm.org/D48053
Files:
lib/Sema/SemaChecking.cpp
test/
erichkeane added a comment.
Alright, done here: https://reviews.llvm.org/D48053
This one'll require some rebasing on that change, but I'm not sure how to do it
in SVN. Therefore, I'll just rebase this one when it comes to commit it.
-Erich
https://reviews.llvm.org/D48040
_
vsapsai added a comment.
With this change and the mentioned libc++ change the tests with old libc++
dylib are passing (didn't test all possible configurations though). Would like
to get more feedback from other reviewers on this matter.
https://reviews.llvm.org/D45015
__
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10071
+ // is _MM_FROUND_CUR_DIRECTION
+ if (cast(Ops[4])->getZExtValue() != 4)
+UsesNonDefaultRounding = true;
Given we're ignoring floating-point exceptions, we should also
rsmith added a comment.
We need to figure out what should happen in the OpenCL case, but the rest seems
fine.
Comment at: lib/Sema/SemaChecking.cpp:3360
}
-if (AtomTy.isConstQualified() ||
+if ((Form != Load && Form != LoadCopy && AtomTy.isConstQualified()) ||
efriedma added a reviewer: rsmith.
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:228
+ S.getASTContext(), Ty, /*consume*/ false);
+ Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+ TheCall->setArg(2, Arg.get());
--
rjmccall added a comment.
Thanks, comment change looks good. LGTM.
https://reviews.llvm.org/D48040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 124 matches
Mail list logo
