sammccall added inline comments.
================ Comment at: clangd/index/Index.h:275 + /// Contextually relevant files (e.g. the file we're code-completing in). + /// Paths should be absolute. + std::vector<std::string> ProximityPaths; ---------------- Hmm, the returned results have URIs, not paths. It seems cleaner that the query params be URIs too. However then we need a way to know which scheme the index expects. It could expose this information, or the index could accept a path here and do the conversion itself. This indexes need to be "thick" and deal with the URI infrastructure, but may be the simplest way. What's your thinking here? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47937 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
