george.karpenkov added inline comments.
================ Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89 + new Callback(LCtx, MRMgr, ITraits)); + Finder.matchAST(ASTCtx); + ---------------- ormris wrote: > george.karpenkov wrote: > > IMO using the iterator directly (e.g. like it was done in > > https://github.com/llvm-mirror/clang/blob/master/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp#L213) > > leads to a much cleaner code and saves you from having to define a > > callback class. > Hmm... I think that's a better approach. Let me see if I can get that working. @ormris Yeah I'm really not sure why all examples use the callback API by default. Repository: rC Clang https://reviews.llvm.org/D47044 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
