[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

lebedev.ri added a comment. While i don't have a leg to stand on here, i'd be *much* more comfortable if this would be a proper RFC mail in cfe-dev, that would explore all the possible options (this, and the one from cfe-dev thread clang-tidy and CppCoreGuidelines

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3942 ActOnSkippedFunctionBody(Function); + // FIXME: finishing the function body while in an expres

[PATCH] D44305: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

ioeric added inline comments. Comment at: clangd/index/Merge.cpp:69 + else +B.insert(mergeSymbol(*Sym, S, &Scratch)); +}); sammccall wrote: > This could also just be callback(mergeSymbol(...)), if we keep track of the > IDs we've emitted. > This

[PATCH] D44305: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

ioeric updated this revision to Diff 138313. ioeric marked 5 inline comments as done. ioeric added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44305 Files: clangd/index/FileIndex.cpp clangd/index/FileIndex.h clangd/index/Index.h

[PATCH] D44305: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327487: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.or

[clang-tools-extra] r327487 - [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

Author: ioeric Date: Wed Mar 14 02:48:05 2018 New Revision: 327487 URL: http://llvm.org/viewvc/llvm-project?rev=327487&view=rev Log: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex. Summary: Potential use case: argument go-to-definition result with symbol information (e.g.

r327491 - StaticAnalyzer: fix compiler warning. NFC

Author: labath Date: Wed Mar 14 03:16:40 2018 New Revision: 327491 URL: http://llvm.org/viewvc/llvm-project?rev=327491&view=rev Log: StaticAnalyzer: fix compiler warning. NFC My compiler (clang-3.8) complains that the RCC variable is unused. That's not really true, as it's checked by the if-decla

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig marked an inline comment as done. SimeonEhrig added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > Please explai

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Test case for this change? Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3944 + // context seems wrong. Investigate more. + ActOnFini

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, klimek. To make the removal of DraftMgr from ClangdServer easier (https://reviews.llvm.org/D44408). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44

[PATCH] D44463: [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, klimek. It previously an easy way to concurrently access a mutable vfs, which is a recipe for disaster. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

ilya-biryukov added a reviewer: ilya-biryukov. ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. We shouldn't add `Contents` parameter to every method, it would defeat the purpose of caching ASTs and won't allow to prop

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

ilya-biryukov added a comment. I also came up with a test case, but it breaks because of invalid errors when function bodies are skipped. I'll make sure to include it along with a fix for the errors in a follow-up patch. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:39

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

ilya-biryukov updated this revision to Diff 138333. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Addressed review comments Repository: rC Clang https://reviews.llvm.org/D44439 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp Index: lib/Sema/SemaTemplate

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the explanation about the tests. Repository: rC Clang https://reviews.llvm.org/D44439 ___ cfe-commits mailin

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

ilya-biryukov added a comment. @aaron.ballman , here's a test-case I came up with. I'll fix the other issue (invalid error, that forces the test to fail) and submit it for review along with the fix for the error. Does that SG? template auto make_func() { struct impl { impl* func(

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

aaron.ballman added a comment. In https://reviews.llvm.org/D44439#1036868, @ilya-biryukov wrote: > @aaron.ballman , here's a test-case I came up with. I'll fix the other issue > (invalid error, that forces the test to fail) and submit it for review along > with the fix for the error. Does that

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 138335. Rakete added a comment. > Did you forget to upload the updated patch? This looks unchanged compared to > the prior version. Whoops, that's true. Sorry... https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete added a comment. @rsmith Which type specifiers should I test for? just `T`? Or also `T*`, `T&`, ...? Now I'm just checking for an identifier, but anything else would make the lookahead more complicated I think. Any ideas? https://reviews.llvm.org/D36357 __

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark added a comment. In https://reviews.llvm.org/D44408#1036846, @ilya-biryukov wrote: > We shouldn't add `Contents` parameter to every method, it would defeat the > purpose of caching ASTs and won't allow to properly manage lifetimes of the > indexes. Makes sense. > The most tricky part

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Rakete updated this revision to Diff 138337. Rakete added a comment. Rebase and ping :) https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseStmt.cpp lib/

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added a comment. Once the base differential firmly lands, could you please rebase this so the review could continue? https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r327504 - [Sema] Pop function scope when instantiating a func with skipped body

Author: ibiryukov Date: Wed Mar 14 06:18:30 2018 New Revision: 327504 URL: http://llvm.org/viewvc/llvm-project?rev=327504&view=rev Log: [Sema] Pop function scope when instantiating a func with skipped body Summary: By calling ActOnFinishFunctionBody(). Previously we were only calling ActOnSkipped

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

This revision was automatically updated to reflect the committed changes. Closed by commit rC327504: [Sema] Pop function scope when instantiating a func with skipped body (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44439?vs=138333&id=138338#toc Re

[PATCH] D44188: Misc typos

luzpaz added a comment. Please advise how to proceed Repository: rC Clang https://reviews.llvm.org/D44188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

Rakete updated this revision to Diff 138339. Rakete added a comment. Rebase and ping :) https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/CXX/stmt.stmt/stmt.select/p3.cpp Index: test/CXX/stmt.stmt/stmt.select/p3.cpp =

[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

alexfh added a comment. I apologize for completely ignoring this for a long time. I'm totally fine taking full control of clang-diagnostic- "checks", i.e. automatically adding corresponding -W flags and removing all other -W flags (or prepending -Wno-everything). However, could we split the al

[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

alexfh added a comment. In https://reviews.llvm.org/D38171#1036893, @alexfh wrote: > I'm totally fine taking full control of clang-diagnostic- "checks", i.e. > automatically adding corresponding -W flags and removing all other -W flags > (or prepending -Wno-everything). > > However, could we sp

[PATCH] D38171: [clang-tidy] Implement clang-tidy check aliases

alexfh added inline comments. Comment at: test/clang-tidy/misc-suspicious-semicolon-fail.cpp:5 -// RUN: clang-tidy %s -checks="-*,misc-suspicious-semicolon,clang-diagnostic*" \ -// RUN:-- -DWERROR -Wno-everything -Werror=unused-variable 2>&1 \ // RUN: | FileCheck %s -chec

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LGTM https://reviews.llvm.org/D40445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D44463: [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/TUScheduler.h:94 /// Schedule an async read of the Preamble. Preamble passed to \p Action may /// be built for any version of the file, c

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

lebedev.ri added a comment. Let's move weekly ping away from friday :) Ping. Repository: rC Clang https://reviews.llvm.org/D43162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

simark accepted this revision. simark added a comment. This revision is now accepted and ready to land. I rebased my patch (https://reviews.llvm.org/D44408) on top of this one, it looks good. Comment at: clangd/ClangdServer.cpp:143 + tooling::CompileCommand NewCommand = Compi

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark updated this revision to Diff 138344. simark added a comment. Rebase on https://reviews.llvm.org/D44462 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44408 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark added a comment. I don't see how to avoid adding the Contents parameter to the codeComplete and signatureHelp methods, since they needed to fetch the document from the draft manager and pass it to the backend. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44408

r327513 - [OpenMP] Add OpenMP data sharing infrastructure using global memory

Author: gbercea Date: Wed Mar 14 07:17:45 2018 New Revision: 327513 URL: http://llvm.org/viewvc/llvm-project?rev=327513&view=rev Log: [OpenMP] Add OpenMP data sharing infrastructure using global memory Summary: This patch handles the Clang code generation phase for the OpenMP data sharing infras

[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

This revision was automatically updated to reflect the committed changes. Closed by commit rL327513: [OpenMP] Add OpenMP data sharing infrastructure using global memory (authored by gbercea, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D43660: [OpenMP] Add OpenMP data sharing infrastructure using global memory

This revision was automatically updated to reflect the committed changes. Closed by commit rC327513: [OpenMP] Add OpenMP data sharing infrastructure using global memory (authored by gbercea, committed by ). Repository: rC Clang https://reviews.llvm.org/D43660 Files: lib/CodeGen/CGDecl.cpp

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

sammccall added a comment. This patch is the right direction, but if you're up for it we can simplify interfaces further I think. Comment at: clangd/TUScheduler.h:62 + /// Returns a list of currently tracked files. File starts being trakced on + /// first update() call to

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a testing nit. Comment at: test/SemaCXX/extra-semi.cpp:14 +void F(){} +; // expected-warning {{extra ';' outside of a function is}} + --

[PATCH] D31308: [clang-tidy] new check readability-no-alternative-tokens

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Herald added a subscriber: xazax.hun. As noted above, my concern with the current implementation is that the use of AST in this check seems to be superfluous. It should be enough to h

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

simark added inline comments. Comment at: clangd/TUScheduler.h:69 + /// FIXME: remove the callback from this function + void updateCompileCommand(PathRef File, tooling::CompileCommand NewCommand, +IntrusiveRefCntPtr FS, sammccall wro

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

lebedev.ri added inline comments. Comment at: test/SemaCXX/extra-semi.cpp:14 +void F(){} +; // expected-warning {{extra ';' outside of a function is}} + aaron.ballman wrote: > Can you use the full diagnostic text for this first appearance in the test? Will requir

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

Rakete added a comment. @rsmith Can you commit please? https://reviews.llvm.org/D40445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1036394, @nathawes wrote: > @malaperle Just to clarify, what's the particular end-loc we're talking about > here? e.g. for a function call, would this be the end of the function's name, > or the closing paren? > For the end of the

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

sammccall added inline comments. Comment at: clangd/ClangdServer.cpp:143 + tooling::CompileCommand NewCommand = CompileArgs.getCompileCommand(File); + DocVersion Version = DraftMgr.getVersion(File); + Path FileStr = File.str(); simark wrote: > I was wondering

r327515 - CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

Author: yaxunl Date: Wed Mar 14 08:02:28 2018 New Revision: 327515 URL: http://llvm.org/viewvc/llvm-project?rev=327515&view=rev Log: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946 Recent change r326946 (https://reviews.llvm.org/D34367) causes regression in E

[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

This revision was automatically updated to reflect the committed changes. Closed by commit rC327515: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting… (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D5?vs=138252&id=138358#toc

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud added a comment. Hi, I think all requested modifications were done. Regards, Fred https://reviews.llvm.org/D43766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327516 - Add deep AST tree test for r327515

Author: yaxunl Date: Wed Mar 14 08:03:31 2018 New Revision: 327516 URL: http://llvm.org/viewvc/llvm-project?rev=327516&view=rev Log: Add deep AST tree test for r327515 Added: cfe/trunk/test/CodeGenCXX/deep-ast-tree.cpp Added: cfe/trunk/test/CodeGenCXX/deep-ast-tree.cpp URL: http://llvm.org/

[PATCH] D33537: [clang-tidy] Exception Escape Checker

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs. Is there a more specific module for this check than misc? For example, does it check a rule that happens to appear in a certain coding standard? O

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Should the check be in "bugprone-" instead? https://reviews.llvm.org/D33470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

alexfh removed a reviewer: Prazek. alexfh added 1 blocking reviewer(s): hokein. alexfh added a comment. A couple of nits. Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:42-44 + if (RequireCPlusPlus14) +return LangOpts.CPlusPlus14; + return LangOpts.CPlusPlus11;

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Removing from my dashboard until the licensing stuff gets sorted out. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D36836 ___

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

alexfh added a comment. Do you want to submit the matcher part separately? https://reviews.llvm.org/D38921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40937: [clang-tidy] Infinite loop checker

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Please move this check to "bugprone-", since it seems to be an appropriate category for this check. https://reviews.llvm.org/D40937 __

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

alexfh accepted this revision. alexfh added a comment. LG. Thank you! BTW, there's an old related patch https://reviews.llvm.org/D17043, which mostly focuses on member functions of STL containers. It might be useful as a reference (there's a pretty extensive list of member functions and contain

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

alexfh added a comment. Do you need help committing the patch? https://reviews.llvm.org/D41655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327528 - Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

Author: marsupial Date: Wed Mar 14 09:04:45 2018 New Revision: 327528 URL: http://llvm.org/viewvc/llvm-project?rev=327528&view=rev Log: Expand clang-interpreter with example of throwing in and from the JIT for Windows64. Summary: Getting this to work is not particularly obvious, and having it as

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

This revision was automatically updated to reflect the committed changes. Closed by commit rC327528: Expand clang-interpreter with example of throwing in and from the JIT for… (authored by marsupial, committed by ). Repository: rC Clang https://reviews.llvm.org/D35103 Files: examples/clang-

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Herald added a subscriber: xazax.hun. It looks like all concerns were resolved. LG, if you still want to proceed with this patch. https://reviews.llvm.org/D23130 __

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

ilya-biryukov created this revision. ilya-biryukov added reviewers: aaron.ballman, sammccall. Skipping them was clearly not intentional. It's impossible to guarantee correctness if the bodies are skipped. Also adds a test case for r327504, now that it does not produce invalid errors that made the

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added a comment. I'd like to, but I don't know when I find time to rebase this thing after more than a year of waiting for review. https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:24-25 + const CXXRecordDecl *ThisClass) { + assert(Parent); + assert(ThisClas

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138392. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing tests and updating docs https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov updated this revision to Diff 138394. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Remove TUScheduler::updateCompileCommands, add a new optional parameter to clear the cache of compile commands instead - Address review comments Repository: rCT

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.h:69 + /// FIXME: remove the callback from this function + void updateCompileCommand(PathRef File, tooling::CompileCommand NewCommand, +IntrusiveRefCntPtr FS, sammcc

r327529 - Attempt to fix failure of deep-ast-tree.cpp on ppc64 and atom

Author: yaxunl Date: Wed Mar 14 09:47:49 2018 New Revision: 327529 URL: http://llvm.org/viewvc/llvm-project?rev=327529&view=rev Log: Attempt to fix failure of deep-ast-tree.cpp on ppc64 and atom Modified: cfe/trunk/test/CodeGenCXX/deep-ast-tree.cpp Modified: cfe/trunk/test/CodeGenCXX/deep-as

r327531 - [CMake] Properly quote string arguments to quiet errors from r327528 when built

Author: marsupial Date: Wed Mar 14 09:56:02 2018 New Revision: 327531 URL: http://llvm.org/viewvc/llvm-project?rev=327531&view=rev Log: [CMake] Properly quote string arguments to quiet errors from r327528 when built with LLVM_ENABLE_EH and LLVM_ENABLE_RTTI. Modified: cfe/trunk/examples/clang-

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

sammccall accepted this revision. sammccall added inline comments. Comment at: clangd/TUScheduler.cpp:220 +FileInputs = std::move(Inputs); +rebuildASTLocked(WantDiags, std::move(OnUpdated)); }; you might want to inline this function here again - it's n

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

ilya-biryukov added a comment. In https://reviews.llvm.org/D44408#1036941, @simark wrote: > I don't see how to avoid adding the Contents parameter to the codeComplete > and signatureHelp methods, since they needed to fetch the document from the > draft manager and pass it to the backend. You

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. In https://reviews.llvm.org/D39050#1037008, @malaperle wrote: > In https://reviews.llvm.org/D39050#1036394, @nathawes wrote: > > > @malaperle Just to clarify, what's the particular end-loc we're talking > > about here? e.g. for a function call, would this be the end of

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov updated this revision to Diff 138397. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Add WantDiagnostics param to runAddDocument - Revert changes in TUScheduler Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44462 Files: clangd/

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov added inline comments. Comment at: unittests/clangd/SyncAPI.h:23 +void runAddDocument(ClangdServer &Server, PathRef File, StringRef Contents, +bool SkipCache = false); sammccall wrote: > it's slightly odd that wantdiagnostics i

[clang-tools-extra] r327532 - [clangd] Remove forceReparse, add a flag to addDocument instead

Author: ibiryukov Date: Wed Mar 14 10:08:41 2018 New Revision: 327532 URL: http://llvm.org/viewvc/llvm-project?rev=327532&view=rev Log: [clangd] Remove forceReparse, add a flag to addDocument instead Summary: To make the removal of DraftMgr from ClangdServer easier (D44408). Reviewers: sammccall

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327532: [clangd] Remove forceReparse, add a flag to addDocument instead (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud updated this revision to Diff 138398. ftingaud added a comment. Clean code along code review recommendations. https://reviews.llvm.org/D43766 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h clang-tidy/modernize/MakeUniqueCheck.cpp clan

[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

bsdjhb added a comment. @sdardis ping. I think the approach I've used for O32 is probably the right one in that it matches what DWARF expects (DWARF doesn't treat the 32-bit floating point registers as pairs but as individual registers). I think the question is if I O32 with 32-bit FP registe

[PATCH] D43967: [ASTImporter] Add test helper Fixture

a.sidorin added a comment. Hello Gabor, Sorry for the delay with review: the patch is pretty big and it was hard to find time for reviewing it. I like the patch but it requires some cleanup like formatting changes. Could you please clang-format new code? Also, I'd like to avoid code duplication

[PATCH] D44188: Misc typos

tra added a comment. You may want to split the patch into smaller pieces -- per leaf directory, for example. That way potential reviewers would at least be able to see the changes (hundreds of files in one patch is a bit too much), and the subset of changes would be small enough for someone to

[PATCH] D41217: [Concepts] Concept Specialization Expressions

faisalv added inline comments. Comment at: include/clang/AST/ExprCXX.h:4416 +/// According to C++2a [expr.prim.id]p3 an id-expression that denotes the +/// specialization of a concepts results in a prvalue of type bool. +class ConceptSpecializationExpr final : public Expr { -

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName SimeonEhrig wrote: > tra wrote: > > SimeonEhrig wrote: > > > rjmccall wrote: > >

[PATCH] D44463: [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

ilya-biryukov updated this revision to Diff 138409. ilya-biryukov added a comment. - Rebase on top of master - Add the suggested comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44463 Files: clangd/ClangdServer.cpp clangd/TUScheduler.cpp clangd/TUScheduler.h unitt

[PATCH] D44482: Set dso_local for NSConcreteStackBlock

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44482 Files: lib/CodeGen/CGBlocks.cpp test/CodeGen/blocks-windows.c Index: test/CodeGen/blocks-windows.c === --- test/CodeGen/

[clang-tools-extra] r327537 - [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

Author: ibiryukov Date: Wed Mar 14 10:46:52 2018 New Revision: 327537 URL: http://llvm.org/viewvc/llvm-project?rev=327537&view=rev Log: [clangd] Don't expose vfs in TUScheduler::runWithPreamble. Summary: It was previously an easy way to concurrently access a mutable vfs, which is a recipe for dis

[PATCH] D44463: [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327537: [clangd] Don't expose vfs in TUScheduler::runWithPreamble. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44463?vs=138409&id=138411#toc Repository:

[clang-tools-extra] r327539 - [clangd] Fix indentation in the comment. NFC

Author: ibiryukov Date: Wed Mar 14 10:49:19 2018 New Revision: 327539 URL: http://llvm.org/viewvc/llvm-project?rev=327539&view=rev Log: [clangd] Fix indentation in the comment. NFC Modified: clang-tools-extra/trunk/clangd/TUScheduler.h Modified: clang-tools-extra/trunk/clangd/TUScheduler.h U

[PATCH] D44482: Set dso_local for NSConcreteStackBlock

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding Richard as a reviewer, because this seems somewhat clever to me (so there may be a better change to make). Comment at: lib/Sema/SemaDecl.cpp:12611 +// false on C++14's auto return type without tr

[PATCH] D44233: Set dso_local on external rtti GVs

rnk accepted this revision. rnk added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2618-2620 +const CXXRecordDecl *RD = nullptr; +if (const auto *RecordTy = dyn_cast(Ty)) + RD = cast(RecordTy->getDecl());

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman added inline comments. Comment at: clang-tidy/zircon/TemporaryObjectsCheck.cpp:51 + "creating a temporary object of type %0 is prohibited") +<< D->getConstructor()->getParent()->getQualifiedNameAsString(); +} aaron.ballman wrote: > Y

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:44 +CheckFactories.registerCheck( +"fuchsia-zx-temporary-objects"); } aaron.ballman wrote: > Do we want a zircon module instead? I'm wondering about people who

[PATCH] D44484: [clangd] Use Contents from inputs in codeComplete and signatureHelp

simark created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. ClangdServer::{codeComplete,signatureHelp} both use the Contents from the draft manager. Since we want to move the draft manager from ClangdServer to ClangdLSPServer, this patch cha

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark added a comment. In https://reviews.llvm.org/D44408#1037327, @ilya-biryukov wrote: > In https://reviews.llvm.org/D44408#1036941, @simark wrote: > > > I don't see how to avoid adding the Contents parameter to the codeComplete > > and signatureHelp methods, since they needed to fetch the do

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman added inline comments. Comment at: clang-tidy/zircon/TemporaryObjectsCheck.cpp:51 + "creating a temporary object of type %0 is prohibited") +<< D->getConstructor()->getParent()->getQualifiedNameAsString(); +} aaron.ballman wrote: > a

r327543 - Set dso_local on external rtti GVs.

Author: rafael Date: Wed Mar 14 11:14:46 2018 New Revision: 327543 URL: http://llvm.org/viewvc/llvm-project?rev=327543&view=rev Log: Set dso_local on external rtti GVs. In this particular case it would be possible to just add an else with CGM.setDSOLocal(GV), but it seems better to have as many c

[PATCH] D44233: Set dso_local on external rtti GVs

espindola closed this revision. espindola added a comment. r327543 https://reviews.llvm.org/D44233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. SimeonEhrig wrote: > tra wrote: > > I d

r327544 - Set dso_local for NSConcreteStackBlock.

Author: rafael Date: Wed Mar 14 11:19:26 2018 New Revision: 327544 URL: http://llvm.org/viewvc/llvm-project?rev=327544&view=rev Log: Set dso_local for NSConcreteStackBlock. Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp cfe/trunk/test/CodeGen/blocks-windows.c Modified: cfe/trunk/lib/CodeGe

r327545 - [www] Update C++ DR status to match latest issues list.

Author: rsmith Date: Wed Mar 14 11:19:41 2018 New Revision: 327545 URL: http://llvm.org/viewvc/llvm-project?rev=327545&view=rev Log: [www] Update C++ DR status to match latest issues list. Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL: http://llvm

  1   2   >