sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/TUScheduler.h:94 /// Schedule an async read of the Preamble. Preamble passed to \p Action may /// be built for any version of the file, callers must not rely on it being ---------------- I think this is the right place to describe the way FS interaction works (which implies why we don't propagate vfs): ``` /// The preamble may be stale, generated from an older version of the file. /// Reading from locations in the preamble may cause the files to be re-read. /// This gives callers two options: /// - validate that the preamble is still valid, and only use it in this case /// - accept that preamble contents may be outdated, and try to avoid reading source code from headers. ``` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44463 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
