sammccall accepted this revision. sammccall added inline comments.
================ Comment at: clangd/TUScheduler.cpp:220 + FileInputs = std::move(Inputs); + rebuildASTLocked(WantDiags, std::move(OnUpdated)); }; ---------------- you might want to inline this function here again - it's not overly long, and we're now back to one callsite ================ Comment at: unittests/clangd/SyncAPI.h:23 +void runAddDocument(ClangdServer &Server, PathRef File, StringRef Contents, + bool SkipCache = false); ---------------- it's slightly odd that wantdiagnostics is missing here. Previously this was "forwards compatible" and could easily be added later. But now we'll have callsites that pass different arguments than addDocument takes. Maybe just add the defaulted param to the signature? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44462 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
