[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak updated this revision to Diff 127591. ahatanak added a comment. Address review comments. Changed the mangling of special functions to make it a bit easier to read. https://reviews.llvm.org/D41228 Files: docs/LanguageExtensions.rst include/clang/AST/Decl.h include/clang/AST/Type.

[clang-tools-extra] r321106 - [clangd] Don't use the optional "severity" when comparing Diagnostic.

Author: hokein Date: Tue Dec 19 12:52:56 2017 New Revision: 321106 URL: http://llvm.org/viewvc/llvm-project?rev=321106&view=rev Log: [clangd] Don't use the optional "severity" when comparing Diagnostic. Summary: We use Diagnostic as a key to find the corresponding FixIt when we do the "apply-fix"

[PATCH] D41280: [clangd] Don't use the optional "severity" when comparing Diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE321106: [clangd] Don't use the optional "severity" when comparing Diagnostic. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D41280?vs=127586&id=127595#toc Re

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:315 +} + } } rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > Do these functions have a memcpy as a precondition? I would expect the

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

There was a discussion in lldb-dev mailing list on this topic and I suppose a reliable solution was suggested [1]. It is to generate DW_AT_linkage_name for vtable DIE of a class and provide an additional accelerator table. I am going to try to implement this approach (it will require some work

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

Yep, could be worth having a conversation with the GDB folks and/or at least poke the other LLVM debug info folks (Adrian and Paul - Paul's pretty interesting since he works with/on another (not LLDB nor GDB) debugger which would have to think about this functionality/feature/issue/data/limitation)

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:315 +} + } } ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > > rjmccall wrote: > > > > Do these functions have a memcpy as a precondit

[PATCH] D41412: [libcxx] implement concat() and split()

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. This patch implements the extended version (see P0820) of P0214 concat() and split(). https://reviews.llvm.org/D41412 Files: libcxx/include/experimental/simd libcxx/test/std/exper

[PATCH] D41405: Fix an assertion failure regression in isDesignatorAtObjectEnd for __builtin_object_size with incomplete array type in struct

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. LGTM assuming my nit gets addressed. Thank you! > Maybe someone who's more familiar with this builtin could point to the cause > of this discrepancy Yeah, the documenta

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

Sorry, I am quite new to the process. It seems, Adrian and Paul are in the reviewers/subscribers list to the original review (https://reviews.llvm.org/D39622). Should I do something else? 19.12.2017 23:06, David Blaikie wrote: Yep, could be worth having a conversation with the GDB folks and/or

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

Not much - I've put them on this part of the thread specifically to raise attention. If it doesn't get visibility here, maybe a cfe-dev thread would be good. On Tue, Dec 19, 2017 at 1:33 PM Anton Gorenkov wrote: > Sorry, I am quite new to the process. It seems, Adrian and Paul are in the > re

RE: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

On the lldb-dev thread I thought this was a reasonable idea (DW_AT_linkage_name on types) but given the use-case, probably best to confine it to classes with vtables? If there's a broader use-case it wasn't clear from the other thread; there it was reported that LLDB really only uses the mangle

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

On Tue, Dec 19, 2017 at 1:50 PM Robinson, Paul wrote: > On the lldb-dev thread I thought this was a reasonable idea > (DW_AT_linkage_name on types) but given the use-case, probably best to > confine it to classes with vtables? If there's a broader use-case it > wasn't clear from the other thread

r321115 - Silence a bunch of implicit fallthrough warnings

Author: adrian Date: Tue Dec 19 14:06:11 2017 New Revision: 321115 URL: http://llvm.org/viewvc/llvm-project?rev=321115&view=rev Log: Silence a bunch of implicit fallthrough warnings Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/lib/AST/Expr.cpp cfe/trunk/lib/AST/ExprCXX.cpp

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth marked 8 inline comments as done. Nebiroth added inline comments. Comment at: clangd/ClangdUnit.cpp:85 + +if (SourceMgr.getMainFileID() == SourceMgr.getFileID(FilenameRange.getAsRange().getBegin()) && SourceMgr.isInMainFile(FilenameRange.getAsRange().getBegin())) {

r321116 - Add explicit break (PR35700).

Author: adrian Date: Tue Dec 19 14:21:48 2017 New Revision: 321116 URL: http://llvm.org/viewvc/llvm-project?rev=321116&view=rev Log: Add explicit break (PR35700). Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp URL: http://llvm.o

[PATCH] D40939: [analyzer] NFC: Avoid element regions of void type.

NoQ added a comment. I guess i'd commit it together with https://reviews.llvm.org/D41250 in a single commit, so that there obviously were tests. https://reviews.llvm.org/D40939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D41415: [libcxx] implement casts.

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. This patch also changed all simd size-related types to size_t. Before the change, as P0214 proposed, they are half-int, half-size_t in different places. The inconsistency of size types c

[PATCH] D41319: libcxx: Fix for basic_stringbuf::seekoff() after r320604.

mclow.lists added inline comments. Comment at: libcxx/include/sstream:580 return pos_type(-1); +ptrdiff_t __hm = __hm_ == nullptr ? 0 : __hm_ - __str_.data(); off_type __noff; This can be const. https://reviews.llvm.org/D41319 _

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, bruno. Currently, we load all lazy template specializations when we search whether there is a suitable template specialization for a template. This is especially suboptimal with modules. If module `B` specializes a templat

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. This looks reasonable on the face of it. I'm assuming you know the layout for Solaris, and it doesn't seem to change the behavior of non-Solaris, so LGTM. https://reviews.llvm.org/D35755

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 127606. v.g.vassilev added a reviewer: rtrieu. v.g.vassilev added a comment. Fixed a comment typo. Repository: rL LLVM https://reviews.llvm.org/D41416 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp lib/Serialization/ASTReader

[PATCH] D39050: Add index-while-building support to Clang

ioeric added a comment. Thanks a lot for further cleaning up the patch! It is now much easier to review. I really appreciate it! Some more comments on the public APIs and the layering of classes. There are a lot of helper classes in the implementation, so I think it's important to get a clear

[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

smeenai added a comment. I posted to cfe-dev: http://lists.llvm.org/pipermail/cfe-dev/2017-December/056450.html Repository: rL LLVM https://reviews.llvm.org/D39462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D39050: Add index-while-building support to Clang

ioeric added inline comments. Comment at: include/clang/Index/IndexUnitDataConsumer.h:1 +//===--- IndexUnitDataConsumer.h - Abstract index unit data consumer ---===// +// ioeric wrote: > IIUC, this is the index data for a translation unit, as opposed

[PATCH] D41405: Fix an assertion failure regression in isDesignatorAtObjectEnd for __builtin_object_size with incomplete array type in struct

vsapsai added inline comments. Comment at: test/Sema/builtin-object-size.c:105 +void rd36094951_IAS_builtin_object_size_assertion(IncompleteArrayStruct* p) { + __builtin___strlcpy_chk (p->session[0].string, "ab", 2, __builtin_object_size(p->session[0].string, 1)); +} -

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ added a comment. TODOs for the future commits: - Constructor shouldn't cause pointer escape of the newly allocated pointer immediately after the NewAllocator callback, otherwise we ain't gonna find no leaks. Without `c++-allocator-inlining`, we only started tracking the pointer after the c

[PATCH] D41319: libcxx: Fix for basic_stringbuf::seekoff() after r320604.

pcc updated this revision to Diff 127609. pcc added a comment. - Make __hm const https://reviews.llvm.org/D41319 Files: libcxx/include/sstream libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/seekoff.pass.cpp Index: libcxx/test/std/input.output/string.streams/str

[PATCH] D41372: [libcxx] Fix transform_reduce mishandling move-only types, and nonstandard macro use in tests.

BillyONeal added a comment. Do you folks want me to port this test case for move-only T into libcxx? (I added this to our test harness) Note that discussion on validity is ongoing on lists. #define _SILENCE_PARALLEL_ALGORITHMS_EXPERIMENTAL_WARNING #include #include #include #includ

[PATCH] D41319: libcxx: Fix for basic_stringbuf::seekoff() after r320604.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. I'm going to sprinkle `const` throughout this file later, but that is a drive-by thing. All the lines that start out `ptrdiff_t __hm = ` will soon be `const ptrdiff_t __hm = `

[PATCH] D41319: libcxx: Fix for basic_stringbuf::seekoff() after r320604.

This revision was automatically updated to reflect the committed changes. pcc marked an inline comment as done. Closed by commit rL321124: libcxx: Fix for basic_stringbuf::seekoff() after r320604. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D41319?vs=1276

[libcxx] r321124 - libcxx: Fix for basic_stringbuf::seekoff() after r320604.

Author: pcc Date: Tue Dec 19 15:33:16 2017 New Revision: 321124 URL: http://llvm.org/viewvc/llvm-project?rev=321124&view=rev Log: libcxx: Fix for basic_stringbuf::seekoff() after r320604. As a result of this change, the basic_stringbuf constructor that takes a mode ends up leaving __hm_ set to 0,

[PATCH] D41417: [hwasan] Implement -fsanitize-recover=hwaddress.

eugenis created this revision. eugenis added reviewers: kcc, alekseyshl. Herald added subscribers: hiraditya, kubamracek. Very similar to AddressSanitizer, with the exception of the error type encoding. https://reviews.llvm.org/D41417 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/lib

[PATCH] D38639: [clangd] #include statements support for Open definition

Nebiroth updated this revision to Diff 127617. Nebiroth added a comment. Removed some useless inclusions Removed superfluous check when inserting data in map Moved addition to DeclarationLocations in finish() outside of DeclMacrosFinder Merged with revision 321087 (moved findDefinitions an

[PATCH] D41365: [clang] Add BeforeExecute method to PrecompiledPreamble

Nebiroth updated this revision to Diff 127619. Nebiroth marked 2 inline comments as done. Nebiroth added a comment. Modified comment Changed where BeforeExecute is called Repository: rC Clang https://reviews.llvm.org/D41365 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend

[PATCH] D41417: [hwasan] Implement -fsanitize-recover=hwaddress.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM with a nit Comment at: compiler-rt/lib/hwasan/hwasan.cc:255 -template +template __attribute__((always_inline, nodebug)) I'd prefer enums to booleans, for b

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 127622. timshen added a comment. include "test_macros.h" in the tests https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp libcxx/test/s

[PATCH] D40841: [analyzer] Fix a crash on C++17 AST for non-trivial construction into a trivial brace initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321128: [analyzer] Fix a crash during C++17 aggregate construction of base objects. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D40841?vs=125629&id=127624#t

r321128 - [analyzer] Fix a crash during C++17 aggregate construction of base objects.

Author: dergachev Date: Tue Dec 19 16:40:38 2017 New Revision: 321128 URL: http://llvm.org/viewvc/llvm-project?rev=321128&view=rev Log: [analyzer] Fix a crash during C++17 aggregate construction of base objects. Since C++17, classes that have base classes can potentially be initialized as aggrega

[PATCH] D41417: [hwasan] Implement -fsanitize-recover=hwaddress.

eugenis added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cc:255 -template +template __attribute__((always_inline, nodebug)) kcc wrote: > I'd prefer enums to booleans, for better readability good idea! https://reviews.llvm.org/D41417 __

[PATCH] D41421: Eliminate a magic number. NFC.

mattd created this revision. mattd added a reviewer: bkramer. Calculate sizeof Buffer instead of using a magic value. https://reviews.llvm.org/D41421 Files: PrintPreprocessedOutput.cpp Index: PrintPreprocessedOutput.cpp === ---

r321129 - [X86] Add more CPUID bits to cpuid.h to match gcc and support icelake features.

Author: ctopper Date: Tue Dec 19 16:46:09 2017 New Revision: 321129 URL: http://llvm.org/viewvc/llvm-project?rev=321129&view=rev Log: [X86] Add more CPUID bits to cpuid.h to match gcc and support icelake features. Modified: cfe/trunk/lib/Headers/cpuid.h Modified: cfe/trunk/lib/Headers/cpuid.

r321130 - [analyzer] trackNullOrUndefValue: track last store to non-variables.

Author: dergachev Date: Tue Dec 19 16:47:17 2017 New Revision: 321130 URL: http://llvm.org/viewvc/llvm-project?rev=321130&view=rev Log: [analyzer] trackNullOrUndefValue: track last store to non-variables. When reporting certain kinds of analyzer warnings, we use the bugreporter::trackNullOrUndefV

[PATCH] D41253: [analyzer] WIP: trackNullOrUndefValue: track last store to symbolic pointers.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321130: [analyzer] trackNullOrUndefValue: track last store to non-variables. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41253 Files: lib/StaticAnalyzer/Co

[PATCH] D41422: [libcxx] implement operators and reduction.

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. This patch completes the implementation of simd<> and related operations. https://reviews.llvm.org/D41422 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd

[PATCH] D41421: Eliminate a magic number. NFC.

efriedma added a comment. Please use llvm::array_lengthof to compute the length of an array. Alternatively, there's an overload of PP.getSpelling which takes a SmallVector and returns a StringRef as a parameter; you could change this code to use it, which would remove the need for the check.

[PATCH] D41423: [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

vsapsai created this revision. vsapsai added reviewers: arphaman, kcc. Fix makes the loop in LexAngledStringLiteral more like the loops in LexStringLiteral, LexCharConstant. When we skip a character after backslash, we need to check if we reached the end of the file instead of reading the next cha

[PATCH] D41258: [analyzer] trackNullOrUndefValue: deduplicate path pieces for each node.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321135: [analyzer] De-duplicate path diagnostics for each exploded graph node. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41258 Files: include/clang/Stati

r321135 - [analyzer] De-duplicate path diagnostics for each exploded graph node.

Author: dergachev Date: Tue Dec 19 17:17:53 2017 New Revision: 321135 URL: http://llvm.org/viewvc/llvm-project?rev=321135&view=rev Log: [analyzer] De-duplicate path diagnostics for each exploded graph node. The bugreporter::trackNullOrUndefValue() mechanism contains a system of bug reporter visit

[PATCH] D41424: [darwin][driver] Warn about mismatching --version-min rather than superfl

arphaman created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D41424 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/darwin-version.c Index: test/Driver/darwin-version.c ==

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

arphaman created this revision. arphaman added reviewers: bob.wilson, dexonsmith, steven_wu. The warning about the superfluous `--version-min` compiler option seems a little too strong right now. For now we should only warn about `--version-min` options that specify a different OS version to the

r321139 - Revert r320942, "[ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr"

Author: pcc Date: Tue Dec 19 17:47:08 2017 New Revision: 321139 URL: http://llvm.org/viewvc/llvm-project?rev=321139&view=rev Log: Revert r320942, "[ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr" Caused a test failure on Windows: [ RUN ] ImportExpr.Impo

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen updated this revision to Diff 127638. timshen added a comment. s/_LIBCPP_HAS_VECTOR_EXTENSION/_LIBCPP_HAS_NO_VECTOR_EXTENSION/ https://reviews.llvm.org/D41376 Files: libcxx/include/__config libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/include/util

Re: r320942 - [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr

Hi, I reverted this change in r321139 because it causes a test failure on Windows. e.g. https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_upload_clang%2F277%2F%2B%2Frecipes%2Fsteps%2Fpackage_clang%2F0%2Fstdout Please let me know if you have trouble reproducing. Thanks, P

[PATCH] D41415: [libcxx] implement casts.

timshen updated this revision to Diff 127639. timshen added a comment. s/_LIBCPP_HAS_VECTOR_EXTENSION/_LIBCPP_HAS_NO_VECTOR_EXTENSION/ https://reviews.llvm.org/D41415 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.casts/simd_cast.pass.cpp libcxx/test/std/ex

[PATCH] D41417: [hwasan] Implement -fsanitize-recover=hwaddress.

eugenis updated this revision to Diff 127640. eugenis added a comment. Replaced booleans with enums. Added __builtin_unreachable in non-recover variants of callbacks. https://reviews.llvm.org/D41417 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/lib/hwasan/hwasan.cc compiler-rt/lib/

[PATCH] D41421: Eliminate a magic number. NFC.

mattd updated this revision to Diff 127641. mattd added a comment. Thanks for the suggestion Eli. Took your initial suggestion. https://reviews.llvm.org/D41421 Files: lib/Frontend/PrintPreprocessedOutput.cpp Index: lib/Frontend/PrintPreprocessedOutput.cpp ==

[PATCH] D41421: Eliminate a magic number. NFC.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D41394: [CodeGen] Support generation of TBAA info in the new format

hfinkel added a comment. In https://reviews.llvm.org/D41394#959715, @rjmccall wrote: > Rewriting some of the most basic tests would be fine. Please either use new > FileCheck lines or clone the existing tests, since we don't really know how > long this transition will last. +1 Otherwise, th

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

bob.wilson accepted this revision. bob.wilson added a comment. This revision is now accepted and ready to land. Eventually it would be nice to also warn about redundant -m*-version-min options, but for now I agree that it would be best to start with warning only when the options are different.

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

steven_wu accepted this revision. steven_wu added a comment. Just a small suggestion. Looks good otherwise. Comment at: lib/Driver/ToolChains/Darwin.cpp:1536 + Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(), + ArgMajor

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

arphaman added inline comments. Comment at: lib/Driver/ToolChains/Darwin.cpp:1536 + Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(), + ArgMajor, ArgMinor, ArgMicro, HadExtra) && + VersionTuple(TargetMajor, Targe

[PATCH] D41417: [hwasan] Implement -fsanitize-recover=hwaddress.

eugenis updated this revision to Diff 127642. eugenis added a comment. Tweaked a test. https://reviews.llvm.org/D41417 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/lib/hwasan/hwasan.cc compiler-rt/lib/hwasan/hwasan_interface_internal.h compiler-rt/lib/hwasan/hwasan_linux.cc co

[PATCH] D41399: [CodeGen] Represent array members in new-format TBAA type descriptors

hfinkel added inline comments. Comment at: test/CodeGen/tbaa-array.cpp:24 +// CHECK-DAG: [[TAG_A_i]] = !{[[TYPE_A:!.*]], [[TYPE_int:!.*]], i64 0, i64 4} +// CHECK-DAG: [[TAG_C_i]] = !{[[TYPE_C:!.*]], [[TYPE_int:!.*]], i64 0, i64 16} +// CHECK-DAG: [[TYPE_A]] = !{[[TYPE_char:!.*]]

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

steven_wu added inline comments. Comment at: lib/Driver/ToolChains/Darwin.cpp:1536 + Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(), + ArgMajor, ArgMinor, ArgMicro, HadExtra) && + VersionTuple(TargetMajor, Targ

[PATCH] D40299: [Complex] Don't use __div?c3 when building with fast-math.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

arphaman added inline comments. Comment at: lib/Driver/ToolChains/Darwin.cpp:1536 + Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(), + ArgMajor, ArgMinor, ArgMicro, HadExtra) && + VersionTuple(TargetMajor, Targe

r321145 - [darwin][driver] Warn about mismatching --version-min rather than

Author: arphaman Date: Tue Dec 19 18:31:30 2017 New Revision: 321145 URL: http://llvm.org/viewvc/llvm-project?rev=321145&view=rev Log: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option rdar://35813850 Differential Revision: https://review

[PATCH] D41425: [darwin][driver] Warn about mismatching --version-min rather than superfluous --version-min compiler option

This revision was automatically updated to reflect the committed changes. Closed by commit rL321145: [darwin][driver] Warn about mismatching --version-min rather than (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D41425?vs=127637&id=127648#toc Rep

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

vsapsai added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2321 + !isa(ConvertType(Arg->getType())) && ArgI.getCoerceToType() == ConvertType(Ty) && ArgI.getDirectOffset() == 0) { rjmccall wrote: > I think the right fix

[PATCH] D41421: Eliminate a magic number. NFC.

mattd added a comment. Thanks Eli! I do not have commit permissions, so someone else will have to commit this on my behalf. https://reviews.llvm.org/D41421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

faisalv requested changes to this revision. faisalv added a comment. This revision now requires changes to proceed. Hmm - I think i might make some tweaks to this patch (to be largely symmetric with the similar handling of invalid decl-specifiers on function parameters in Sema::Actions.ActOnPara

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Tue, Dec 12, 2017 at 12:12 PM, John McCall wrote: > On Tue, Dec 12, 2017 at 1:45 PM, David Blaikie wrote: > >> On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote: >> >>> On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie >>> wrote: >>> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabric

<    1   2