[PATCH] D41421: Eliminate a magic number. NFC.

[Matt Davis via Phabricator via cfe-commits]

mattd created this revision.
mattd added a reviewer: bkramer.

Calculate sizeof Buffer instead of using a magic value.


https://reviews.llvm.org/D41421

Files:
  PrintPreprocessedOutput.cpp


Index: PrintPreprocessedOutput.cpp
===================================================================
--- PrintPreprocessedOutput.cpp
+++ PrintPreprocessedOutput.cpp
@@ -752,7 +752,7 @@
     } else if (Tok.isLiteral() && !Tok.needsCleaning() &&
                Tok.getLiteralData()) {
       OS.write(Tok.getLiteralData(), Tok.getLength());
-    } else if (Tok.getLength() < 256) {
+    } else if (Tok.getLength() < sizeof(Buffer)) {
       const char *TokPtr = Buffer;
       unsigned Len = PP.getSpelling(Tok, TokPtr);
       OS.write(TokPtr, Len);



Index: PrintPreprocessedOutput.cpp
===================================================================
--- PrintPreprocessedOutput.cpp
+++ PrintPreprocessedOutput.cpp
@@ -752,7 +752,7 @@
     } else if (Tok.isLiteral() && !Tok.needsCleaning() &&
                Tok.getLiteralData()) {
       OS.write(Tok.getLiteralData(), Tok.getLength());
-    } else if (Tok.getLength() < 256) {
+    } else if (Tok.getLength() < sizeof(Buffer)) {
       const char *TokPtr = Buffer;
       unsigned Len = PP.getSpelling(Tok, TokPtr);
       OS.write(TokPtr, Len);

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits