steven_wu accepted this revision. steven_wu added a comment. Just a small suggestion. Looks good otherwise.
================ Comment at: lib/Driver/ToolChains/Darwin.cpp:1536 + Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(), + ArgMajor, ArgMinor, ArgMicro, HadExtra) && + VersionTuple(TargetMajor, TargetMinor, TargetMicro) != ---------------- HadExtra is not ok right? macos10.11.0.1 is not the same as macos10.11.0? Or HadExtra is an error somewhere else already? Repository: rC Clang https://reviews.llvm.org/D41425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
