steven_wu added inline comments.

================
Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+           Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(),
+                                     ArgMajor, ArgMinor, ArgMicro, HadExtra) &&
+           VersionTuple(TargetMajor, TargetMinor, TargetMicro) !=
----------------
arphaman wrote:
> steven_wu wrote:
> > HadExtra is not ok right? macos10.11.0.1 is not the same as macos10.11.0?
> > Or HadExtra is an error somewhere else already?
> Right, it would be nice to check the extra stuff too. I will commit with the 
> check and a test for the extra part.
And what about "-target x86_64-apple-macos -mmacos-version-min=10.6"?


Repository:
  rC Clang

https://reviews.llvm.org/D41425



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to