mgorny added inline comments.
> driver.cpp:314
> +
> +static llvm::cl::SearchResult findConfigFileFromProgramName(
> +llvm::SmallVectorImpl &ConfigName, StringRef ProgramName) {
Please document what this function does, exactly. I see you've documented it in
call site but a doc here would be
SjoerdMeijer abandoned this revision.
SjoerdMeijer added a comment.
Ok, thanks for the feedback and looking into this. I will abandon this change.
To still answer your question, there is nothing more to it than emitting an
AArch64 build attribute symbol (for library selection). This done based o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283092: [analyzer] Extend bug reports with extra notes
(authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D24278?vs=72519&id=73406#toc
Repository:
rL LLVM
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283114: [OpenCL] Fix bug in __builtin_astype causing invalid
LLVM cast instructions (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25123?vs=73125&id=73412#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283109: This adds a separate file for the fp denormal
regression tests. NFC. (authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D24907?vs=72457&id=73411#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283094: [analyzer] Improve CloneChecker diagnostics
(authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D24916?vs=72991&id=73408#toc
Repository:
rL LLVM
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283102: Fix PR 28885: Fix AST Printer output for the
inherited constructor using (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25131?vs=73145&id=73410#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283093: [analyzer] Add extra notes to ObjCDeallocChecker
(authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D24915?vs=72520&id=73407#toc
Repository:
rL LLVM
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283120: [CUDA] Disallow overloading destructors. (authored
by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24571?vs=71379&id=73413#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283135: Added more comments to tooling::Replacements.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25207?vs=73322&id=73414#toc
Repository:
rL LLVM
https://reviews.llvm.or
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25226
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25227
Files:
clang-move/ClangMove.cpp
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
==
Author: dberris
Date: Tue Oct 4 03:22:47 2016
New Revision: 283193
URL: http://llvm.org/viewvc/llvm-project?rev=283193&view=rev
Log:
[XRay] Check in Clang whether XRay supports the target when -fxray-instrument
is passed
Added the code which explicitly emits an error in Clang in case
`-fxray-in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283193: [XRay] Check in Clang whether XRay supports the
target when -fxray-instrument… (authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D24799?vs=72554&id=73424#toc
Repository:
hokein updated this revision to Diff 73426.
hokein marked 3 inline comments as done.
hokein added a comment.
Herald added subscribers: mgorny, beanz.
Add clang-move tool in test/CMakeLists.
https://reviews.llvm.org/D24922
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/t
Author: chapuni
Date: Tue Oct 4 03:32:33 2016
New Revision: 283195
URL: http://llvm.org/viewvc/llvm-project?rev=283195&view=rev
Log:
Revert r283106, "Wdocumentation fix"
It should depend on r283094 and r283182.
Modified:
cfe/trunk/lib/Analysis/CloneDetection.cpp
Modified: cfe/trunk/lib/Ana
chapuni added inline comments.
> CloneDetection.cpp:113
>/// \param VarDecl The declaration of the variable that is referenced.
>/// \param Range The SourceRange where this variable is referenced.
> + void addVariableOccurence(const VarDecl *VarDecl, const Stmt *Mention) {
You should up
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Thanks for the fix! :)
> ChangeNamespace.cpp:110-112
> + if (SM.getLocForEndOfFile(LocInfo.first) == End)
> +return End;
> + return End.getLocWithOffset(1);
return (SM.getLocForEndOfFi
ioeric added a comment.
Ping
https://reviews.llvm.org/D25065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dberris
Date: Tue Oct 4 03:54:51 2016
New Revision: 283199
URL: http://llvm.org/viewvc/llvm-project?rev=283199&view=rev
Log:
Revert "[XRay] Check in Clang whether XRay supports the target when
-fxray-instrument is passed"
This reverts 283193 -- broke the build.
Removed:
cfe/trunk/t
dberris reopened this revision.
dberris added a comment.
This revision is now accepted and ready to land.
This broke the build on i686.
TEST 'Clang :: Driver/xray-instrument.c' FAILED
Script:
--
C:/bb-win/ninja-clang-i686-msc19-R/build/./bin/clan
dberris requested changes to this revision.
dberris added a subscriber: rengolin.
dberris added a comment.
This revision now requires changes to proceed.
I'm not sure whether the exhaustive list scales though... is there a better way
of doing this? Maybe @rengolin has better ideas here?
Reposit
Author: hokein
Date: Tue Oct 4 04:05:31 2016
New Revision: 283202
URL: http://llvm.org/viewvc/llvm-project?rev=283202&view=rev
Log:
[clang-move] Make it support both relative and absolute file path arguments.
Reviewers: ioeric
Subscribers: beanz, mgorny, cfe-commits
Differential Revision: http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283202: [clang-move] Make it support both relative and
absolute file path arguments. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24922?vs=73426&id=73433#toc
Repository:
r
This is not due to the upgrade. There was long delay before Phabricator
receives a commit, but the delay seems to be gone now. Let me know if you
are still experiencing the delay.
- Eric
On Mon, Oct 3, 2016 at 4:25 PM Michał Górny wrote:
> On Mon, 3 Oct 2016 13:47:08 +
> Sjoerd Meijer via c
rmaprath added a comment.
LGTM too.
@EricWF or @mclow.lists need to approve.
https://reviews.llvm.org/D24082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Eric, please, prepare a full context review!
> ItaniumMangle.cpp:1417-1421
> + if (isRegCall) {
> +Out << II->getLength() + sizeof("__regcall3__") - 1<< "__regcall3__";
> + } else {
> +Out << II->getLength();
> + }
Single-line substatements must not be enclo
Author: hokein
Date: Tue Oct 4 04:49:20 2016
New Revision: 283205
URL: http://llvm.org/viewvc/llvm-project?rev=283205&view=rev
Log:
Fix windows builtbot error.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp
URL:
http://
Author: klimek
Date: Tue Oct 4 04:53:04 2016
New Revision: 283206
URL: http://llvm.org/viewvc/llvm-project?rev=283206&view=rev
Log:
Minor cleanups in clang-format.el.
- Enable lexical binding
- Formatting
- Enable file name completion for the clang-format-executable variable
- Add a missing docs
hokein added a comment.
Looks almost fine, a few code-style comments.
> ASTUtils.h:11
> +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H
> +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H
> +#include "clang/AST/AST.h"
A blank line between define guard and include.
> ASTUtils.h:17
>
Author: sepavloff
Date: Tue Oct 4 05:11:43 2016
New Revision: 283207
URL: http://llvm.org/viewvc/llvm-project?rev=283207&view=rev
Log:
Do not find friend function definitions inside non-instantiated class.
Previously if a file-level function was defined inside befriending
template class, it alwa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283207: Do not find friend function definitions inside
non-instantiated class. (authored by sepavloff).
Changed prior to commit:
https://reviews.llvm.org/D16989?vs=70134&id=73440#toc
Repository:
rL L
asavonic updated this revision to Diff 73443.
asavonic added a comment.
- Describe OpenCLOptions::set() function
- Move -cl-ext option to cc1
- Reword -cl-ext option help
- Move -cl-ext handling out of target-specific code
- Add two more test cases regarding -cl-ext option
https://reviews.llvm.o
ioeric updated this revision to Diff 73446.
ioeric added a comment.
Herald added a subscriber: modocache.
- Add SymbolRenameSpec; replace addIncludesToFiles and renameSymbolsInFiles
with renameSymbolsInAffectedFiles.
https://reviews.llvm.org/D24380
Files:
CMakeLists.txt
migrate-tool/Affect
Author: hokein
Date: Tue Oct 4 05:35:53 2016
New Revision: 283210
URL: http://llvm.org/viewvc/llvm-project?rev=283210&view=rev
Log:
[change-namespace] Fix a misplaced case when there is no trailing newline
character at the end of the file.
Reviewers: ioeric
Subscribers: cfe-commits
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283210: [change-namespace] Fix a misplaced case when there
is no trailing newline… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25226?vs=73420&id=73447#toc
Repository:
rL
Author: hokein
Date: Tue Oct 4 05:40:52 2016
New Revision: 283211
URL: http://llvm.org/viewvc/llvm-project?rev=283211&view=rev
Log:
Fix a documentation warning.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.h
Modified: clang-tools-extra/trunk/clang-move/ClangMove.h
URL:
http://llv
ioeric added a comment.
This is great!
> ClangMove.cpp:70-74
> + if (SM->getLocForEndOfFile(LocInfo.first)
> + == EndLoc)
> +return EndLoc;
> + // Include the trailing newline character "\n".
> + return EndLoc.getLocWithOffset(1);
Maybe:
return (SM->getLocForEndOfFile(LocInfo.fi
malcolm.parsons updated this revision to Diff 73452.
malcolm.parsons added a comment.
Don't match template instantiations.
Add assert message.
Update macro comment.
Add tests for templates and macros.
https://reviews.llvm.org/D24965
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.c
szepet updated this revision to Diff 73439.
szepet marked an inline comment as done.
szepet added a comment.
Herald added a subscriber: modocache.
Note message checks added to testfiles.
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
lukasza added a comment.
Richard - what are the next steps for this patch?
https://reviews.llvm.org/D24361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
> ChangeNamespace.cpp:176
> +// \param DeclName A fully qualified name, "::a::b::X" or "a::b::X".
> +// \param NsName A fully qualified name, "::a::b" or "a::b".
> std::string getShortestQualifiedNameInNamespace(llvm::StringRef DeclName,
Mightbe add a small doc say
Pajesz requested a review of this revision.
Pajesz added reviewers: dkrupp, xazax.hun, nlewycky, etienne.bergeron, etienneb.
Pajesz marked an inline comment as done.
Pajesz added a comment.
Hello!
Gonna fix the tests ASAP! Any other suggestions, fixes, improvements
considering the checker?
htt
ioeric updated this revision to Diff 73459.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Address review comments.
https://reviews.llvm.org/D25065
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-n
ioeric added inline comments.
> hokein wrote in ChangeNamespace.cpp:187
> I think the statement doesn't compile here, since `consume_front` return a
> `bool`. It should be `if (DeclName.consume_front((NsName + "::")))`?
>
> Looks like we can also put this judge into the above `while` statement?
hokein added inline comments.
> ioeric wrote in ClangMove.cpp:343
> Looks like `GetFullRange` is called twice on the same Decl: one for creating
> insertion replacement and one for deletion replacement. This seems to be a
> duplicate.
Good point. Yeah, currently the `GetFullRange` is called tw
hokein updated this revision to Diff 73463.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D25227
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTe
arphaman updated this revision to Diff 73460.
arphaman marked an inline comment as done.
arphaman added a comment.
Thanks for the response,
I updated the patch with a approach that you suggested - now
`Sema::CreateOverloadedBinOp` isn't called in C mode (I have an assertion for
this in `Sema::C
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Hi Tim,
This patch seems stale. I think neither me nor Richard have any strong feelings
against this, so I'll just approve and let you decide on which solution is
best. I have a mild pref
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
> ioeric wrote in ChangeNamespace.cpp:187
> Note that `str()` is called on `(NsName + "::")` instead of `consume_front`.
> But you are right, we can put the check into the while loop.
rengolin added a comment.
In https://reviews.llvm.org/D24083#534464, @EricWF wrote:
> In https://reviews.llvm.org/D24083#534459, @logan wrote:
>
> > One solution might be adding the `libclang_rt.builtins.${arch}.a` detection
> > rules[1] to CMakeLists.txt, and manually specify
> > `-lclang_rt.b
rengolin added a comment.
@EricWF any comments?
https://reviews.llvm.org/D24084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added reviewers: echristo, dberlin, keith.walker.arm.
rengolin added a comment.
Hi Sylvestre,
Paul's comments on the bug are still pertinent: `-Og` is not the same as `-O1`.
`-Og` means for "optimised for debuggers" which is short for "preserve the
debug illusion without bloating the c
rogfer01 updated this revision to Diff 73466.
rogfer01 added a comment.
Change algorithm following @rsmith suggestions by computing the offset of the
whole access and compare it against the expected alignment, so reduced aligned
structs inside overaligned structs does not yield a warning.
Also
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D25106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: davide
Date: Tue Oct 4 08:16:00 2016
New Revision: 283217
URL: http://llvm.org/viewvc/llvm-project?rev=283217&view=rev
Log:
[ThinLTO] Spell `llvm-ar` correctly.
Modified:
cfe/trunk/docs/ThinLTO.rst
Modified: cfe/trunk/docs/ThinLTO.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
vbyakovlcl added inline comments.
> aaron.ballman wrote in DiagnosticGroups.td:522
> I would not add this as a diagnostic group, but instead use an ad-hoc group
> on the diagnostic itself. I don't think this is going to see very many
> diagnostics covered by the same group, but if that turns ou
aaron.ballman added a comment.
Generally looks good to me, sorry I missed these tiny nits last time around.
> ProTypeMemberInitCheck.h:49
>void checkMissingMemberInitializer(ASTContext &Context,
> + const CXXRecordDecl *ClassDecl,
>
vbyakovlcl removed rL LLVM as the repository for this revision.
vbyakovlcl updated this revision to Diff 73468.
https://reviews.llvm.org/D24669
Files:
llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/Sema/vecshift.c
In
NoQ updated this revision to Diff 73472.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Fix review comments.
Correct the order of expected-notes in one of the tests (it doesn't affect how
the test works).
https://reviews.llvm.org/D25092
Files:
lib/StaticAnalyzer/Core/BugReporter
Author: marshall
Date: Tue Oct 4 08:41:56 2016
New Revision: 283218
URL: http://llvm.org/viewvc/llvm-project?rev=283218&view=rev
Log:
Mark #2739 as ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-proje
NoQ added inline comments.
> zaks.anna wrote in BugReporterVisitors.cpp:1302
> Is this expected to ever trigger?
Ouch right.
https://reviews.llvm.org/D25092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
aaron.ballman added inline comments.
> readability-redundant-member-init.cpp:162
> + const S f;
> +};
Missing a test for `union` member initializers. Also, a test that multiple
inheritance doesn't cause a fixit malfunction would be nice.
https://reviews.llvm.org/D24339
malcolm.parsons updated this revision to Diff 73474.
malcolm.parsons added a comment.
Pass records by reference.
Change test to trigger diagnostic for non-template type
https://reviews.llvm.org/D24965
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tidy/cppcoreguideline
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D24965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24965#560785, @aaron.ballman wrote:
> LGTM, thank you!
I don't have commit access, so please commit this for me.
Thanks.
https://reviews.llvm.org/D24965
___
cfe-commits mailing list
cf
Author: marshall
Date: Tue Oct 4 09:08:50 2016
New Revision: 283220
URL: http://llvm.org/viewvc/llvm-project?rev=283220&view=rev
Log:
Mark #2598 as ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-proje
malcolm.parsons added inline comments.
> aaron.ballman wrote in readability-redundant-member-init.cpp:162
> Missing a test for `union` member initializers. Also, a test that multiple
> inheritance doesn't cause a fixit malfunction would be nice.
Note that all the fixits malfunction until https:
malcolm.parsons updated this revision to Diff 73479.
malcolm.parsons added a comment.
Add test for initializing a union member.
Add test for multiple inheritance.
https://reviews.llvm.org/D24339
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
Author: marshall
Date: Tue Oct 4 09:39:58 2016
New Revision: 283222
URL: http://llvm.org/viewvc/llvm-project?rev=283222&view=rev
Log:
Mark #2759 as ready and #2755 as complete
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm
Author: davidsh
Date: Tue Oct 4 09:41:36 2016
New Revision: 283223
URL: http://llvm.org/viewvc/llvm-project?rev=283223&view=rev
Log:
[OpenMP] fix segfault when a variable referenced in reduction clause is a
reference parameter\nDifferential Revision: http://reviews.llvm.org/D24524
Modified:
Author: aaronballman
Date: Tue Oct 4 09:48:05 2016
New Revision: 283224
URL: http://llvm.org/viewvc/llvm-project?rev=283224&view=rev
Log:
Fix some false-positives with cppcoreguidelines-pro-type-member-init. Handle
classes with default constructors that are defaulted or are not present in the
A
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r283224.
https://reviews.llvm.org/D24965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sepavloff updated this revision to Diff 73482.
sepavloff added a comment.
Updated comments.
https://reviews.llvm.org/D24933
Files:
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
test/Driver/Inputs/config-1.cfg
test/Driver/Inputs/config-2.cfg
test/Driver/config-file.c
test/Drive
sepavloff added inline comments.
> mgorny wrote in driver.cpp:314
> Please document what this function does, exactly. I see you've documented it
> in call site but a doc here would be helpful as well.
The function is documented now.
> mgorny wrote in driver.cpp:376
> Are you sure about the nam
szepet abandoned this revision.
szepet added a comment.
At first I was not able to reproduce it. Then I realized it was my foul because
I used the analyzer without the core checkers in this case. Sorry for the false
positive.
https://reviews.llvm.org/D23853
_
spatel added inline comments.
> mehdi_amini wrote in CGCall.cpp:1735
> I wonder if we couldn’t have this part of the bitcode/IR auto-upgrade: when
> we load a function with this attribute, we automatically add the individual
> flag on every instruction.
Auto-upgrading is part of the solution.
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, mgehre.
malcolm.parsons added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
Empty/incomplete variables/members/bases don't need to be initialized
https://reviews.llvm.org/D25238
File
filcab added a comment.
In https://reviews.llvm.org/D25199#560061, @vsk wrote:
> My question was about whether it's possible to resume normal program
> execution after printing the stack trace from the segv handler. I had assumed
> this is not possible, and (mistakenly) thought that you were su
erichkeane added a comment.
Hi Alexey-
Can you let me know what you mean by "Full Context Review"? I'm unfamiliar
with that process. The other fixes I'll look at today.
Repository:
rL LLVM
https://reviews.llvm.org/D25204
___
cfe-commits mailin
ahatanak added inline comments.
> SemaExpr.cpp:8787
> }
> +if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
> + const BuiltinType *LHSBT = LHSEleType->getAs();
Is it possible to use ASTContext::getTypeSize here?
https://reviews.llvm.org/D24669
__
ahatanak added a comment.
ping
https://reviews.llvm.org/D25001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
ping
https://reviews.llvm.org/D24969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane removed rL LLVM as the repository for this revision.
erichkeane updated this revision to Diff 73489.
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/Specifi
erichkeane marked 4 inline comments as done.
erichkeane added a comment.
Updated the code, fixed Alexey's concerns. Thanks again for the comments!
https://reviews.llvm.org/D25204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
rsmith added inline comments.
> SemaTemplateInstantiateDecl.cpp:4849
> + DeclarationName Name = D->getDeclName();
> + if (auto *DD = dyn_cast(D))
> +Name =
Do we need to do this for conversion function names too? (Eg, `operator C1*`)
https://reviews.llvm.org/D24969
ABataev added a comment.
In https://reviews.llvm.org/D25204#560894, @erichkeane wrote:
> Hi Alexey-
> Can you let me know what you mean by "Full Context Review"? I'm unfamiliar
> with that process. The other fixes I'll look at today.
Check this page http://llvm.org/docs/Phabricator.html
use
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D23712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
erichkeane updated this revision to Diff 73490.
erichkeane added a comment.
Did a full context diff, as requested.
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/Sp
rsmith added inline comments.
> PrintPreprocessedOutput.cpp:328
> + case '"': // paths are enclosed in quotes; escape them
> + case '*': // don't allow a "*/" sequence to accidentally open the
> comment
> + case '\\': // escape the escape character itself.
Putting a \ before a
Author: rnk
Date: Tue Oct 4 10:57:49 2016
New Revision: 283227
URL: http://llvm.org/viewvc/llvm-project?rev=283227&view=rev
Log:
[MS] Move hex long long sign compat hack to -fms-compatibility
Treating large 0x*LL literals as signed instead of unsigned is not a
conforming language extension, so m
brucem created this revision.
brucem added a subscriber: cfe-commits.
By manipulating a local variable in the loop, when the loop can
be optimized away (due to no non-trivial destructors), this lets
it be fully optimized away and we modify the __end_ separately.
This results in a substantial impr
Author: arphaman
Date: Tue Oct 4 11:06:37 2016
New Revision: 283228
URL: http://llvm.org/viewvc/llvm-project?rev=283228&view=rev
Log:
[Sema] Format a comment line so that it fits 80 columns. NFC
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
arphaman added a comment.
Thanks for working on this!
This patch fixes a couple of our internal warnings that shouldn't be presented.
I included a code sample that reproduces our warnings, would you mind adding
some code to the test case that's similar to the sample below?
typedef str
arphaman added a comment.
In https://reviews.llvm.org/D23657#560938, @arphaman wrote:
> Btw, slightly off-topic, but I noticed that the declaration
> `DiagnoseMisalignedMembers` in the header has a doc comment that violates the
> 80 chars rule. I committed a fix in r283228.
I meant to say `Di
ABataev added inline comments.
> Index.h:3029
>CXCallingConv_PreserveAll = 15,
> + CXCallingConv_X86RegCall = 16,
>
Maybe it is better to use 8, as the previous comment allows it?
/* Value 8 was PnaclCall, but it was never used, so it could safely be
re-used. */
In this case you don'
rogfer01 added a comment.
@arphaman thanks for the testcase! Will do.
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie added inline comments.
> debug-options.c:21-22
>
> +// RUN: %clang -### -c -Og -g %s -target x86_64-linux-gnu 2>&1 \
> +// RUN: | FileCheck -check-prefix=G -check-prefix=G_GDB %s
> +
I don't think we need this test case: -Og doesn't actually have anything to do
with -g me
joerg added a comment.
Seems to work for the false positives I have identified so far.
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
> AttrDocs.td:1263
> +On x86 targets, this attribute changes the calling convention to
> +__regcall convention. This convention aimes to pass as many arguments
> +as possible in registers. It also tries to utilize registers for the
"aims"
> TargetInfo.cpp:3306
> + //
1 - 100 of 223 matches
Mail list logo
